Re: [PATCH v3 1/7] max8903: adds documentation for device tree bindings.

[Chris Lapa]

On 20/06/2016 11:22 PM, Rob Herring wrote:

On Fri, Jun 17, 2016 at 03:00:20PM +1000, Chris Lapa wrote:

From: Chris Lapa 

Signed-off-by: Chris Lapa 
---
 .../devicetree/bindings/power/max8903-charger.txt  | 25 ++
 1 file changed, 25 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/max8903-charger.txt

diff --git a/Documentation/devicetree/bindings/power/max8903-charger.txt 
b/Documentation/devicetree/bindings/power/max8903-charger.txt
new file mode 100644
index 000..aea1dd2a
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/max8903-charger.txt
@@ -0,0 +1,25 @@
+Maxim Semiconductor MAX8903 Battery Charger bindings
+
+Required properties:
+- compatible: "maxim,max8903-charger" for MAX8903 Battery Charger


Drop "charger" as that is implied by the chip.

Just for clarification, you mean:
compatible: "maxim,max8903" for MAX8903 Battery Charger

Thanks,
Chris




+- dok-gpios: Valid DC power has been detected, optional if uok-gpios is 
provided
+- uok-gpios: Valid USB power has been detected, optional if dok-gpios is 
provided
+
+Optional properties:
+- cen-gpios: Charge enable pin
+- chg-gpios: Charger status pin
+- flt-gpios: Fault pin
+- dcm-gpios: Current limit mode setting (DC or USB)
+- usus-gpios: USB suspend pin


Need to state direction and active state for all of these.

Re: [PATCH v3 1/7] max8903: adds documentation for device tree bindings.

[Chris Lapa]

On 20/06/2016 11:22 PM, Rob Herring wrote:

On Fri, Jun 17, 2016 at 03:00:20PM +1000, Chris Lapa wrote:

From: Chris Lapa 

Signed-off-by: Chris Lapa 
---
 .../devicetree/bindings/power/max8903-charger.txt  | 25 ++
 1 file changed, 25 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/max8903-charger.txt

diff --git a/Documentation/devicetree/bindings/power/max8903-charger.txt 
b/Documentation/devicetree/bindings/power/max8903-charger.txt
new file mode 100644
index 000..aea1dd2a
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/max8903-charger.txt
@@ -0,0 +1,25 @@
+Maxim Semiconductor MAX8903 Battery Charger bindings
+
+Required properties:
+- compatible: "maxim,max8903-charger" for MAX8903 Battery Charger


Drop "charger" as that is implied by the chip.

Just for clarification, you mean:
compatible: "maxim,max8903" for MAX8903 Battery Charger

Thanks,
Chris




+- dok-gpios: Valid DC power has been detected, optional if uok-gpios is 
provided
+- uok-gpios: Valid USB power has been detected, optional if dok-gpios is 
provided
+
+Optional properties:
+- cen-gpios: Charge enable pin
+- chg-gpios: Charger status pin
+- flt-gpios: Fault pin
+- dcm-gpios: Current limit mode setting (DC or USB)
+- usus-gpios: USB suspend pin


Need to state direction and active state for all of these.

Re: [PATCH v3 1/7] max8903: adds documentation for device tree bindings.

[Rob Herring]

On Fri, Jun 17, 2016 at 03:00:20PM +1000, Chris Lapa wrote:
> From: Chris Lapa 
> 
> Signed-off-by: Chris Lapa 
> ---
>  .../devicetree/bindings/power/max8903-charger.txt  | 25 
> ++
>  1 file changed, 25 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/power/max8903-charger.txt
> 
> diff --git a/Documentation/devicetree/bindings/power/max8903-charger.txt 
> b/Documentation/devicetree/bindings/power/max8903-charger.txt
> new file mode 100644
> index 000..aea1dd2a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/max8903-charger.txt
> @@ -0,0 +1,25 @@
> +Maxim Semiconductor MAX8903 Battery Charger bindings
> +
> +Required properties:
> +- compatible: "maxim,max8903-charger" for MAX8903 Battery Charger

Drop "charger" as that is implied by the chip.

> +- dok-gpios: Valid DC power has been detected, optional if uok-gpios is 
> provided
> +- uok-gpios: Valid USB power has been detected, optional if dok-gpios is 
> provided
> +
> +Optional properties:
> +- cen-gpios: Charge enable pin
> +- chg-gpios: Charger status pin
> +- flt-gpios: Fault pin
> +- dcm-gpios: Current limit mode setting (DC or USB)
> +- usus-gpios: USB suspend pin

Need to state direction and active state for all of these.

Re: [PATCH v3 1/7] max8903: adds documentation for device tree bindings.

[Rob Herring]

On Fri, Jun 17, 2016 at 03:00:20PM +1000, Chris Lapa wrote:
> From: Chris Lapa 
> 
> Signed-off-by: Chris Lapa 
> ---
>  .../devicetree/bindings/power/max8903-charger.txt  | 25 
> ++
>  1 file changed, 25 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/power/max8903-charger.txt
> 
> diff --git a/Documentation/devicetree/bindings/power/max8903-charger.txt 
> b/Documentation/devicetree/bindings/power/max8903-charger.txt
> new file mode 100644
> index 000..aea1dd2a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/max8903-charger.txt
> @@ -0,0 +1,25 @@
> +Maxim Semiconductor MAX8903 Battery Charger bindings
> +
> +Required properties:
> +- compatible: "maxim,max8903-charger" for MAX8903 Battery Charger

Drop "charger" as that is implied by the chip.

> +- dok-gpios: Valid DC power has been detected, optional if uok-gpios is 
> provided
> +- uok-gpios: Valid USB power has been detected, optional if dok-gpios is 
> provided
> +
> +Optional properties:
> +- cen-gpios: Charge enable pin
> +- chg-gpios: Charger status pin
> +- flt-gpios: Fault pin
> +- dcm-gpios: Current limit mode setting (DC or USB)
> +- usus-gpios: USB suspend pin

Need to state direction and active state for all of these.

Re: [PATCH v3 1/7] max8903: adds documentation for device tree bindings.

[Krzysztof Kozlowski]

On 06/17/2016 07:00 AM, Chris Lapa wrote:
> From: Chris Lapa 
> 
> Signed-off-by: Chris Lapa 
> ---
>  .../devicetree/bindings/power/max8903-charger.txt  | 25 
> ++
>  1 file changed, 25 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/power/max8903-charger.txt

Reviewed-by: Krzysztof Kozlowski 

Best regards,
Krzysztof

Re: [PATCH v3 1/7] max8903: adds documentation for device tree bindings.

[Krzysztof Kozlowski]

On 06/17/2016 07:00 AM, Chris Lapa wrote:
> From: Chris Lapa 
> 
> Signed-off-by: Chris Lapa 
> ---
>  .../devicetree/bindings/power/max8903-charger.txt  | 25 
> ++
>  1 file changed, 25 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/power/max8903-charger.txt

Reviewed-by: Krzysztof Kozlowski 

Best regards,
Krzysztof

[PATCH v3 1/7] max8903: adds documentation for device tree bindings.

[Chris Lapa]

From: Chris Lapa 

Signed-off-by: Chris Lapa 
---
 .../devicetree/bindings/power/max8903-charger.txt  | 25 ++
 1 file changed, 25 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/max8903-charger.txt

diff --git a/Documentation/devicetree/bindings/power/max8903-charger.txt 
b/Documentation/devicetree/bindings/power/max8903-charger.txt
new file mode 100644
index 000..aea1dd2a
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/max8903-charger.txt
@@ -0,0 +1,25 @@
+Maxim Semiconductor MAX8903 Battery Charger bindings
+
+Required properties:
+- compatible: "maxim,max8903-charger" for MAX8903 Battery Charger
+- dok-gpios: Valid DC power has been detected, optional if uok-gpios is 
provided
+- uok-gpios: Valid USB power has been detected, optional if dok-gpios is 
provided
+
+Optional properties:
+- cen-gpios: Charge enable pin
+- chg-gpios: Charger status pin
+- flt-gpios: Fault pin
+- dcm-gpios: Current limit mode setting (DC or USB)
+- usus-gpios: USB suspend pin
+
+
+Example:
+
+   max8903-charger {
+   compatible = "maxim,max8903-charger";
+   dok-gpios = < 3 GPIO_ACTIVE_LOW>;
+   flt-gpios = < 2 GPIO_ACTIVE_LOW>;
+   chg-gpios = < 15 GPIO_ACTIVE_LOW>;
+   cen-gpios = < 5 GPIO_ACTIVE_LOW>;
+   status = "okay";
+   };
-- 
1.9.1

[PATCH v3 1/7] max8903: adds documentation for device tree bindings.

[Chris Lapa]

From: Chris Lapa 

Signed-off-by: Chris Lapa 
---
 .../devicetree/bindings/power/max8903-charger.txt  | 25 ++
 1 file changed, 25 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/max8903-charger.txt

diff --git a/Documentation/devicetree/bindings/power/max8903-charger.txt 
b/Documentation/devicetree/bindings/power/max8903-charger.txt
new file mode 100644
index 000..aea1dd2a
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/max8903-charger.txt
@@ -0,0 +1,25 @@
+Maxim Semiconductor MAX8903 Battery Charger bindings
+
+Required properties:
+- compatible: "maxim,max8903-charger" for MAX8903 Battery Charger
+- dok-gpios: Valid DC power has been detected, optional if uok-gpios is 
provided
+- uok-gpios: Valid USB power has been detected, optional if dok-gpios is 
provided
+
+Optional properties:
+- cen-gpios: Charge enable pin
+- chg-gpios: Charger status pin
+- flt-gpios: Fault pin
+- dcm-gpios: Current limit mode setting (DC or USB)
+- usus-gpios: USB suspend pin
+
+
+Example:
+
+   max8903-charger {
+   compatible = "maxim,max8903-charger";
+   dok-gpios = < 3 GPIO_ACTIVE_LOW>;
+   flt-gpios = < 2 GPIO_ACTIVE_LOW>;
+   chg-gpios = < 15 GPIO_ACTIVE_LOW>;
+   cen-gpios = < 5 GPIO_ACTIVE_LOW>;
+   status = "okay";
+   };
-- 
1.9.1