Re: [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver

2020-10-04 Thread Kuninori Morimoto
Hi Sameer > > This is just an idea, > > but can we use hooks here somehow ? > > > > .ops_hook_pre > > .ops_hook_func > > .ops_hook_post > > > > if (priv->ops_hook_pre->func) > > priv->ops_hook_pre->func_pre(...); > > > > if

Re: [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver

2020-10-02 Thread Sameer Pujar
Add Tegra audio machine driver which is based on generic audio graph card driver. It re-uses most of the common stuff from audio graph driver and uses the same DT binding. Required Tegra specific customizations are done in the driver. (snip) +static const struct snd_soc_ops

Re: [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver

2020-10-02 Thread Sameer Pujar
+/* Setup PLL clock as per the given sample rate */ +static int tegra_audio_graph_update_pll(struct snd_pcm_substream *substream, +struct snd_pcm_hw_params *params) +{ +struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream); +struct

Re: [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver

2020-10-01 Thread Kuninori Morimoto
Hi Sameer > Add Tegra audio machine driver which is based on generic audio graph card > driver. It re-uses most of the common stuff from audio graph driver and > uses the same DT binding. Required Tegra specific customizations are done > in the driver. (snip) > +static const struct snd_soc_ops

Re: [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver

2020-10-01 Thread Dmitry Osipenko
01.10.2020 23:57, Dmitry Osipenko пишет: > 01.10.2020 20:33, Sameer Pujar пишет: >> +/* Setup PLL clock as per the given sample rate */ >> +static int tegra_audio_graph_update_pll(struct snd_pcm_substream *substream, >> +struct snd_pcm_hw_params *params) >> +{

Re: [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver

2020-10-01 Thread Dmitry Osipenko
01.10.2020 20:33, Sameer Pujar пишет: > +/* Setup PLL clock as per the given sample rate */ > +static int tegra_audio_graph_update_pll(struct snd_pcm_substream *substream, > + struct snd_pcm_hw_params *params) > +{ > + struct snd_soc_pcm_runtime *rtd =

Re: [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver

2020-10-01 Thread Jon Hunter
On 01/10/2020 20:07, Michał Mirosław wrote: > On Thu, Oct 01, 2020 at 11:03:04PM +0530, Sameer Pujar wrote: >> Add Tegra audio machine driver which is based on generic audio graph card >> driver. It re-uses most of the common stuff from audio graph driver and >> uses the same DT binding.

Re: [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver

2020-10-01 Thread Michał Mirosław
On Thu, Oct 01, 2020 at 11:03:04PM +0530, Sameer Pujar wrote: > Add Tegra audio machine driver which is based on generic audio graph card > driver. It re-uses most of the common stuff from audio graph driver and > uses the same DT binding. Required Tegra specific customizations are done > in the

[PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver

2020-10-01 Thread Sameer Pujar
Add Tegra audio machine driver which is based on generic audio graph card driver. It re-uses most of the common stuff from audio graph driver and uses the same DT binding. Required Tegra specific customizations are done in the driver. Details on the customizations done: - Update PLL rates at