Re: [dm-devel] [PATCH v3 11/26] block: Add submit_bio_wait(), remove from md

2012-10-03 Thread Hannes Reinecke
On 10/02/2012 10:11 PM, Kent Overstreet wrote: On Tue, Oct 02, 2012 at 03:41:32PM -0400, Vivek Goyal wrote: On Mon, Sep 24, 2012 at 03:34:51PM -0700, Kent Overstreet wrote: Random cleanup - this code was duplicated and it's not really specific to md. Also added the ability to return the actual

Re: [dm-devel] [PATCH v3 11/26] block: Add submit_bio_wait(), remove from md

2012-10-02 Thread Kent Overstreet
On Tue, Oct 02, 2012 at 04:16:30PM -0400, Vivek Goyal wrote: > On Tue, Oct 02, 2012 at 01:11:05PM -0700, Kent Overstreet wrote: > > On Tue, Oct 02, 2012 at 03:41:32PM -0400, Vivek Goyal wrote: > > > On Mon, Sep 24, 2012 at 03:34:51PM -0700, Kent Overstreet wrote: > > > > Random cleanup - this code

Re: [dm-devel] [PATCH v3 11/26] block: Add submit_bio_wait(), remove from md

2012-10-02 Thread Vivek Goyal
On Tue, Oct 02, 2012 at 01:11:05PM -0700, Kent Overstreet wrote: > On Tue, Oct 02, 2012 at 03:41:32PM -0400, Vivek Goyal wrote: > > On Mon, Sep 24, 2012 at 03:34:51PM -0700, Kent Overstreet wrote: > > > Random cleanup - this code was duplicated and it's not really specific > > > to md. > > > > > >

Re: [dm-devel] [PATCH v3 11/26] block: Add submit_bio_wait(), remove from md

2012-10-02 Thread Kent Overstreet
On Tue, Oct 02, 2012 at 03:41:32PM -0400, Vivek Goyal wrote: > On Mon, Sep 24, 2012 at 03:34:51PM -0700, Kent Overstreet wrote: > > Random cleanup - this code was duplicated and it's not really specific > > to md. > > > > Also added the ability to return the actual error code. > > Who is going to

Re: [dm-devel] [PATCH v3 11/26] block: Add submit_bio_wait(), remove from md

2012-10-02 Thread Vivek Goyal
On Mon, Sep 24, 2012 at 03:34:51PM -0700, Kent Overstreet wrote: > Random cleanup - this code was duplicated and it's not really specific > to md. > > Also added the ability to return the actual error code. Who is going to make use of actual error code and why checking BIO_UPTODATE is not suffici

Re: [dm-devel] [PATCH v3 11/26] block: Add submit_bio_wait(), remove from md

2012-09-25 Thread Kent Overstreet
On Tue, Sep 25, 2012 at 07:51:07AM +0200, Hannes Reinecke wrote: > On 09/25/2012 12:34 AM, Kent Overstreet wrote: > > +/** > > + * submit_bio_wait - submit a bio, and wait until it completes > > + * @rw: whether to %READ or %WRITE, or maybe to %READA (read ahead) > > + * @bio: The &struct bio which

Re: [dm-devel] [PATCH v3 11/26] block: Add submit_bio_wait(), remove from md

2012-09-24 Thread Hannes Reinecke
On 09/25/2012 12:34 AM, Kent Overstreet wrote: > Random cleanup - this code was duplicated and it's not really specific > to md. > > Also added the ability to return the actual error code. > > Signed-off-by: Kent Overstreet > CC: Jens Axboe > CC: NeilBrown > Acked-by: Tejun Heo > --- > drive

[PATCH v3 11/26] block: Add submit_bio_wait(), remove from md

2012-09-24 Thread Kent Overstreet
Random cleanup - this code was duplicated and it's not really specific to md. Also added the ability to return the actual error code. Signed-off-by: Kent Overstreet CC: Jens Axboe CC: NeilBrown Acked-by: Tejun Heo --- drivers/md/raid1.c | 19 --- drivers/md/raid10.c | 19 ---