Re: [PATCH v3 14/15] drm/bochs: drop old fbdev emulation code

2019-01-10 Thread Noralf Trønnes
Den 10.01.2019 11.16, skrev Gerd Hoffmann: > Hi, > >>> - drm_fb_helper_set_suspend_unlocked(>fb.helper, 1); >> >> The generic fbdev emulation doesn't take care of suspend/resume. You >> could do this: >> drm_fb_helper_set_suspend_unlocked(drm_dev->fb_helper, 1); > > Additional to

Re: [PATCH v3 14/15] drm/bochs: drop old fbdev emulation code

2019-01-10 Thread Gerd Hoffmann
Hi, > > - drm_fb_helper_set_suspend_unlocked(>fb.helper, 1); > > The generic fbdev emulation doesn't take care of suspend/resume. You > could do this: > drm_fb_helper_set_suspend_unlocked(drm_dev->fb_helper, 1); Additional to drm_mode_config_helper_suspend() I assume? Does the call order

Re: [PATCH v3 14/15] drm/bochs: drop old fbdev emulation code

2019-01-10 Thread Noralf Trønnes
Den 10.01.2019 09.28, skrev Gerd Hoffmann: > Not needed any more, bochs uses the generic emulation now. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Oleksandr Andrushchenko > Acked-by: Daniel Vetter > --- > drivers/gpu/drm/bochs/bochs.h | 9 --- >

[PATCH v3 14/15] drm/bochs: drop old fbdev emulation code

2019-01-10 Thread Gerd Hoffmann
Not needed any more, bochs uses the generic emulation now. Signed-off-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko Acked-by: Daniel Vetter --- drivers/gpu/drm/bochs/bochs.h | 9 --- drivers/gpu/drm/bochs/bochs_drv.c | 6 -- drivers/gpu/drm/bochs/bochs_fbdev.c | 129