Re: [PATCH v3 14/17] PCI: dwc: artpec6: Add support for endpoint mode

2017-11-03 Thread Niklas Cassel
On 11/03/2017 11:23 AM, Arnd Bergmann wrote: > On Fri, Nov 3, 2017 at 10:56 AM, Niklas Cassel wrote: >> On 11/02/2017 10:13 AM, Arnd Bergmann wrote: > What I meant is that you can remove the #ifdef entirely if you add > > if

Re: [PATCH v3 14/17] PCI: dwc: artpec6: Add support for endpoint mode

2017-11-03 Thread Niklas Cassel
On 11/03/2017 11:23 AM, Arnd Bergmann wrote: > On Fri, Nov 3, 2017 at 10:56 AM, Niklas Cassel wrote: >> On 11/02/2017 10:13 AM, Arnd Bergmann wrote: > What I meant is that you can remove the #ifdef entirely if you add > > if (!IS_ENABLED(CONFIG_PCIE_ARTPEC6_HOST)) >

Re: [PATCH v3 14/17] PCI: dwc: artpec6: Add support for endpoint mode

2017-11-03 Thread Arnd Bergmann
On Fri, Nov 3, 2017 at 10:56 AM, Niklas Cassel wrote: > On 11/02/2017 10:13 AM, Arnd Bergmann wrote: >> >> >> Can you try replacing the #ifdef with >> >> >> if (!IS_ENABLED(CONFIG_PCIE_ARTPEC6_HOST)) >> return -ENODEV; >> >> at the start of

Re: [PATCH v3 14/17] PCI: dwc: artpec6: Add support for endpoint mode

2017-11-03 Thread Arnd Bergmann
On Fri, Nov 3, 2017 at 10:56 AM, Niklas Cassel wrote: > On 11/02/2017 10:13 AM, Arnd Bergmann wrote: >> >> >> Can you try replacing the #ifdef with >> >> >> if (!IS_ENABLED(CONFIG_PCIE_ARTPEC6_HOST)) >> return -ENODEV; >> >> at the start of

Re: [PATCH v3 14/17] PCI: dwc: artpec6: Add support for endpoint mode

2017-11-03 Thread Niklas Cassel
On 11/02/2017 10:13 AM, Arnd Bergmann wrote: > On Tue, Oct 31, 2017 at 11:39 PM, Niklas Cassel > wrote: >> Signed-off-by: Niklas Cassel > > It seems like you are missing a changelog text. Please explain what > your work is good for > in any patch

Re: [PATCH v3 14/17] PCI: dwc: artpec6: Add support for endpoint mode

2017-11-03 Thread Niklas Cassel
On 11/02/2017 10:13 AM, Arnd Bergmann wrote: > On Tue, Oct 31, 2017 at 11:39 PM, Niklas Cassel > wrote: >> Signed-off-by: Niklas Cassel > > It seems like you are missing a changelog text. Please explain what > your work is good for > in any patch you send. You are correct, this patch is

Re: [PATCH v3 14/17] PCI: dwc: artpec6: Add support for endpoint mode

2017-11-02 Thread Arnd Bergmann
On Tue, Oct 31, 2017 at 11:39 PM, Niklas Cassel wrote: > Signed-off-by: Niklas Cassel It seems like you are missing a changelog text. Please explain what your work is good for in any patch you send. > V3: > * Removed ifdefs around match table and

Re: [PATCH v3 14/17] PCI: dwc: artpec6: Add support for endpoint mode

2017-11-02 Thread Arnd Bergmann
On Tue, Oct 31, 2017 at 11:39 PM, Niklas Cassel wrote: > Signed-off-by: Niklas Cassel It seems like you are missing a changelog text. Please explain what your work is good for in any patch you send. > V3: > * Removed ifdefs around match table and match table data. > * Removed ifdefs in probe,

[PATCH v3 14/17] PCI: dwc: artpec6: Add support for endpoint mode

2017-10-31 Thread Niklas Cassel
Signed-off-by: Niklas Cassel --- V3: * Removed ifdefs around match table and match table data. * Removed ifdefs in probe, use dummy implementations instead. drivers/pci/dwc/Kconfig| 23 -- drivers/pci/dwc/pcie-artpec6.c | 162

[PATCH v3 14/17] PCI: dwc: artpec6: Add support for endpoint mode

2017-10-31 Thread Niklas Cassel
Signed-off-by: Niklas Cassel --- V3: * Removed ifdefs around match table and match table data. * Removed ifdefs in probe, use dummy implementations instead. drivers/pci/dwc/Kconfig| 23 -- drivers/pci/dwc/pcie-artpec6.c | 162 +++-- 2 files