On Thu, Jun 25, 2015 at 02:27:02PM -0700, Juston Li wrote:
> On Thu, Jun 25, 2015 at 1:31 PM, Dan Carpenter
> wrote:
> Patchset was responded by Greg's patch bot, I'll resend when I figure out
> why.
Greg will not apply any patch since the merge window is open. That
patchbot will respond when
On Thu, Jun 25, 2015 at 1:31 PM, Dan Carpenter wrote:
> Once you add the else statement, then that kind of doesn't make sense.
> Sudip is right. It should be:
>
> } else {
> /* commentary about else side */
Yeah, that does make more sense. I'll change it, thanks.
On Thu, Jun 25, 2015 at 08:49:30AM -0700, Juston Li wrote:
> I placed it above the else to make it consistent with the if statement with
> similar comment that the else corresponds to:
>
> /* Set the primary display control */
> - if (!ctrl)+ if (!ctrl) {
Once you add the else statement, then
On Thu, Jun 25, 2015 at 5:17 AM, Sudip Mukherjee
wrote:
> On Wed, Jun 24, 2015 at 09:25:17AM -0700, Juston Li wrote:
>> Fix brace placement errors caught by checkpatch.pl
>> ERROR: that open brace { should be on the previous line
>>
>> Signed-off-by: Juston Li
>> ---
>
>> @@ -71,14 +66,11 @@
On Wed, Jun 24, 2015 at 09:25:17AM -0700, Juston Li wrote:
> Fix brace placement errors caught by checkpatch.pl
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Juston Li
> ---
> @@ -71,14 +66,11 @@ static void setDisplayControl(int ctrl, int dispState)
>
On Thu, Jun 25, 2015 at 08:49:30AM -0700, Juston Li wrote:
I placed it above the else to make it consistent with the if statement with
similar comment that the else corresponds to:
/* Set the primary display control */
- if (!ctrl)+ if (!ctrl) {
Once you add the else statement, then that
On Wed, Jun 24, 2015 at 09:25:17AM -0700, Juston Li wrote:
Fix brace placement errors caught by checkpatch.pl
ERROR: that open brace { should be on the previous line
Signed-off-by: Juston Li juston.h...@gmail.com
---
snip
@@ -71,14 +66,11 @@ static void setDisplayControl(int ctrl, int
On Thu, Jun 25, 2015 at 1:31 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
Once you add the else statement, then that kind of doesn't make sense.
Sudip is right. It should be:
} else {
/* commentary about else side */
Yeah, that does make more sense. I'll change
On Thu, Jun 25, 2015 at 5:17 AM, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
On Wed, Jun 24, 2015 at 09:25:17AM -0700, Juston Li wrote:
Fix brace placement errors caught by checkpatch.pl
ERROR: that open brace { should be on the previous line
Signed-off-by: Juston Li
On Thu, Jun 25, 2015 at 02:27:02PM -0700, Juston Li wrote:
On Thu, Jun 25, 2015 at 1:31 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
Patchset was responded by Greg's patch bot, I'll resend when I figure out
why.
Greg will not apply any patch since the merge window is open. That
Fix brace placement errors caught by checkpatch.pl
ERROR: that open brace { should be on the previous line
Signed-off-by: Juston Li
---
drivers/staging/sm750fb/ddk750_chip.h| 12 +++
drivers/staging/sm750fb/ddk750_display.c | 54 ++--
Fix brace placement errors caught by checkpatch.pl
ERROR: that open brace { should be on the previous line
Signed-off-by: Juston Li juston.h...@gmail.com
---
drivers/staging/sm750fb/ddk750_chip.h| 12 +++
drivers/staging/sm750fb/ddk750_display.c | 54 ++--
12 matches
Mail list logo
