Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-22 Thread Taras Kondratiuk
Quoting Rob Landley (2019-05-22 12:26:43) > > > On 5/22/19 11:17 AM, h...@zytor.com wrote: > > On May 20, 2019 2:39:46 AM PDT, Roberto Sassu > > wrote: > >> On 5/18/2019 12:17 AM, Arvind Sankar wrote: > >>> On Fri, May 17, 2019 at 02:47:31PM -0700, H. Peter Anvin wrote: > On 5/17/19 2:02

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-22 Thread Rob Landley
On 5/22/19 11:17 AM, h...@zytor.com wrote: > On May 20, 2019 2:39:46 AM PDT, Roberto Sassu > wrote: >> On 5/18/2019 12:17 AM, Arvind Sankar wrote: >>> On Fri, May 17, 2019 at 02:47:31PM -0700, H. Peter Anvin wrote: On 5/17/19 2:02 PM, Arvind Sankar wrote: > On Fri, May 17, 2019 at

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-22 Thread Roberto Sassu
On 5/22/2019 6:17 PM, h...@zytor.com wrote: On May 20, 2019 2:39:46 AM PDT, Roberto Sassu wrote: On 5/18/2019 12:17 AM, Arvind Sankar wrote: On Fri, May 17, 2019 at 02:47:31PM -0700, H. Peter Anvin wrote: On 5/17/19 2:02 PM, Arvind Sankar wrote: On Fri, May 17, 2019 at 01:18:11PM -0700,

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-22 Thread hpa
On May 17, 2019 7:16:04 PM PDT, Rob Landley wrote: >On 5/17/19 4:41 PM, H. Peter Anvin wrote: >> On 5/17/19 1:18 PM, h...@zytor.com wrote: >>> >>> Ok... I just realized this does not work for a modular initramfs, >composed at load time from multiple files, which is a very real >problem. Should be

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-22 Thread hpa
On May 20, 2019 2:39:46 AM PDT, Roberto Sassu wrote: >On 5/18/2019 12:17 AM, Arvind Sankar wrote: >> On Fri, May 17, 2019 at 02:47:31PM -0700, H. Peter Anvin wrote: >>> On 5/17/19 2:02 PM, Arvind Sankar wrote: On Fri, May 17, 2019 at 01:18:11PM -0700, h...@zytor.com wrote: > > Ok...

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-20 Thread Roberto Sassu
On 5/18/2019 12:17 AM, Arvind Sankar wrote: On Fri, May 17, 2019 at 02:47:31PM -0700, H. Peter Anvin wrote: On 5/17/19 2:02 PM, Arvind Sankar wrote: On Fri, May 17, 2019 at 01:18:11PM -0700, h...@zytor.com wrote: Ok... I just realized this does not work for a modular initramfs, composed at

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-20 Thread Roberto Sassu
On 5/17/2019 10:18 PM, h...@zytor.com wrote: On May 17, 2019 9:55:19 AM PDT, Roberto Sassu wrote: This patch adds support for an alternative method to add xattrs to files in the rootfs filesystem. Instead of extracting them directly from the ram disk image, they are extracted from a regular

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-20 Thread Roberto Sassu
On 5/17/2019 11:10 PM, Arvind Sankar wrote: On Fri, May 17, 2019 at 05:02:20PM -0400, Arvind Sankar wrote: On Fri, May 17, 2019 at 01:18:11PM -0700, h...@zytor.com wrote: Ok... I just realized this does not work for a modular initramfs, composed at load time from multiple files, which is a

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-17 Thread kbuild test robot
Hi Roberto, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.1 next-20190517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-17 Thread Rob Landley
On 5/17/19 4:41 PM, H. Peter Anvin wrote: > On 5/17/19 1:18 PM, h...@zytor.com wrote: >> >> Ok... I just realized this does not work for a modular initramfs, composed >> at load time from multiple files, which is a very real problem. Should be >> easy enough to deal with: instead of one large

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-17 Thread kbuild test robot
Hi Roberto, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.1 next-20190517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-17 Thread kbuild test robot
Hi Roberto, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.1 next-20190517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-17 Thread Arvind Sankar
On Fri, May 17, 2019 at 02:47:31PM -0700, H. Peter Anvin wrote: > On 5/17/19 2:02 PM, Arvind Sankar wrote: > > On Fri, May 17, 2019 at 01:18:11PM -0700, h...@zytor.com wrote: > >> > >> Ok... I just realized this does not work for a modular initramfs, composed > >> at load time from multiple

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-17 Thread H. Peter Anvin
On 5/17/19 2:02 PM, Arvind Sankar wrote: > On Fri, May 17, 2019 at 01:18:11PM -0700, h...@zytor.com wrote: >> >> Ok... I just realized this does not work for a modular initramfs, composed >> at load time from multiple files, which is a very real problem. Should be >> easy enough to deal with:

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-17 Thread H. Peter Anvin
On 5/17/19 1:18 PM, h...@zytor.com wrote: > > Ok... I just realized this does not work for a modular initramfs, composed at > load time from multiple files, which is a very real problem. Should be easy > enough to deal with: instead of one large file, use one companion file per > source file,

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-17 Thread Rob Landley
On 5/17/19 3:18 PM, h...@zytor.com wrote: > Ok... I just realized this does not work for a modular initramfs, composed at > load time from multiple files, which is a very real problem. Should be easy > enough to deal with: instead of one large file, use one companion file per > source file,

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-17 Thread Arvind Sankar
On Fri, May 17, 2019 at 05:02:20PM -0400, Arvind Sankar wrote: > On Fri, May 17, 2019 at 01:18:11PM -0700, h...@zytor.com wrote: > > > > Ok... I just realized this does not work for a modular initramfs, composed > > at load time from multiple files, which is a very real problem. Should be > >

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-17 Thread Arvind Sankar
On Fri, May 17, 2019 at 01:18:11PM -0700, h...@zytor.com wrote: > > Ok... I just realized this does not work for a modular initramfs, composed at > load time from multiple files, which is a very real problem. Should be easy > enough to deal with: instead of one large file, use one companion

Re: [PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-17 Thread hpa
On May 17, 2019 9:55:19 AM PDT, Roberto Sassu wrote: >This patch adds support for an alternative method to add xattrs to >files in >the rootfs filesystem. Instead of extracting them directly from the ram >disk image, they are extracted from a regular file called .xattr-list, >that >can be added

[PATCH v3 2/2] initramfs: introduce do_readxattrs()

2019-05-17 Thread Roberto Sassu
This patch adds support for an alternative method to add xattrs to files in the rootfs filesystem. Instead of extracting them directly from the ram disk image, they are extracted from a regular file called .xattr-list, that can be added by any ram disk generator available today. The file format