Re: [PATCH v3 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support

2021-04-11 Thread Nobuhiro Iwamatsu
Hi, On Sat, Apr 10, 2021 at 03:56:58PM +0200, Uwe Kleine-König wrote: > Hello, > > On Sat, Apr 10, 2021 at 06:34:55AM +0900, Nobuhiro Iwamatsu wrote: > > > > +static int visconti_pwm_remove(struct platform_device *pdev) > > > > +{ > > > > + struct visconti_pwm_chip *priv =

Re: [PATCH v3 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support

2021-04-10 Thread Uwe Kleine-König
Hello, On Sat, Apr 10, 2021 at 06:34:55AM +0900, Nobuhiro Iwamatsu wrote: > > > +static int visconti_pwm_remove(struct platform_device *pdev) > > > +{ > > > + struct visconti_pwm_chip *priv = platform_get_drvdata(pdev); > > > + > > > + return pwmchip_remove(>chip); > > > > I think Uwe would

Re: [PATCH v3 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support

2021-04-09 Thread Nobuhiro Iwamatsu
Hi Thierry, Thanks for your review. On Fri, Apr 09, 2021 at 03:20:12PM +0200, Thierry Reding wrote: > On Fri, Apr 09, 2021 at 06:07:09PM +0900, Nobuhiro Iwamatsu wrote: > > Add driver for the PWM controller on Toshiba Visconti ARM SoC. > > > > Signed-off-by: Nobuhiro Iwamatsu > > --- > >

Re: [PATCH v3 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support

2021-04-09 Thread Thierry Reding
On Fri, Apr 09, 2021 at 06:07:09PM +0900, Nobuhiro Iwamatsu wrote: > Add driver for the PWM controller on Toshiba Visconti ARM SoC. > > Signed-off-by: Nobuhiro Iwamatsu > --- > drivers/pwm/Kconfig| 9 ++ > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-visconti.c | 193

[PATCH v3 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support

2021-04-09 Thread Nobuhiro Iwamatsu
Add driver for the PWM controller on Toshiba Visconti ARM SoC. Signed-off-by: Nobuhiro Iwamatsu --- drivers/pwm/Kconfig| 9 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-visconti.c | 193 + 3 files changed, 203 insertions(+) create mode