Re: [PATCH v3 2/3] dt-bindings: power: rockchip: Convert to json-schema and extend
On 3/24/21 4:23 AM, Elaine Zhang wrote:
> Convert the soc/rockchip/power_domain.txt binding document to
> json-schema and move to the power bindings directory.
> Add RK3568 SoCs for rockchip power binding document.
>
> Signed-off-by: Enric Balletbo i Serra
> Signed-off-by: Elaine Zhang
> ---
> .../power/rockchip,power-controller.yaml | 286 ++
> .../bindings/soc/rockchip/power_domain.txt| 136 -
> 2 files changed, 286 insertions(+), 136 deletions(-)
> create mode 100644
> Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> delete mode 100644
> Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
>
> diff --git
> a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> new file mode 100644
> index ..0d6b8962d098
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> @@ -0,0 +1,286 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/rockchip,power-controller.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip Power Domains
> +
> +maintainers:
> + - Elaine Zhang
> + - Rob Herring
> + - Heiko Stuebner
> +
> +description: |
> + Rockchip processors include support for multiple power domains which can be
> + powered up/down by software based on different application scenes to save
> power.
scenes > scenarios ??
This is not a theater.
=
Scenes:
1. Something seen by a viewer; a view or prospect.
2. The place where an action or event occurs: the scene of the crime.
=
Scenarios:
1. An expected or supposed situation or sequence of events
> +
> + Power domains contained within power-controller node are generic power
> domain
> + providers documented in
> Documentation/devicetree/bindings/power/power-domain.yaml.
> +
> + IP cores belonging to a power domain should contain a 'power-domains'
> + property that is a phandle for the power domain node representing the
> domain.
> +
> +properties:
> + $nodename:
> +const: power-controller
> +
> + compatible:
> +enum:
> + - rockchip,px30-power-controller
> + - rockchip,rk3036-power-controller
> + - rockchip,rk3066-power-controller
> + - rockchip,rk3128-power-controller
> + - rockchip,rk3188-power-controller
> + - rockchip,rk3228-power-controller
> + - rockchip,rk3288-power-controller
> + - rockchip,rk3328-power-controller
> + - rockchip,rk3366-power-controller
> + - rockchip,rk3368-power-controller
> + - rockchip,rk3399-power-controller
> + - rockchip,rk3568-power-controller
Use separate patches for a YAML conversion and adding new compatibility
strings. One action per patch.
> +
> + '#power-domain-cells':
> +const: 1
> +
> + '#address-cells':
> +const: 1
> +
> + '#size-cells':
> +const: 0
> +
> +patternProperties:
> + "^pd_[0-9a-z_]{2,10}@[0-9a-f]+$":
Here you are using "", but elsewhere in this document '' is used.
Change all to "".
> +type: object
> +description: |
> + Represents the power domains within the power controller node as
> documented
> + in Documentation/devicetree/bindings/power/power-domain.yaml.
> +
> +properties:
> +
> + '#power-domain-cells':
> +description:
> + Must be 0 for nodes representing a single PM domain and 1 for nodes
> + providing multiple PM domains.
> +
> + '#address-cells':
> +const: 1
> +
> + '#size-cells':
> +const: 0
> +
> + reg:
> +maxItems: 1
> +description: |
> + Power domain index. Valid values are defined in:
remove ":"
> + "include/dt-bindings/power/px30-power.h"
> + "include/dt-bindings/power/rk3036-power.h"
> + "include/dt-bindings/power/rk3066-power.h"
> + "include/dt-bindings/power/rk3128-power.h"
> + "include/dt-bindings/power/rk3188-power.h"
> + "include/dt-bindings/power/rk3228-power.h"
> + "include/dt-bindings/power/rk3288-power.h"
> + "include/dt-bindings/power/rk3328-power.h"
> + "include/dt-bindings/power/rk3366-power.h"
> + "include/dt-bindings/power/rk3368-power.h"
> + "include/dt-bindings/power/rk3399-power.h"
> + "include/dt-bindings/power/rk3399-power.h"
rk3399 > rk3568
"include/dt-bindings/power/rk3568-power.h"
Use separate patches for a YAML conversion and adding new compatibility
strings. One action per patch.
> +
> + clocks:
> +description: |
> + A number of phandles to clocks that need to be enabled while power
> domain
> + switches state.
> +
> + pm_qos:
> +description: |
> + A number of phandles to qos blocks which need to be saved and
> restored
> + while power domain switches state.
> +
>
[PATCH v3 2/3] dt-bindings: power: rockchip: Convert to json-schema and extend
Convert the soc/rockchip/power_domain.txt binding document to
json-schema and move to the power bindings directory.
Add RK3568 SoCs for rockchip power binding document.
Signed-off-by: Enric Balletbo i Serra
Signed-off-by: Elaine Zhang
---
.../power/rockchip,power-controller.yaml | 286 ++
.../bindings/soc/rockchip/power_domain.txt| 136 -
2 files changed, 286 insertions(+), 136 deletions(-)
create mode 100644
Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
delete mode 100644
Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
diff --git
a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
new file mode 100644
index ..0d6b8962d098
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
@@ -0,0 +1,286 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/rockchip,power-controller.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Rockchip Power Domains
+
+maintainers:
+ - Elaine Zhang
+ - Rob Herring
+ - Heiko Stuebner
+
+description: |
+ Rockchip processors include support for multiple power domains which can be
+ powered up/down by software based on different application scenes to save
power.
+
+ Power domains contained within power-controller node are generic power domain
+ providers documented in
Documentation/devicetree/bindings/power/power-domain.yaml.
+
+ IP cores belonging to a power domain should contain a 'power-domains'
+ property that is a phandle for the power domain node representing the domain.
+
+properties:
+ $nodename:
+const: power-controller
+
+ compatible:
+enum:
+ - rockchip,px30-power-controller
+ - rockchip,rk3036-power-controller
+ - rockchip,rk3066-power-controller
+ - rockchip,rk3128-power-controller
+ - rockchip,rk3188-power-controller
+ - rockchip,rk3228-power-controller
+ - rockchip,rk3288-power-controller
+ - rockchip,rk3328-power-controller
+ - rockchip,rk3366-power-controller
+ - rockchip,rk3368-power-controller
+ - rockchip,rk3399-power-controller
+ - rockchip,rk3568-power-controller
+
+ '#power-domain-cells':
+const: 1
+
+ '#address-cells':
+const: 1
+
+ '#size-cells':
+const: 0
+
+patternProperties:
+ "^pd_[0-9a-z_]{2,10}@[0-9a-f]+$":
+type: object
+description: |
+ Represents the power domains within the power controller node as
documented
+ in Documentation/devicetree/bindings/power/power-domain.yaml.
+
+properties:
+
+ '#power-domain-cells':
+description:
+ Must be 0 for nodes representing a single PM domain and 1 for nodes
+ providing multiple PM domains.
+
+ '#address-cells':
+const: 1
+
+ '#size-cells':
+const: 0
+
+ reg:
+maxItems: 1
+description: |
+ Power domain index. Valid values are defined in:
+ "include/dt-bindings/power/px30-power.h"
+ "include/dt-bindings/power/rk3036-power.h"
+ "include/dt-bindings/power/rk3066-power.h"
+ "include/dt-bindings/power/rk3128-power.h"
+ "include/dt-bindings/power/rk3188-power.h"
+ "include/dt-bindings/power/rk3228-power.h"
+ "include/dt-bindings/power/rk3288-power.h"
+ "include/dt-bindings/power/rk3328-power.h"
+ "include/dt-bindings/power/rk3366-power.h"
+ "include/dt-bindings/power/rk3368-power.h"
+ "include/dt-bindings/power/rk3399-power.h"
+ "include/dt-bindings/power/rk3399-power.h"
+
+ clocks:
+description: |
+ A number of phandles to clocks that need to be enabled while power
domain
+ switches state.
+
+ pm_qos:
+description: |
+ A number of phandles to qos blocks which need to be saved and
restored
+ while power domain switches state.
+
+patternProperties:
+ "^pd_[0-9a-z_]{2,10}@[0-9a-f]+$":
+type: object
+description: |
+ Represents a power domain child within a power domain parent node.
+
+properties:
+
+ '#power-domain-cells':
+description:
+ Must be 0 for nodes representing a single PM domain and 1 for
nodes
+ providing multiple PM domains.
+
+ '#address-cells':
+const: 1
+
+ '#size-cells':
+const: 0
+
+ reg:
+maxItems: 1
+
+ clocks:
+description: |
+ A number of phandles to clocks that need to be enabled while
power domain
+ switches state.
+
+ pm_qos:
+description: |
+ A number of phandles to qos blocks which need to be saved and
restored
+ while power domain switches state.
+
+patternProperties:
+
