Re: [PATCH v3 2/3] regulator: add support for SY8106A regulator

On Wed, Apr 25, 2018 at 06:55:10PM +0800, Icenowy Zheng wrote: > 于 2018年4月25日 GMT+08:00 下午6:53:09, Mark Brown 写到: > >> SPDX identifier is special -- it should be in a seperated > >> comment block. > >No, it just needs to be a C++ comment on the first line to ease machine >

Re: [PATCH v3 2/3] regulator: add support for SY8106A regulator

On Wed, Apr 25, 2018 at 06:55:10PM +0800, Icenowy Zheng wrote: > 于 2018年4月25日 GMT+08:00 下午6:53:09, Mark Brown 写到: > >> SPDX identifier is special -- it should be in a seperated > >> comment block. > >No, it just needs to be a C++ comment on the first line to ease machine > >parsing. The rest

Re: [PATCH v3 2/3] regulator: add support for SY8106A regulator

于 2018年4月25日 GMT+08:00 下午6:53:09, Mark Brown 写到: >On Wed, Apr 25, 2018 at 07:41:35AM +0800, Icenowy Zheng wrote: >> 于 2018年4月25日 GMT+08:00 上午1:07:33, Mark Brown 写到: >> >On Mon, Apr 23, 2018 at 10:46:56PM +0800, Icenowy Zheng wrote: > >> >> --- /dev/null

Re: [PATCH v3 2/3] regulator: add support for SY8106A regulator

于 2018年4月25日 GMT+08:00 下午6:53:09, Mark Brown 写到: >On Wed, Apr 25, 2018 at 07:41:35AM +0800, Icenowy Zheng wrote: >> 于 2018年4月25日 GMT+08:00 上午1:07:33, Mark Brown 写到: >> >On Mon, Apr 23, 2018 at 10:46:56PM +0800, Icenowy Zheng wrote: > >> >> --- /dev/null >> >> +++

Re: [PATCH v3 2/3] regulator: add support for SY8106A regulator

On Wed, Apr 25, 2018 at 07:41:35AM +0800, Icenowy Zheng wrote: > 于 2018年4月25日 GMT+08:00 上午1:07:33, Mark Brown 写到: > >On Mon, Apr 23, 2018 at 10:46:56PM +0800, Icenowy Zheng wrote: > >> --- /dev/null > >> +++ b/drivers/regulator/sy8106a-regulator.c > >> @@ -0,0 +1,176 @@ > >>

Re: [PATCH v3 2/3] regulator: add support for SY8106A regulator

On Wed, Apr 25, 2018 at 07:41:35AM +0800, Icenowy Zheng wrote: > 于 2018年4月25日 GMT+08:00 上午1:07:33, Mark Brown 写到: > >On Mon, Apr 23, 2018 at 10:46:56PM +0800, Icenowy Zheng wrote: > >> --- /dev/null > >> +++ b/drivers/regulator/sy8106a-regulator.c > >> @@ -0,0 +1,176 @@ > >> +//

Re: [PATCH v3 2/3] regulator: add support for SY8106A regulator

于 2018年4月25日 GMT+08:00 上午1:07:33, Mark Brown 写到: >On Mon, Apr 23, 2018 at 10:46:56PM +0800, Icenowy Zheng wrote: > >> --- /dev/null >> +++ b/drivers/regulator/sy8106a-regulator.c >> @@ -0,0 +1,176 @@ >> +// SPDX-License-Identifier: GPL-2.0+ >> +/* >> + * sy8106a-regulator.c

Re: [PATCH v3 2/3] regulator: add support for SY8106A regulator

于 2018年4月25日 GMT+08:00 上午1:07:33, Mark Brown 写到: >On Mon, Apr 23, 2018 at 10:46:56PM +0800, Icenowy Zheng wrote: > >> --- /dev/null >> +++ b/drivers/regulator/sy8106a-regulator.c >> @@ -0,0 +1,176 @@ >> +// SPDX-License-Identifier: GPL-2.0+ >> +/* >> + * sy8106a-regulator.c - Regulator device

Re: [PATCH v3 2/3] regulator: add support for SY8106A regulator

On Mon, Apr 23, 2018 at 10:46:56PM +0800, Icenowy Zheng wrote: > --- /dev/null > +++ b/drivers/regulator/sy8106a-regulator.c > @@ -0,0 +1,176 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * sy8106a-regulator.c - Regulator device driver for SY8106A Just make the entire thing a C++ comment

Re: [PATCH v3 2/3] regulator: add support for SY8106A regulator

On Mon, Apr 23, 2018 at 10:46:56PM +0800, Icenowy Zheng wrote: > --- /dev/null > +++ b/drivers/regulator/sy8106a-regulator.c > @@ -0,0 +1,176 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * sy8106a-regulator.c - Regulator device driver for SY8106A Just make the entire thing a C++ comment

[PATCH v3 2/3] regulator: add support for SY8106A regulator

From: Ondrej Jirman SY8106A is an I2C attached single output regulator made by Silergy Corp, which is used on several Allwinner H3/H5 SBCs to control the power supply of the ARM cores. Add a driver for it. Signed-off-by: Ondrej Jirman [Icenowy: Change

[PATCH v3 2/3] regulator: add support for SY8106A regulator

From: Ondrej Jirman SY8106A is an I2C attached single output regulator made by Silergy Corp, which is used on several Allwinner H3/H5 SBCs to control the power supply of the ARM cores. Add a driver for it. Signed-off-by: Ondrej Jirman [Icenowy: Change commit message, remove enable/disable