Re: [PATCH v3 2/4] Refactor FPU codes in signal setup/return procedures

2018-08-03 Thread kbuild test robot
Hi Alan, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.18-rc7 next-20180802] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3 2/4] Refactor FPU codes in signal setup/return procedures

2018-08-03 Thread kbuild test robot
Hi Alan, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.18-rc7 next-20180802] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3 2/4] Refactor FPU codes in signal setup/return procedures

2018-08-02 Thread Christoph Hellwig
s/codes/code/ in the subject. Also a little explanation of why you refactor it in the patch description would be helpful. > +static long restore_fp_state(struct pt_regs *regs, > + union __riscv_fp_state *sc_fpregs) Please add another tab for the indentation here even if the original code

Re: [PATCH v3 2/4] Refactor FPU codes in signal setup/return procedures

2018-08-02 Thread Christoph Hellwig
s/codes/code/ in the subject. Also a little explanation of why you refactor it in the patch description would be helpful. > +static long restore_fp_state(struct pt_regs *regs, > + union __riscv_fp_state *sc_fpregs) Please add another tab for the indentation here even if the original code

[PATCH v3 2/4] Refactor FPU codes in signal setup/return procedures

2018-08-01 Thread Alan Kao
Signed-off-by: Alan Kao Cc: Greentime Hu Cc: Vincent Chen Cc: Zong Li Cc: Nick Hu --- arch/riscv/kernel/signal.c | 68 +++--- 1 file changed, 41 insertions(+), 27 deletions(-) diff --git a/arch/riscv/kernel/signal.c b/arch/riscv/kernel/signal.c index

[PATCH v3 2/4] Refactor FPU codes in signal setup/return procedures

2018-08-01 Thread Alan Kao
Signed-off-by: Alan Kao Cc: Greentime Hu Cc: Vincent Chen Cc: Zong Li Cc: Nick Hu --- arch/riscv/kernel/signal.c | 68 +++--- 1 file changed, 41 insertions(+), 27 deletions(-) diff --git a/arch/riscv/kernel/signal.c b/arch/riscv/kernel/signal.c index