Re: [PATCH v3 2/4] dmaengine: add driver for Samsung s3c24xx SoCs

2013-09-02 Thread Vinod Koul
On Wed, Aug 28, 2013 at 12:13:51AM +0200, Heiko Stübner wrote: > This adds a new driver to support the s3c24xx dma using the dmaengine > and makes the old one in mach-s3c24xx obsolete in the long run. > > Conceptually the s3c24xx-dma feels like a distant relative of the pl08x > with numerous

Re: [PATCH v3 2/4] dmaengine: add driver for Samsung s3c24xx SoCs

2013-09-02 Thread Vinod Koul
On Wed, Aug 28, 2013 at 12:13:51AM +0200, Heiko Stübner wrote: This adds a new driver to support the s3c24xx dma using the dmaengine and makes the old one in mach-s3c24xx obsolete in the long run. Conceptually the s3c24xx-dma feels like a distant relative of the pl08x with numerous virtual

Re: [PATCH v3 2/4] dmaengine: add driver for Samsung s3c24xx SoCs

2013-08-29 Thread Tomasz Figa
Hi Heiko, First of all, big thanks for you work on this, letting our dream about getting rid of S3C DMA API get closer to the reality. ;) Overall the driver looks very good, but let me share some comments inline. On Wednesday 28 of August 2013 00:13:51 Heiko Stübner wrote: > This adds a new

Re: [PATCH v3 2/4] dmaengine: add driver for Samsung s3c24xx SoCs

2013-08-29 Thread Tomasz Figa
Hi Heiko, First of all, big thanks for you work on this, letting our dream about getting rid of S3C DMA API get closer to the reality. ;) Overall the driver looks very good, but let me share some comments inline. On Wednesday 28 of August 2013 00:13:51 Heiko Stübner wrote: This adds a new

[PATCH v3 2/4] dmaengine: add driver for Samsung s3c24xx SoCs

2013-08-27 Thread Heiko Stübner
This adds a new driver to support the s3c24xx dma using the dmaengine and makes the old one in mach-s3c24xx obsolete in the long run. Conceptually the s3c24xx-dma feels like a distant relative of the pl08x with numerous virtual channels being mapped to a lot less physical ones. The driver

[PATCH v3 2/4] dmaengine: add driver for Samsung s3c24xx SoCs

2013-08-27 Thread Heiko Stübner
This adds a new driver to support the s3c24xx dma using the dmaengine and makes the old one in mach-s3c24xx obsolete in the long run. Conceptually the s3c24xx-dma feels like a distant relative of the pl08x with numerous virtual channels being mapped to a lot less physical ones. The driver