Re: [PATCH v3 2/6] Add the main bulk of core driver for SI476x code

2012-11-16 Thread Hans Verkuil
Hi Andrey, I'm really sorry for the long delay, but I finally have time to review v4 of this code. On Tue October 23 2012 20:44:28 Andrey Smirnov wrote: > This patch adds main part(out of three) of the I2C driver for the > "core" of MFD device. > > Signed-off-by: Andrey Smirnov > --- > driver

Re: [PATCH v3 2/6] Add the main bulk of core driver for SI476x code

2012-10-27 Thread Andrey Smirnov
On 10/27/2012 02:31 PM, Mark Brown wrote: > On Thu, Oct 25, 2012 at 03:26:02PM -0700, Andrey Smirnov wrote: >> On 10/25/2012 12:45 PM, Mark Brown wrote: >>> This really makes little sense to me, why are you doing this? Does the >>> device *really* layer a byte stream on top of I2C for sending mess

Re: [PATCH v3 2/6] Add the main bulk of core driver for SI476x code

2012-10-27 Thread Mark Brown
On Thu, Oct 25, 2012 at 03:26:02PM -0700, Andrey Smirnov wrote: > On 10/25/2012 12:45 PM, Mark Brown wrote: > > This really makes little sense to me, why are you doing this? Does the > > device *really* layer a byte stream on top of I2C for sending messages > > that look like marshalled register

Re: [PATCH v3 2/6] Add the main bulk of core driver for SI476x code

2012-10-25 Thread Andrey Smirnov
On 10/25/2012 12:45 PM, Mark Brown wrote: > On Tue, Oct 23, 2012 at 11:44:28AM -0700, Andrey Smirnov wrote: > >> +core->regmap = devm_regmap_init_si476x(core); >> +if (IS_ERR(core->regmap)) { > This really makes little sense to me, why are you doing this? Does the > device *really* layer a

Re: [PATCH v3 2/6] Add the main bulk of core driver for SI476x code

2012-10-25 Thread Mark Brown
On Tue, Oct 23, 2012 at 11:44:28AM -0700, Andrey Smirnov wrote: > + core->regmap = devm_regmap_init_si476x(core); > + if (IS_ERR(core->regmap)) { This really makes little sense to me, why are you doing this? Does the device *really* layer a byte stream on top of I2C for sending messages

[PATCH v3 2/6] Add the main bulk of core driver for SI476x code

2012-10-23 Thread Andrey Smirnov
This patch adds main part(out of three) of the I2C driver for the "core" of MFD device. Signed-off-by: Andrey Smirnov --- drivers/mfd/si476x-i2c.c | 966 ++ 1 file changed, 966 insertions(+) create mode 100644 drivers/mfd/si476x-i2c.c diff --git a/d