Re: [PATCH v3 2/6] PCI: brcmstb: Add control of EP voltage regulators

2021-03-29 Thread Mark Brown
On Mon, Mar 29, 2021 at 02:09:58PM -0700, Florian Fainelli wrote: > On 3/29/21 1:45 PM, Mark Brown wrote: > > management in the driver anyway? Just mark the regualtors as always on > > and set up an appropriate suspend mode configuration and everything > > should work without the drivers doing

Re: [PATCH v3 2/6] PCI: brcmstb: Add control of EP voltage regulators

2021-03-29 Thread Florian Fainelli
On 3/29/21 1:45 PM, Mark Brown wrote: > On Mon, Mar 29, 2021 at 03:48:46PM -0400, Jim Quinlan wrote: > >> I'm not concerned about a namespace collision and I don't think you >> should be concerned either. First, this driver is for Broadcom STB >> PCIe chips and boards, and we also deliver the DT

Re: [PATCH v3 2/6] PCI: brcmstb: Add control of EP voltage regulators

2021-03-29 Thread Mark Brown
On Mon, Mar 29, 2021 at 03:48:46PM -0400, Jim Quinlan wrote: > I'm not concerned about a namespace collision and I don't think you > should be concerned either. First, this driver is for Broadcom STB > PCIe chips and boards, and we also deliver the DT to the customers. > We typically do not have

Re: [PATCH v3 2/6] PCI: brcmstb: Add control of EP voltage regulators

2021-03-29 Thread Jim Quinlan
/* Pmap_idx to avs pmap number */ const uint8_t pmap_idx_to_avs_id[20]; On Mon, Mar 29, 2021 at 1:16 PM Mark Brown wrote: > > On Mon, Mar 29, 2021 at 12:39:50PM -0400, Jim Quinlan wrote: > > On Mon, Mar 29, 2021 at 12:25 PM Mark Brown > > > > Here you are figuring out a device local

Re: [PATCH v3 2/6] PCI: brcmstb: Add control of EP voltage regulators

2021-03-29 Thread Mark Brown
On Mon, Mar 29, 2021 at 12:39:50PM -0400, Jim Quinlan wrote: > On Mon, Mar 29, 2021 at 12:25 PM Mark Brown > > Here you are figuring out a device local supply name... > > > + /* > > > + * Get the regulators that the EP devianswerces require. We cannot > > > use > > > + *

Re: [PATCH v3 2/6] PCI: brcmstb: Add control of EP voltage regulators

2021-03-29 Thread Jim Quinlan
On Mon, Mar 29, 2021 at 12:25 PM Mark Brown w./lib/python3.6/site-packages/dtschema/schemasrote: > > On Fri, Mar 26, 2021 at 03:19:00PM -0400, Jim Quinlan wrote: > > > + /* Now look for regulator supply properties */ > > + for_each_property_of_node(child, pp) { > > +

Re: [PATCH v3 2/6] PCI: brcmstb: Add control of EP voltage regulators

2021-03-29 Thread Mark Brown
On Fri, Mar 26, 2021 at 03:19:00PM -0400, Jim Quinlan wrote: > + /* Now look for regulator supply properties */ > + for_each_property_of_node(child, pp) { > + int i, n = strnlen(pp->name, max_name_len); > + > + if (n <= 7 ||

Re: [PATCH v3 2/6] PCI: brcmstb: Add control of EP voltage regulators

2021-03-29 Thread Mark Brown
On Fri, Mar 26, 2021 at 03:19:00PM -0400, Jim Quinlan wrote: > Control of EP regulators by the RC is needed because of the chicken-and-egg > situation: although the regulator is "owned" by the EP and would be best > handled on its driver, the EP cannot be discovered and probed unless its >

Re: [PATCH v3 2/6] PCI: brcmstb: Add control of EP voltage regulators

2021-03-27 Thread Jim Quinlan
On Fri, Mar 26, 2021 at 4:11 PM Bjorn Helgaas wrote: > > On Fri, Mar 26, 2021 at 03:19:00PM -0400, Jim Quinlan wrote: > > Control of EP regulators by the RC is needed because of the chicken-and-egg > > Can you expand "EP"? Not sure if this refers to "endpoint" or > something else. Yes I meant

Re: [PATCH v3 2/6] PCI: brcmstb: Add control of EP voltage regulators

2021-03-26 Thread Bjorn Helgaas
On Fri, Mar 26, 2021 at 03:19:00PM -0400, Jim Quinlan wrote: > Control of EP regulators by the RC is needed because of the chicken-and-egg Can you expand "EP"? Not sure if this refers to "endpoint" or something else. If this refers to a device in a slot, I guess it isn't necessarily a PCIe

[PATCH v3 2/6] PCI: brcmstb: Add control of EP voltage regulators

2021-03-26 Thread Jim Quinlan
Control of EP regulators by the RC is needed because of the chicken-and-egg situation: although the regulator is "owned" by the EP and would be best handled on its driver, the EP cannot be discovered and probed unless its regulator is already turned on. Signed-off-by: Jim Quinlan ---