Re: [PATCH v3 2/6] arm64/mm: use default dummy memory_add_physaddr_to_nid()

[David Hildenbrand]

On 09.07.20 04:06, Jia He wrote:
> After making default memory_add_physaddr_to_nid() in mm/memory_hotplug,
> it is no use defining a similar one in arch specific directory.
> 
> Signed-off-by: Jia He 
> ---
>  arch/arm64/mm/numa.c | 10 --
>  1 file changed, 10 deletions(-)
> 
> diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
> index aafcee3e3f7e..73f8b49d485c 100644
> --- a/arch/arm64/mm/numa.c
> +++ b/arch/arm64/mm/numa.c
> @@ -461,13 +461,3 @@ void __init arm64_numa_init(void)
>  
>   numa_init(dummy_numa_init);
>  }
> -
> -/*
> - * We hope that we will be hotplugging memory on nodes we already know about,
> - * such that acpi_get_node() succeeds and we never fall back to this...
> - */
> -int memory_add_physaddr_to_nid(u64 addr)
> -{
> - pr_warn("Unknown node for memory at 0x%llx, assuming node 0\n", addr);
> - return 0;
> -}
> 

Reviewed-by: David Hildenbrand 

-- 
Thanks,

David / dhildenb

[PATCH v3 2/6] arm64/mm: use default dummy memory_add_physaddr_to_nid()

[Jia He]

After making default memory_add_physaddr_to_nid() in mm/memory_hotplug,
it is no use defining a similar one in arch specific directory.

Signed-off-by: Jia He 
---
 arch/arm64/mm/numa.c | 10 --
 1 file changed, 10 deletions(-)

diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
index aafcee3e3f7e..73f8b49d485c 100644
--- a/arch/arm64/mm/numa.c
+++ b/arch/arm64/mm/numa.c
@@ -461,13 +461,3 @@ void __init arm64_numa_init(void)
 
numa_init(dummy_numa_init);
 }
-
-/*
- * We hope that we will be hotplugging memory on nodes we already know about,
- * such that acpi_get_node() succeeds and we never fall back to this...
- */
-int memory_add_physaddr_to_nid(u64 addr)
-{
-   pr_warn("Unknown node for memory at 0x%llx, assuming node 0\n", addr);
-   return 0;
-}
-- 
2.17.1