Re: [PATCH v3 2/7] mmc: atmel-mci: prepare clk before calling enable

2013-07-16 Thread Russell King - ARM Linux
On Tue, Jul 16, 2013 at 05:06:48PM +0200, Boris BREZILLON wrote: > @@ -389,9 +391,13 @@ static int atmci_regs_show(struct seq_file *s, void *v) >* consistent. >*/ > spin_lock_bh(>lock); > - clk_enable(host->mck); > + ret = clk_prepare_enable(host->mck); > + if

Re: [PATCH v3 2/7] mmc: atmel-mci: prepare clk before calling enable

2013-07-16 Thread boris brezillon
Hello Thomas, On 16/07/2013 17:13, Thomas Petazzoni wrote: Dear Boris BREZILLON, On Tue, 16 Jul 2013 17:06:48 +0200, Boris BREZILLON wrote: buf = kmalloc(ATMCI_REGS_SIZE, GFP_KERNEL); if (!buf) @@ -389,9 +391,13 @@ static int atmci_regs_show(struct seq_file *s, void *v)

Re: [PATCH v3 2/7] mmc: atmel-mci: prepare clk before calling enable

2013-07-16 Thread Thomas Petazzoni
Dear Boris BREZILLON, On Tue, 16 Jul 2013 17:06:48 +0200, Boris BREZILLON wrote: > buf = kmalloc(ATMCI_REGS_SIZE, GFP_KERNEL); > if (!buf) > @@ -389,9 +391,13 @@ static int atmci_regs_show(struct seq_file *s, void *v) >* consistent. >*/ > spin_lock_bh(>lock); >

[PATCH v3 2/7] mmc: atmel-mci: prepare clk before calling enable

2013-07-16 Thread Boris BREZILLON
Replace clk_enable/disable with clk_prepare_enable/disable_unprepare to avoid common clk framework warnings. Signed-off-by: Boris BREZILLON Acked-by: Ludovic Desroches --- drivers/mmc/host/atmel-mci.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff

[PATCH v3 2/7] mmc: atmel-mci: prepare clk before calling enable

2013-07-16 Thread Boris BREZILLON
Replace clk_enable/disable with clk_prepare_enable/disable_unprepare to avoid common clk framework warnings. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 27 ++- 1 file

Re: [PATCH v3 2/7] mmc: atmel-mci: prepare clk before calling enable

2013-07-16 Thread Thomas Petazzoni
Dear Boris BREZILLON, On Tue, 16 Jul 2013 17:06:48 +0200, Boris BREZILLON wrote: buf = kmalloc(ATMCI_REGS_SIZE, GFP_KERNEL); if (!buf) @@ -389,9 +391,13 @@ static int atmci_regs_show(struct seq_file *s, void *v) * consistent. */ spin_lock_bh(host-lock); -

Re: [PATCH v3 2/7] mmc: atmel-mci: prepare clk before calling enable

2013-07-16 Thread boris brezillon
Hello Thomas, On 16/07/2013 17:13, Thomas Petazzoni wrote: Dear Boris BREZILLON, On Tue, 16 Jul 2013 17:06:48 +0200, Boris BREZILLON wrote: buf = kmalloc(ATMCI_REGS_SIZE, GFP_KERNEL); if (!buf) @@ -389,9 +391,13 @@ static int atmci_regs_show(struct seq_file *s, void *v)

Re: [PATCH v3 2/7] mmc: atmel-mci: prepare clk before calling enable

2013-07-16 Thread Russell King - ARM Linux
On Tue, Jul 16, 2013 at 05:06:48PM +0200, Boris BREZILLON wrote: @@ -389,9 +391,13 @@ static int atmci_regs_show(struct seq_file *s, void *v) * consistent. */ spin_lock_bh(host-lock); - clk_enable(host-mck); + ret = clk_prepare_enable(host-mck); + if (ret) {