Re: [PATCH v3 2/7] mmc: mediatek: Add Mediatek MMC driver

2015-05-11 Thread Ulf Hansson
On 11 May 2015 at 11:18, Chaotian Jing wrote: > On Fri, 2015-05-08 at 14:12 +0200, Ulf Hansson wrote: >> On 7 May 2015 at 03:42, Chaotian Jing wrote: >> > Dear Ulf, >> > >> > Thanks! >> > Below is my comment: >> > >> > On Wed, 2015-05-06 at 18:31 +0200, Ulf Hansson wrote: >> >> On 6 May 2015 at 0

Re: [PATCH v3 2/7] mmc: mediatek: Add Mediatek MMC driver

2015-05-08 Thread Ulf Hansson
On 7 May 2015 at 03:42, Chaotian Jing wrote: > Dear Ulf, > > Thanks! > Below is my comment: > > On Wed, 2015-05-06 at 18:31 +0200, Ulf Hansson wrote: >> On 6 May 2015 at 08:54, chaotian.jing wrote: >> > Dear Ulf, >> > >> > Thanks for your review. >> > I must do a explain of our MMC host: >> > Sou

Re: [PATCH v3 2/7] mmc: mediatek: Add Mediatek MMC driver

2015-05-06 Thread Ulf Hansson
On 6 May 2015 at 08:54, chaotian.jing wrote: > Dear Ulf, > > Thanks for your review. > I must do a explain of our MMC host: > Source clock is source clock of the MMC bus, MMC host has a divider to > get different bus clock frequency. now the runtime suspend is gating > this clock. > > Hclk is the

Re: [PATCH v3 2/7] mmc: mediatek: Add Mediatek MMC driver

2015-05-05 Thread Ulf Hansson
On 28 April 2015 at 11:48, Chaotian Jing wrote: > Add Mediatek MMC driver code > Support eMMC/SD/SDIO > > Signed-off-by: Chaotian Jing > --- > drivers/mmc/host/Kconfig |8 + > drivers/mmc/host/Makefile |1 + > drivers/mmc/host/mtk-sd.c | 1416 > +