Re: [PATCH v3 3/3] dt-bindings: iio: dac: ad5686: add binding

2020-10-10 Thread Jonathan Cameron
On Tue, 29 Sep 2020 13:53:00 -0500 Rob Herring wrote: > On Thu, 24 Sep 2020 14:52:14 -0500, Michael Auchter wrote: > > Add a binding for AD5686 > > > > Signed-off-by: Michael Auchter > > --- > > Changes since v1: > > - Keep supported device sorted > > - fix adc -> dac typo in schema path > >

Re: [PATCH v3 3/3] dt-bindings: iio: dac: ad5686: add binding

2020-09-29 Thread Rob Herring
On Thu, 24 Sep 2020 14:52:14 -0500, Michael Auchter wrote: > Add a binding for AD5686 > > Signed-off-by: Michael Auchter > --- > Changes since v1: > - Keep supported device sorted > - fix adc -> dac typo in schema path > since v2: > - drop address-cells and size-cells from binding doc > - add

Re: [PATCH v3 3/3] dt-bindings: iio: dac: ad5686: add binding

2020-09-25 Thread Jonathan Cameron
On Thu, 24 Sep 2020 14:52:14 -0500 Michael Auchter wrote: > Add a binding for AD5686 > > Signed-off-by: Michael Auchter Hi Michael, Looks good to me, but I've made many a mistake on reviewing these in the past so good to get Rob's input if he has time. Thanks, Jonathan > --- > Changes

[PATCH v3 3/3] dt-bindings: iio: dac: ad5686: add binding

2020-09-24 Thread Michael Auchter
Add a binding for AD5686 Signed-off-by: Michael Auchter --- Changes since v1: - Keep supported device sorted - fix adc -> dac typo in schema path since v2: - drop address-cells and size-cells from binding doc - add "additionalProperties: false" - end with ...