Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

On Wed, 2016-08-03 at 11:51 +0900, Masashi Honma wrote: > On 2016年08月02日 16:27, Johannes Berg wrote: > > This explicitly configures *HT capability* though - that's even the > > name of the parameter. If you enable HT40 in the capability, the > > resulting BSS might still not actually *use* 40 MHz

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

On Wed, 2016-08-03 at 11:51 +0900, Masashi Honma wrote: > On 2016年08月02日 16:27, Johannes Berg wrote: > > This explicitly configures *HT capability* though - that's even the > > name of the parameter. If you enable HT40 in the capability, the > > resulting BSS might still not actually *use* 40 MHz

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

On 2016年08月02日 16:27, Johannes Berg wrote: This explicitly configures *HT capability* though - that's even the name of the parameter. If you enable HT40 in the capability, the resulting BSS might still not actually *use* 40 MHz bandwidth, as required by overlapping BSS detection. OK, I see.

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

On 2016年08月02日 16:27, Johannes Berg wrote: This explicitly configures *HT capability* though - that's even the name of the parameter. If you enable HT40 in the capability, the resulting BSS might still not actually *use* 40 MHz bandwidth, as required by overlapping BSS detection. OK, I see.

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

On Tue, 2016-08-02 at 11:59 +0900, Masashi Honma wrote: > > > > On 2016年08月01日 19:03, Johannes Berg wrote: > > > > > > But why is that behaviour *correct*? We still support 40 MHz > > > bandwidth > > > things, we just don't use them if we disable HT40. > > Or do you mean difference between

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

On Tue, 2016-08-02 at 11:59 +0900, Masashi Honma wrote: > > > > On 2016年08月01日 19:03, Johannes Berg wrote: > > > > > > But why is that behaviour *correct*? We still support 40 MHz > > > bandwidth > > > things, we just don't use them if we disable HT40. > > Or do you mean difference between

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

On 2016年08月01日 19:03, Johannes Berg wrote: But why is that behaviour *correct*? We still support 40 MHz bandwidth things, we just don't use them if we disable HT40. Or do you mean difference between "hardware capability" and "software capability" ? Do you think

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

On 2016年08月01日 19:03, Johannes Berg wrote: But why is that behaviour *correct*? We still support 40 MHz bandwidth things, we just don't use them if we disable HT40. Or do you mean difference between "hardware capability" and "software capability" ? Do you think

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

On 2016年08月01日 19:03, Johannes Berg wrote: But why is that behaviour *correct*? We still support 40 MHz bandwidth things, we just don't use them if we disable HT40. I could not fully understand your concern... Do you mean we have 2 bugs about disabling HT40 ? 1) bits in HT capabilities IE

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

On 2016年08月01日 19:03, Johannes Berg wrote: But why is that behaviour *correct*? We still support 40 MHz bandwidth things, we just don't use them if we disable HT40. I could not fully understand your concern... Do you mean we have 2 bugs about disabling HT40 ? 1) bits in HT capabilities IE

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

On Fri, 2016-07-22 at 14:26 +0900, Masashi Honma wrote: > On 2016年07月14日 05:07, Yaniv Machani wrote: > > + > > + /* if channel width is 20MHz - configure HT capab > > accordingly*/ > > + if (sdata->vif.bss_conf.chandef.width == > > NL80211_CHAN_WIDTH_20) { > > + cap &=

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

On Fri, 2016-07-22 at 14:26 +0900, Masashi Honma wrote: > On 2016年07月14日 05:07, Yaniv Machani wrote: > > + > > + /* if channel width is 20MHz - configure HT capab > > accordingly*/ > > + if (sdata->vif.bss_conf.chandef.width == > > NL80211_CHAN_WIDTH_20) { > > + cap &=

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

On 2016年07月22日 14:26, Masashi Honma wrote: > On 2016年07月14日 05:07, Yaniv Machani wrote: >> + >> +/* if channel width is 20MHz - configure HT capab accordingly*/ >> +if (sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_20) { >> +cap &= ~IEEE80211_HT_CAP_SUP_WIDTH_20_40; >> +

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

On 2016年07月22日 14:26, Masashi Honma wrote: > On 2016年07月14日 05:07, Yaniv Machani wrote: >> + >> +/* if channel width is 20MHz - configure HT capab accordingly*/ >> +if (sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_20) { >> +cap &= ~IEEE80211_HT_CAP_SUP_WIDTH_20_40; >> +

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

On 2016年07月14日 05:07, Yaniv Machani wrote: + + /* if channel width is 20MHz - configure HT capab accordingly*/ + if (sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_20) { + cap &= ~IEEE80211_HT_CAP_SUP_WIDTH_20_40; + cap &=

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

On 2016年07月14日 05:07, Yaniv Machani wrote: + + /* if channel width is 20MHz - configure HT capab accordingly*/ + if (sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_20) { + cap &= ~IEEE80211_HT_CAP_SUP_WIDTH_20_40; + cap &=

[PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

The HT capab info field inside the HT capab IE of the mesh beacon is incorrect (in the case of 20MHz channel width). To fix this driver will check configuration from cfg and will build it accordingly. Signed-off-by: Meirav Kama Signed-off-by: Yaniv Machani --- V3

[PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

The HT capab info field inside the HT capab IE of the mesh beacon is incorrect (in the case of 20MHz channel width). To fix this driver will check configuration from cfg and will build it accordingly. Signed-off-by: Meirav Kama Signed-off-by: Yaniv Machani --- V3 - Fixes redundant spaces,empty