Re: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.

2019-04-08 Thread Andy Shevchenko
On Sat, Apr 06, 2019 at 06:46:13PM -0700, Life is hard, and then you die wrote: > > On Mon, Apr 01, 2019 at 07:47:14PM -0700, Life is hard, and then you die > > wrote: > > > On Thu, Mar 28, 2019 at 12:29:52PM +0100, Greg Kroah-Hartman wrote: > > > > On Thu, Mar 28, 2019 at 03:27:55AM -0700, Life

Re: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.

2019-04-06 Thread Life is hard, and then you die
> On Mon, Apr 01, 2019 at 07:47:14PM -0700, Life is hard, and then you die > wrote: > > > > On Thu, Mar 28, 2019 at 12:29:52PM +0100, Greg Kroah-Hartman wrote: > > > On Thu, Mar 28, 2019 at 03:27:55AM -0700, Life is hard, and then you die > > > wrote: > > > > > > > > On Thu, Mar 28, 2019 at

Re: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.

2019-04-02 Thread Greg Kroah-Hartman
On Mon, Apr 01, 2019 at 07:47:14PM -0700, Life is hard, and then you die wrote: > > On Thu, Mar 28, 2019 at 12:29:52PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Mar 28, 2019 at 03:27:55AM -0700, Life is hard, and then you die > > wrote: > > > > > > On Thu, Mar 28, 2019 at 06:29:17AM +0100,

Re: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.

2019-04-01 Thread Life is hard, and then you die
On Thu, Mar 28, 2019 at 12:29:52PM +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 28, 2019 at 03:27:55AM -0700, Life is hard, and then you die > wrote: > > > > On Thu, Mar 28, 2019 at 06:29:17AM +0100, Greg Kroah-Hartman wrote: > > > On Wed, Mar 27, 2019 at 05:28:17PM -0700, Life is hard, and

Re: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.

2019-03-28 Thread Steven Rostedt
On Thu, 28 Mar 2019 12:29:52 +0100 Greg Kroah-Hartman wrote: > > 3. In at least two places we log different types of packets in the > > same lines of code (protected by a "if (log_mask & PKT_TYPE)") - > > dynamic-debug would only allow enabling or disabling logging of > > all

Re: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.

2019-03-28 Thread Greg Kroah-Hartman
On Thu, Mar 28, 2019 at 03:27:55AM -0700, Life is hard, and then you die wrote: > > On Thu, Mar 28, 2019 at 06:29:17AM +0100, Greg Kroah-Hartman wrote: > > On Wed, Mar 27, 2019 at 05:28:17PM -0700, Life is hard, and then you die > > wrote: > > > > > > On Wed, Mar 27, 2019 at 11:37:57AM +0900,

Re: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.

2019-03-28 Thread Life is hard, and then you die
On Thu, Mar 28, 2019 at 06:29:17AM +0100, Greg Kroah-Hartman wrote: > On Wed, Mar 27, 2019 at 05:28:17PM -0700, Life is hard, and then you die > wrote: > > > > On Wed, Mar 27, 2019 at 11:37:57AM +0900, Greg Kroah-Hartman wrote: > > > On Tue, Mar 26, 2019 at 06:48:06PM -0700, Ronald Tschalär

Re: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.

2019-03-27 Thread Greg Kroah-Hartman
On Wed, Mar 27, 2019 at 05:28:17PM -0700, Life is hard, and then you die wrote: > > On Wed, Mar 27, 2019 at 11:37:57AM +0900, Greg Kroah-Hartman wrote: > > On Tue, Mar 26, 2019 at 06:48:06PM -0700, Ronald Tschalär wrote: > > > This is the dev_xxx() analog to print_hex_dump(), using dev_printk() >

Re: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.

2019-03-27 Thread Life is hard, and then you die
On Wed, Mar 27, 2019 at 11:37:57AM +0900, Greg Kroah-Hartman wrote: > On Tue, Mar 26, 2019 at 06:48:06PM -0700, Ronald Tschalär wrote: > > This is the dev_xxx() analog to print_hex_dump(), using dev_printk() > > instead of straight printk() to match other dev_xxx() logging functions. > > --- > >

Re: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.

2019-03-26 Thread Greg Kroah-Hartman
On Tue, Mar 26, 2019 at 06:48:06PM -0700, Ronald Tschalär wrote: > This is the dev_xxx() analog to print_hex_dump(), using dev_printk() > instead of straight printk() to match other dev_xxx() logging functions. > --- > drivers/base/core.c| 43 ++ >

[PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.

2019-03-26 Thread Ronald Tschalär
This is the dev_xxx() analog to print_hex_dump(), using dev_printk() instead of straight printk() to match other dev_xxx() logging functions. --- drivers/base/core.c| 43 ++ include/linux/device.h | 15 +++ 2 files changed, 58 insertions(+)