RE: [PATCH v3 3/8] selftests/resctrl: Read memory bandwidth from perf IMC counter and from resctrl file system

2018-11-21 Thread Pathan, Arshiya Hayatkhan
> > +static int initialize_mem_bw_imc(void) > > +{ > > + int imc, j; > > + > > + imcs = num_of_imcs(); > > + if (imcs < 0) > > I think this condition should be "<=". Pls check. Thank you for pointing it out. It makes sense to change it to "<=". Will fix it in next version. > > +

RE: [PATCH v3 3/8] selftests/resctrl: Read memory bandwidth from perf IMC counter and from resctrl file system

2018-11-21 Thread Pathan, Arshiya Hayatkhan
> > +static int initialize_mem_bw_imc(void) > > +{ > > + int imc, j; > > + > > + imcs = num_of_imcs(); > > + if (imcs < 0) > > I think this condition should be "<=". Pls check. Thank you for pointing it out. It makes sense to change it to "<=". Will fix it in next version. > > +

Re: [PATCH v3 3/8] selftests/resctrl: Read memory bandwidth from perf IMC counter and from resctrl file system

2018-11-12 Thread Moger, Babu
On 10/31/18 4:02 PM, Fenghua Yu wrote: > From: Sai Praneeth Prakhya > > Total memory bandwidth can be monitored from perf IMC counter and from > resctrl file system. Later the two will be compared to verify the total > memory bandwidth read from resctrl is correct. > > Signed-off-by: Sai

Re: [PATCH v3 3/8] selftests/resctrl: Read memory bandwidth from perf IMC counter and from resctrl file system

2018-11-12 Thread Moger, Babu
On 10/31/18 4:02 PM, Fenghua Yu wrote: > From: Sai Praneeth Prakhya > > Total memory bandwidth can be monitored from perf IMC counter and from > resctrl file system. Later the two will be compared to verify the total > memory bandwidth read from resctrl is correct. > > Signed-off-by: Sai

[PATCH v3 3/8] selftests/resctrl: Read memory bandwidth from perf IMC counter and from resctrl file system

2018-10-31 Thread Fenghua Yu
From: Sai Praneeth Prakhya Total memory bandwidth can be monitored from perf IMC counter and from resctrl file system. Later the two will be compared to verify the total memory bandwidth read from resctrl is correct. Signed-off-by: Sai Praneeth Prakhya Signed-off-by: Arshiya Hayatkhan Pathan

[PATCH v3 3/8] selftests/resctrl: Read memory bandwidth from perf IMC counter and from resctrl file system

2018-10-31 Thread Fenghua Yu
From: Sai Praneeth Prakhya Total memory bandwidth can be monitored from perf IMC counter and from resctrl file system. Later the two will be compared to verify the total memory bandwidth read from resctrl is correct. Signed-off-by: Sai Praneeth Prakhya Signed-off-by: Arshiya Hayatkhan Pathan