Re: [PATCH v3 3/9] perf script: Add more filter to find_scripts()

2012-09-27 Thread Namhyung Kim
On Thu, 27 Sep 2012 13:45:30 +0900, Namhyung Kim wrote: > It'd not that hard. How about using below (untested) patch? Hmm... it won't work for some cases. Please ignore this. Thanks, Namhyung > > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c > index

Re: [PATCH v3 3/9] perf script: Add more filter to find_scripts()

2012-09-27 Thread Namhyung Kim
On Thu, 27 Sep 2012 13:45:30 +0900, Namhyung Kim wrote: It'd not that hard. How about using below (untested) patch? Hmm... it won't work for some cases. Please ignore this. Thanks, Namhyung diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index

Re: [PATCH v3 3/9] perf script: Add more filter to find_scripts()

2012-09-26 Thread Namhyung Kim
On Wed, 26 Sep 2012 16:56:41 +0800, Feng Tang wrote: > On Tue, 25 Sep 2012 10:47:03 +0900 > Namhyung Kim wrote: >> It can't recognize extra spaces, multiple events connected by commas, >> event groups and probably more.. So I think it'd better if we can use >> parse_events() here - but w/o an

Re: [PATCH v3 3/9] perf script: Add more filter to find_scripts()

2012-09-26 Thread Feng Tang
On Tue, 25 Sep 2012 10:47:03 +0900 Namhyung Kim wrote: > Hi Feng, > > On Mon, 24 Sep 2012 23:24:05 +0800, Feng Tang wrote: > > As suggested by Arnaldo, many scripts have their own usages and need > > capture specific events or tracepoints, so only those scripts whose > > targe events match the

Re: [PATCH v3 3/9] perf script: Add more filter to find_scripts()

2012-09-26 Thread Feng Tang
On Tue, 25 Sep 2012 10:47:03 +0900 Namhyung Kim namhy...@kernel.org wrote: Hi Feng, On Mon, 24 Sep 2012 23:24:05 +0800, Feng Tang wrote: As suggested by Arnaldo, many scripts have their own usages and need capture specific events or tracepoints, so only those scripts whose targe events

Re: [PATCH v3 3/9] perf script: Add more filter to find_scripts()

2012-09-26 Thread Namhyung Kim
On Wed, 26 Sep 2012 16:56:41 +0800, Feng Tang wrote: On Tue, 25 Sep 2012 10:47:03 +0900 Namhyung Kim namhy...@kernel.org wrote: It can't recognize extra spaces, multiple events connected by commas, event groups and probably more.. So I think it'd better if we can use parse_events() here -

Re: [PATCH v3 3/9] perf script: Add more filter to find_scripts()

2012-09-24 Thread Namhyung Kim
Hi Feng, On Mon, 24 Sep 2012 23:24:05 +0800, Feng Tang wrote: > As suggested by Arnaldo, many scripts have their own usages and need > capture specific events or tracepoints, so only those scripts whose > targe events match the events in current perf data file should be > listed in the script

[PATCH v3 3/9] perf script: Add more filter to find_scripts()

2012-09-24 Thread Feng Tang
As suggested by Arnaldo, many scripts have their own usages and need capture specific events or tracepoints, so only those scripts whose targe events match the events in current perf data file should be listed in the script browser menu. This patch will add the event match checking.

[PATCH v3 3/9] perf script: Add more filter to find_scripts()

2012-09-24 Thread Feng Tang
As suggested by Arnaldo, many scripts have their own usages and need capture specific events or tracepoints, so only those scripts whose targe events match the events in current perf data file should be listed in the script browser menu. This patch will add the event match checking.

Re: [PATCH v3 3/9] perf script: Add more filter to find_scripts()

2012-09-24 Thread Namhyung Kim
Hi Feng, On Mon, 24 Sep 2012 23:24:05 +0800, Feng Tang wrote: As suggested by Arnaldo, many scripts have their own usages and need capture specific events or tracepoints, so only those scripts whose targe events match the events in current perf data file should be listed in the script browser