Re: [PATCH v3 4/4] Input: add Apple SPI keyboard and trackpad driver.

2019-03-27 Thread Life is hard, and then you die
On Wed, Mar 27, 2019 at 11:35:30AM +0200, Andy Shevchenko wrote: > On Tue, Mar 26, 2019 at 06:48:07PM -0700, Ronald Tschalär wrote: > > The keyboard and trackpad on recent MacBook's (since 8,1) and > > MacBookPro's (13,* and 14,*) are attached to an SPI controller instead > > of USB, as

Re: [PATCH v3 4/4] Input: add Apple SPI keyboard and trackpad driver.

2019-03-27 Thread Andy Shevchenko
On Wed, Mar 27, 2019 at 07:45:26PM +0100, Greg Kroah-Hartman wrote: > On Wed, Mar 27, 2019 at 11:35:30AM +0200, Andy Shevchenko wrote: > > On Tue, Mar 26, 2019 at 06:48:07PM -0700, Ronald Tschalär wrote: > > > The keyboard and trackpad on recent MacBook's (since 8,1) and > > > MacBookPro's (13,*

Re: [PATCH v3 4/4] Input: add Apple SPI keyboard and trackpad driver.

2019-03-27 Thread Steven Rostedt
On Wed, 27 Mar 2019 19:45:26 +0100 Greg Kroah-Hartman wrote: > > > +// SPDX-License-Identifier: GPL-2.0 > > > > According to last changes this should be GPL-2.0-only > > What "last changes"? "GPL-2.0" is a totally valid SPDX identifier for > the kernel. Don't buy into the "-only" prefix

Re: [PATCH v3 4/4] Input: add Apple SPI keyboard and trackpad driver.

2019-03-27 Thread Greg Kroah-Hartman
On Wed, Mar 27, 2019 at 11:35:30AM +0200, Andy Shevchenko wrote: > On Tue, Mar 26, 2019 at 06:48:07PM -0700, Ronald Tschalär wrote: > > The keyboard and trackpad on recent MacBook's (since 8,1) and > > MacBookPro's (13,* and 14,*) are attached to an SPI controller instead > > of USB, as

Re: [PATCH v3 4/4] Input: add Apple SPI keyboard and trackpad driver.

2019-03-27 Thread Andy Shevchenko
On Tue, Mar 26, 2019 at 06:48:07PM -0700, Ronald Tschalär wrote: > The keyboard and trackpad on recent MacBook's (since 8,1) and > MacBookPro's (13,* and 14,*) are attached to an SPI controller instead > of USB, as previously. The higher level protocol is not publicly > documented and hence has

[PATCH v3 4/4] Input: add Apple SPI keyboard and trackpad driver.

2019-03-26 Thread Ronald Tschalär
The keyboard and trackpad on recent MacBook's (since 8,1) and MacBookPro's (13,* and 14,*) are attached to an SPI controller instead of USB, as previously. The higher level protocol is not publicly documented and hence has been reverse engineered. As a consequence there are still a number of