Re: [PATCH v3 4/4] kmod: throttle kmod thread limit

2017-06-26 Thread Petr Mladek
On Fri 2017-06-23 21:16:37, Luis R. Rodriguez wrote: > On Fri, Jun 23, 2017 at 07:56:11PM +0200, Luis R. Rodriguez wrote: > > On Fri, Jun 23, 2017 at 06:16:19PM +0200, Luis R. Rodriguez wrote: > > > On Thu, Jun 22, 2017 at 05:19:36PM +0200, Petr Mladek wrote: > > > > On Fri 2017-05-26 14:12:28, Lui

Re: [PATCH v3 4/4] kmod: throttle kmod thread limit

2017-06-26 Thread Petr Mladek
On Fri 2017-06-23 18:16:19, Luis R. Rodriguez wrote: > On Thu, Jun 22, 2017 at 05:19:36PM +0200, Petr Mladek wrote: > > On Fri 2017-05-26 14:12:28, Luis R. Rodriguez wrote: > > > --- a/kernel/kmod.c > > > +++ b/kernel/kmod.c > > > @@ -163,14 +163,11 @@ int __request_module(bool wait, const char *fm

Re: [PATCH v3 4/4] kmod: throttle kmod thread limit

2017-06-23 Thread Luis R. Rodriguez
On Fri, Jun 23, 2017 at 07:56:11PM +0200, Luis R. Rodriguez wrote: > On Fri, Jun 23, 2017 at 06:16:19PM +0200, Luis R. Rodriguez wrote: > > On Thu, Jun 22, 2017 at 05:19:36PM +0200, Petr Mladek wrote: > > > On Fri 2017-05-26 14:12:28, Luis R. Rodriguez wrote: > > > > --- a/kernel/kmod.c > > > > +++

Re: [PATCH v3 4/4] kmod: throttle kmod thread limit

2017-06-23 Thread Luis R. Rodriguez
On Fri, Jun 23, 2017 at 06:16:19PM +0200, Luis R. Rodriguez wrote: > On Thu, Jun 22, 2017 at 05:19:36PM +0200, Petr Mladek wrote: > > On Fri 2017-05-26 14:12:28, Luis R. Rodriguez wrote: > > > --- a/kernel/kmod.c > > > +++ b/kernel/kmod.c > > > @@ -178,6 +175,7 @@ int __request_module(bool wait, co

Re: [PATCH v3 4/4] kmod: throttle kmod thread limit

2017-06-23 Thread Luis R. Rodriguez
On Thu, Jun 22, 2017 at 05:19:36PM +0200, Petr Mladek wrote: > On Fri 2017-05-26 14:12:28, Luis R. Rodriguez wrote: > > --- a/kernel/kmod.c > > +++ b/kernel/kmod.c > > @@ -163,14 +163,11 @@ int __request_module(bool wait, const char *fmt, ...) > > return ret; > > > > if (atomic_de

Re: [PATCH v3 4/4] kmod: throttle kmod thread limit

2017-06-22 Thread Petr Mladek
On Fri 2017-05-26 14:12:28, Luis R. Rodriguez wrote: > If we reach the limit of modprobe_limit threads running the next > request_module() call will fail. The original reason for adding > a kill was to do away with possible issues with in old circumstances > which would create a recursive series of

[PATCH v3 4/4] kmod: throttle kmod thread limit

2017-05-26 Thread Luis R. Rodriguez
If we reach the limit of modprobe_limit threads running the next request_module() call will fail. The original reason for adding a kill was to do away with possible issues with in old circumstances which would create a recursive series of request_module() calls. We can do better than just be super