Re: [PATCH v3 4/5] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-22 Thread Krzysztof Kozlowski
On Fri, 2013-11-22 at 10:15 +, Lee Jones wrote: > > +#ifdef CONFIG_OF > > +static int max14577_regulator_dt_parse_pdata(struct platform_device *pdev, > > + struct max14577_platform_data *pdata) > > +{ > > + struct max14577 *max14577 = dev_get_drvdata(pdev->de

Re: [PATCH v3 4/5] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-22 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday, November 22, 2013 09:46:11 AM Krzysztof Kozlowski wrote: [...] > +static int max14577_regulator_probe(struct platform_device *pdev) > +{ > + struct max14577 *max14577 = dev_get_drvdata(pdev->dev.parent); > + struct max14577_platform_data *pdata = dev_get_platdata(max14577

Re: [PATCH v3 4/5] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-22 Thread Lee Jones
On Fri, 22 Nov 2013, Krzysztof Kozlowski wrote: > MAX14577 chip is a multi-function device which includes MUIC, > charger and voltage regulator. The driver is located in drivers/mfd. > > This patch adds regulator driver for MAX14577 chip. There are two > regulators in this chip: > 1. Safeout LDO

Re: [PATCH v3 4/5] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-22 Thread Krzysztof Kozlowski
On Fri, 2013-11-22 at 09:16 +, Lee Jones wrote: (...) > On Fri, 22 Nov 2013, Krzysztof Kozlowski wrote: > > --- a/include/linux/mfd/max14577.h > > +++ b/include/linux/mfd/max14577.h > > @@ -63,7 +63,6 @@ struct max14577_platform_data { > > > > int (*set_gpio_pogo_cb) (int new_dev); > >

Re: [PATCH v3 4/5] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-22 Thread Lee Jones
On Fri, 22 Nov 2013, Krzysztof Kozlowski wrote: > MAX14577 chip is a multi-function device which includes MUIC, > charger and voltage regulator. The driver is located in drivers/mfd. > > This patch adds regulator driver for MAX14577 chip. There are two > regulators in this chip: > 1. Safeout LDO

[PATCH v3 4/5] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-22 Thread Krzysztof Kozlowski
MAX14577 chip is a multi-function device which includes MUIC, charger and voltage regulator. The driver is located in drivers/mfd. This patch adds regulator driver for MAX14577 chip. There are two regulators in this chip: 1. Safeout LDO with constant voltage output of 4.9V. It can be only enabl