Re: [PATCH v3 4/5] toshiba_acpi: Remove unnecessary checks and returns in HCI/SCI functions

2015-08-06 Thread Darren Hart
On Thu, Aug 06, 2015 at 10:21:15AM -0600, Azael Avalos wrote: > Hi Darren, > > 2015-08-05 17:21 GMT-06:00 Darren Hart : > > On Wed, Aug 05, 2015 at 04:23:49PM -0600, Azael Avalos wrote: > >> Hi Darren, > >> > >> 2015-08-05 14:21 GMT-06:00 Darren Hart : > >> >> @@ -1131,14 +1055,10 @@ static int

Re: [PATCH v3 4/5] toshiba_acpi: Remove unnecessary checks and returns in HCI/SCI functions

2015-08-06 Thread Azael Avalos
Hi Darren, 2015-08-05 17:21 GMT-06:00 Darren Hart : > On Wed, Aug 05, 2015 at 04:23:49PM -0600, Azael Avalos wrote: >> Hi Darren, >> >> 2015-08-05 14:21 GMT-06:00 Darren Hart : >> >> @@ -1131,14 +1055,10 @@ static int toshiba_usb_three_set(struct >> >> toshiba_acpi_dev *dev, u32 state) >> >> >>

Re: [PATCH v3 4/5] toshiba_acpi: Remove unnecessary checks and returns in HCI/SCI functions

2015-08-06 Thread Darren Hart
On Thu, Aug 06, 2015 at 10:21:15AM -0600, Azael Avalos wrote: Hi Darren, 2015-08-05 17:21 GMT-06:00 Darren Hart dvh...@infradead.org: On Wed, Aug 05, 2015 at 04:23:49PM -0600, Azael Avalos wrote: Hi Darren, 2015-08-05 14:21 GMT-06:00 Darren Hart dvh...@infradead.org: @@ -1131,14

Re: [PATCH v3 4/5] toshiba_acpi: Remove unnecessary checks and returns in HCI/SCI functions

2015-08-06 Thread Azael Avalos
Hi Darren, 2015-08-05 17:21 GMT-06:00 Darren Hart dvh...@infradead.org: On Wed, Aug 05, 2015 at 04:23:49PM -0600, Azael Avalos wrote: Hi Darren, 2015-08-05 14:21 GMT-06:00 Darren Hart dvh...@infradead.org: @@ -1131,14 +1055,10 @@ static int toshiba_usb_three_set(struct toshiba_acpi_dev

Re: [PATCH v3 4/5] toshiba_acpi: Remove unnecessary checks and returns in HCI/SCI functions

2015-08-05 Thread Darren Hart
On Wed, Aug 05, 2015 at 04:23:49PM -0600, Azael Avalos wrote: > Hi Darren, > > 2015-08-05 14:21 GMT-06:00 Darren Hart : > >> @@ -1131,14 +1055,10 @@ static int toshiba_usb_three_set(struct > >> toshiba_acpi_dev *dev, u32 state) > >> > >> result = sci_write(dev, SCI_USB_THREE, state); > >>

Re: [PATCH v3 4/5] toshiba_acpi: Remove unnecessary checks and returns in HCI/SCI functions

2015-08-05 Thread Azael Avalos
Hi Darren, 2015-08-05 14:21 GMT-06:00 Darren Hart : >> @@ -1131,14 +1055,10 @@ static int toshiba_usb_three_set(struct >> toshiba_acpi_dev *dev, u32 state) >> >> result = sci_write(dev, SCI_USB_THREE, state); >> sci_close(dev); >> - if (result == TOS_FAILURE) { >> + if

Re: [PATCH v3 4/5] toshiba_acpi: Remove unnecessary checks and returns in HCI/SCI functions

2015-08-05 Thread Darren Hart
> @@ -1131,14 +1055,10 @@ static int toshiba_usb_three_set(struct > toshiba_acpi_dev *dev, u32 state) > > result = sci_write(dev, SCI_USB_THREE, state); > sci_close(dev); > - if (result == TOS_FAILURE) { > + if (result == TOS_FAILURE) > pr_err("ACPI call to set

Re: [PATCH v3 4/5] toshiba_acpi: Remove unnecessary checks and returns in HCI/SCI functions

2015-08-05 Thread Darren Hart
@@ -1131,14 +1055,10 @@ static int toshiba_usb_three_set(struct toshiba_acpi_dev *dev, u32 state) result = sci_write(dev, SCI_USB_THREE, state); sci_close(dev); - if (result == TOS_FAILURE) { + if (result == TOS_FAILURE) pr_err(ACPI call to set USB 3

Re: [PATCH v3 4/5] toshiba_acpi: Remove unnecessary checks and returns in HCI/SCI functions

2015-08-05 Thread Darren Hart
On Wed, Aug 05, 2015 at 04:23:49PM -0600, Azael Avalos wrote: Hi Darren, 2015-08-05 14:21 GMT-06:00 Darren Hart dvh...@infradead.org: @@ -1131,14 +1055,10 @@ static int toshiba_usb_three_set(struct toshiba_acpi_dev *dev, u32 state) result = sci_write(dev, SCI_USB_THREE, state);

Re: [PATCH v3 4/5] toshiba_acpi: Remove unnecessary checks and returns in HCI/SCI functions

2015-08-05 Thread Azael Avalos
Hi Darren, 2015-08-05 14:21 GMT-06:00 Darren Hart dvh...@infradead.org: @@ -1131,14 +1055,10 @@ static int toshiba_usb_three_set(struct toshiba_acpi_dev *dev, u32 state) result = sci_write(dev, SCI_USB_THREE, state); sci_close(dev); - if (result == TOS_FAILURE) { + if

[PATCH v3 4/5] toshiba_acpi: Remove unnecessary checks and returns in HCI/SCI functions

2015-07-31 Thread Azael Avalos
A previous patch added explicit feature checks for support, *SUCCESS* and *FAILURE to the HCI/SCI *{get, set} functions. This patch removes some unnedded checks to the driver HCI/SCI functions given that the default error return value is now set to -EIO, there is no need to check for other error

[PATCH v3 4/5] toshiba_acpi: Remove unnecessary checks and returns in HCI/SCI functions

2015-07-31 Thread Azael Avalos
A previous patch added explicit feature checks for support, *SUCCESS* and *FAILURE to the HCI/SCI *{get, set} functions. This patch removes some unnedded checks to the driver HCI/SCI functions given that the default error return value is now set to -EIO, there is no need to check for other error