RE: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in arch specific directory
Hi David > -Original Message- > From: David Hildenbrand > Sent: Thursday, July 9, 2020 5:19 PM > To: Mike Rapoport ; Matthew Wilcox > > Cc: Justin He ; Catalin Marinas > ; Will Deacon ; Tony Luck > ; Fenghua Yu ; Yoshinori Sato > ; Rich Felker ; Dave Hansen > ; Andy Lutomirski ; Peter > Zijlstra ; Thomas Gleixner ; > Ingo Molnar ; Borislav Petkov ; > x...@kernel.org; H. Peter Anvin ; Dan Williams > ; Vishal Verma ; Dave > Jiang ; Andrew Morton ; > Baoquan He ; Chuhong Yuan ; Logan > Gunthorpe ; Masahiro Yamada ; > Michal Hocko ; linux-arm-ker...@lists.infradead.org; > linux-kernel@vger.kernel.org; linux-i...@vger.kernel.org; linux- > s...@vger.kernel.org; linux-nvd...@lists.01.org; linux...@kvack.org; > Jonathan Cameron ; Kaly Xin > Subject: Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in > arch specific directory > > On 09.07.20 11:18, Mike Rapoport wrote: > > On Thu, Jul 09, 2020 at 03:11:04AM +0100, Matthew Wilcox wrote: > >> On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote: > >>> After a general version of __weak memory_add_physaddr_to_nid > implemented > >>> and exported , it is no use exporting twice in arch directory even if > >>> e,g, ia64/x86 have their specific version. > >>> > >>> This is to suppress the modpost warning: > >>> WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice. > >>> Previous export was in vmlinux > >> > >> It's bad form to introduce a warning and then send a follow-up patch to > >> fix the warning. Just fold this patch into patch 1/6. > > > > Moreover, I think that patches 1-4 can be merged into one. > > > > +1 Okay, will update, thanks -- Cheers, Justin (Jia He)
Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in arch specific directory
On Thu, Jul 09, 2020 at 03:11:04AM +0100, Matthew Wilcox wrote: > On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote: > > After a general version of __weak memory_add_physaddr_to_nid implemented > > and exported , it is no use exporting twice in arch directory even if > > e,g, ia64/x86 have their specific version. > > > > This is to suppress the modpost warning: > > WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice. > > Previous export was in vmlinux > > It's bad form to introduce a warning and then send a follow-up patch to > fix the warning. Just fold this patch into patch 1/6. Moreover, I think that patches 1-4 can be merged into one. -- Sincerely yours, Mike.
Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in arch specific directory
On 09.07.20 11:18, Mike Rapoport wrote: > On Thu, Jul 09, 2020 at 03:11:04AM +0100, Matthew Wilcox wrote: >> On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote: >>> After a general version of __weak memory_add_physaddr_to_nid implemented >>> and exported , it is no use exporting twice in arch directory even if >>> e,g, ia64/x86 have their specific version. >>> >>> This is to suppress the modpost warning: >>> WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice. >>> Previous export was in vmlinux >> >> It's bad form to introduce a warning and then send a follow-up patch to >> fix the warning. Just fold this patch into patch 1/6. > > Moreover, I think that patches 1-4 can be merged into one. > +1 -- Thanks, David / dhildenb
RE: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in arch specific directory
Hi Matthew > -Original Message- > From: Matthew Wilcox > Sent: Thursday, July 9, 2020 10:11 AM > To: Justin He > Cc: Catalin Marinas ; Will Deacon > ; Tony Luck ; Fenghua Yu > ; Yoshinori Sato ; Rich > Felker ; Dave Hansen ; Andy > Lutomirski ; Peter Zijlstra ; > Thomas Gleixner ; Ingo Molnar ; > Borislav Petkov ; David Hildenbrand ; > x...@kernel.org; H. Peter Anvin ; Dan Williams > ; Vishal Verma ; Dave > Jiang ; Andrew Morton ; > Baoquan He ; Chuhong Yuan ; Mike > Rapoport ; Logan Gunthorpe ; > Masahiro Yamada ; Michal Hocko ; > linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; linux- > i...@vger.kernel.org; linux...@vger.kernel.org; linux-nvd...@lists.01.org; > linux...@kvack.org; Jonathan Cameron ; Kaly > Xin > Subject: Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in > arch specific directory > > On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote: > > After a general version of __weak memory_add_physaddr_to_nid implemented > > and exported , it is no use exporting twice in arch directory even if > > e,g, ia64/x86 have their specific version. > > > > This is to suppress the modpost warning: > > WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice. > > Previous export was in vmlinux > > It's bad form to introduce a warning and then send a follow-up patch to > fix the warning. Just fold this patch into patch 1/6. Thanks, will do Cheers, Justin He
Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in arch specific directory
On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote: > After a general version of __weak memory_add_physaddr_to_nid implemented > and exported , it is no use exporting twice in arch directory even if > e,g, ia64/x86 have their specific version. > > This is to suppress the modpost warning: > WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice. > Previous export was in vmlinux It's bad form to introduce a warning and then send a follow-up patch to fix the warning. Just fold this patch into patch 1/6.
[PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in arch specific directory
After a general version of __weak memory_add_physaddr_to_nid implemented and exported , it is no use exporting twice in arch directory even if e,g, ia64/x86 have their specific version. This is to suppress the modpost warning: WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice. Previous export was in vmlinux Suggested-by: David Hildenbrand Signed-off-by: Jia He --- arch/ia64/mm/numa.c | 2 -- arch/x86/mm/numa.c | 1 - 2 files changed, 3 deletions(-) diff --git a/arch/ia64/mm/numa.c b/arch/ia64/mm/numa.c index 5e1015eb6d0d..f34964271101 100644 --- a/arch/ia64/mm/numa.c +++ b/arch/ia64/mm/numa.c @@ -106,7 +106,5 @@ int memory_add_physaddr_to_nid(u64 addr) return 0; return nid; } - -EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid); #endif #endif diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c index 8ee952038c80..2a6e62af4636 100644 --- a/arch/x86/mm/numa.c +++ b/arch/x86/mm/numa.c @@ -929,5 +929,4 @@ int memory_add_physaddr_to_nid(u64 start) nid = numa_meminfo.blk[0].nid; return nid; } -EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid); #endif -- 2.17.1
