Re: [PATCH v3 5/6] dt-bindings: i2c: Add Mediatek MT8183 i2c binding

2019-02-19 Thread Wolfram Sang
> > > Maybe you think that MT8183 SoC only has the I3C controllers. Actually, > > > there are I2C and I3C controllers on MT8183 SoC. We will remove > > > "mediatek,share-i3c" for I2C controller driver, so these patches are > > > just to support the I2C controllers on MT8183 SoC. For the I3C > > >

Re: [PATCH v3 5/6] dt-bindings: i2c: Add Mediatek MT8183 i2c binding

2019-02-19 Thread Qii Wang
On Sat, 2019-02-16 at 13:29 +0100, Wolfram Sang wrote: > > Maybe you think that MT8183 SoC only has the I3C controllers. Actually, > > there are I2C and I3C controllers on MT8183 SoC. We will remove > > "mediatek,share-i3c" for I2C controller driver, so these patches are > > just to support the

Re: [PATCH v3 5/6] dt-bindings: i2c: Add Mediatek MT8183 i2c binding

2019-02-16 Thread Wolfram Sang
> Maybe you think that MT8183 SoC only has the I3C controllers. Actually, > there are I2C and I3C controllers on MT8183 SoC. We will remove > "mediatek,share-i3c" for I2C controller driver, so these patches are > just to support the I2C controllers on MT8183 SoC. For the I3C > controller we will

Re: [PATCH v3 5/6] dt-bindings: i2c: Add Mediatek MT8183 i2c binding

2019-02-16 Thread Qii Wang
On Fri, 2019-02-15 at 10:02 +0100, Wolfram Sang wrote: > On Thu, Feb 14, 2019 at 09:54:28AM +0800, Qii Wang wrote: > > On Tue, 2019-02-05 at 14:16 +0100, Wolfram Sang wrote: > > > > + - mediatek,share-i3c: i3c controller can share i2c function. > > > > > > I am not happy with this binding. There

Re: [PATCH v3 5/6] dt-bindings: i2c: Add Mediatek MT8183 i2c binding

2019-02-15 Thread Wolfram Sang
On Thu, Feb 14, 2019 at 09:54:28AM +0800, Qii Wang wrote: > On Tue, 2019-02-05 at 14:16 +0100, Wolfram Sang wrote: > > > + - mediatek,share-i3c: i3c controller can share i2c function. > > > > I am not happy with this binding. There must be a better way of using > > the I3C controller in I2C

Re: [PATCH v3 5/6] dt-bindings: i2c: Add Mediatek MT8183 i2c binding

2019-02-13 Thread Qii Wang
On Tue, 2019-02-05 at 14:16 +0100, Wolfram Sang wrote: > > + - mediatek,share-i3c: i3c controller can share i2c function. > > I am not happy with this binding. There must be a better way of using > the I3C controller in I2C mode. I think it would be easier to tell if we > had an I3C driver to

Re: [PATCH v3 5/6] dt-bindings: i2c: Add Mediatek MT8183 i2c binding

2019-02-05 Thread Wolfram Sang
> + - mediatek,share-i3c: i3c controller can share i2c function. I am not happy with this binding. There must be a better way of using the I3C controller in I2C mode. I think it would be easier to tell if we had an I3C driver to see how it implements I2C fallback there. Is the I3C driver on the

[PATCH v3 5/6] dt-bindings: i2c: Add Mediatek MT8183 i2c binding

2019-01-21 Thread qii wang
Add MT8183 i2c binding to binding file. Compare to 2712 i2c controller, MT8183 has different registers, offsets, clock, and share i3c controller. Signed-off-by: qii wang Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/i2c/i2c-mtk.txt |6 -- 1 file changed, 4