Re: [PATCH v3 5/8] staging: rtl8192e: Fix unbalanced braces

As Dan said, the original was better, but it could still be improved. There is only a single case used in the switch. Perhaps better would be to reduce indentation by removing the switch and using another goto label for the memory allocation freeing like the below. Perhaps better still, if

Re: [PATCH v3 5/8] staging: rtl8192e: Fix unbalanced braces

As Dan said, the original was better, but it could still be improved. There is only a single case used in the switch. Perhaps better would be to reduce indentation by removing the switch and using another goto label for the memory allocation freeing like the below. Perhaps better still, if

Re: [PATCH v3 5/8] staging: rtl8192e: Fix unbalanced braces

On Wed, Mar 15, 2017 at 03:21:54PM +0530, suni...@techveda.org wrote: > @@ -2294,17 +2294,20 @@ static int _rtl92e_ioctl(struct net_device *dev, > struct ifreq *rq, int cmd) > > if (ipw->cmd == IEEE_CMD_SET_ENCRYPTION) { > if (ipw->u.crypt.set_tx) { > -

Re: [PATCH v3 5/8] staging: rtl8192e: Fix unbalanced braces

On Wed, Mar 15, 2017 at 03:21:54PM +0530, suni...@techveda.org wrote: > @@ -2294,17 +2294,20 @@ static int _rtl92e_ioctl(struct net_device *dev, > struct ifreq *rq, int cmd) > > if (ipw->cmd == IEEE_CMD_SET_ENCRYPTION) { > if (ipw->u.crypt.set_tx) { > -

[PATCH v3 5/8] staging: rtl8192e: Fix unbalanced braces

From: Suniel Mahesh Fixed unbalanced braces around else statement Add braces on all arms of the if-else statements to comply with kernel coding style. Signed-off-by: Suniel Mahesh --- Changes for v3: - Split earlier patches into multiple commits for

[PATCH v3 5/8] staging: rtl8192e: Fix unbalanced braces

From: Suniel Mahesh Fixed unbalanced braces around else statement Add braces on all arms of the if-else statements to comply with kernel coding style. Signed-off-by: Suniel Mahesh --- Changes for v3: - Split earlier patches into multiple commits for easy review as suggested by Greg K-H -