Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-17 Thread Lorenzo Pieralisi
On Tue, Apr 17, 2018 at 09:17:36AM +0200, Daniel Lezcano wrote: [...] > Actually there is no impact with the change Sudeep is referring to. It > is for ACPI, we are DT based. Confirmed with Jeremy. > > So AFAICT, it is not a problem. > >>> > >>> It is a problem - DT or ACPI

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-17 Thread Daniel Lezcano
On 16/04/2018 16:22, Lorenzo Pieralisi wrote: > On Mon, Apr 16, 2018 at 03:57:03PM +0200, Daniel Lezcano wrote: >> On 16/04/2018 14:30, Lorenzo Pieralisi wrote: >>> On Mon, Apr 16, 2018 at 02:10:30PM +0200, Daniel Lezcano wrote: On 16/04/2018 12:10, Viresh Kumar wrote: > On 16-04-18,

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-16 Thread Lorenzo Pieralisi
On Mon, Apr 16, 2018 at 03:57:03PM +0200, Daniel Lezcano wrote: > On 16/04/2018 14:30, Lorenzo Pieralisi wrote: > > On Mon, Apr 16, 2018 at 02:10:30PM +0200, Daniel Lezcano wrote: > >> On 16/04/2018 12:10, Viresh Kumar wrote: > >>> On 16-04-18, 12:03, Daniel Lezcano wrote: > On 16/04/2018

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-16 Thread Daniel Lezcano
On 16/04/2018 14:30, Lorenzo Pieralisi wrote: > On Mon, Apr 16, 2018 at 02:10:30PM +0200, Daniel Lezcano wrote: >> On 16/04/2018 12:10, Viresh Kumar wrote: >>> On 16-04-18, 12:03, Daniel Lezcano wrote: On 16/04/2018 11:50, Viresh Kumar wrote: > On 16-04-18, 11:45, Daniel Lezcano wrote:

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-16 Thread Sudeep Holla
On Mon, Apr 16, 2018 at 02:49:35PM +0200, Daniel Lezcano wrote: > On 16/04/2018 14:31, Sudeep Holla wrote: > > On Mon, Apr 16, 2018 at 02:10:30PM +0200, Daniel Lezcano wrote: > >> On 16/04/2018 12:10, Viresh Kumar wrote: > >>> On 16-04-18, 12:03, Daniel Lezcano wrote: > On 16/04/2018 11:50,

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-16 Thread Daniel Lezcano
On 16/04/2018 14:31, Sudeep Holla wrote: > On Mon, Apr 16, 2018 at 02:10:30PM +0200, Daniel Lezcano wrote: >> On 16/04/2018 12:10, Viresh Kumar wrote: >>> On 16-04-18, 12:03, Daniel Lezcano wrote: On 16/04/2018 11:50, Viresh Kumar wrote: > On 16-04-18, 11:45, Daniel Lezcano wrote: >>

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-16 Thread Sudeep Holla
On Mon, Apr 16, 2018 at 02:10:30PM +0200, Daniel Lezcano wrote: > On 16/04/2018 12:10, Viresh Kumar wrote: > > On 16-04-18, 12:03, Daniel Lezcano wrote: > >> On 16/04/2018 11:50, Viresh Kumar wrote: > >>> On 16-04-18, 11:45, Daniel Lezcano wrote: > Can you elaborate a bit ? I'm not sure to

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-16 Thread Lorenzo Pieralisi
On Mon, Apr 16, 2018 at 02:10:30PM +0200, Daniel Lezcano wrote: > On 16/04/2018 12:10, Viresh Kumar wrote: > > On 16-04-18, 12:03, Daniel Lezcano wrote: > >> On 16/04/2018 11:50, Viresh Kumar wrote: > >>> On 16-04-18, 11:45, Daniel Lezcano wrote: > Can you elaborate a bit ? I'm not sure to

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-16 Thread Sudeep Holla
On Mon, Apr 16, 2018 at 03:20:06PM +0530, Viresh Kumar wrote: > On 16-04-18, 11:45, Daniel Lezcano wrote: > > Can you elaborate a bit ? I'm not sure to get the point. > > Sure. With your current code on Hikey960 (big/LITTLE), you end up > creating two cooling devices, one for the big cluster and

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-16 Thread Daniel Lezcano
On 16/04/2018 12:10, Viresh Kumar wrote: > On 16-04-18, 12:03, Daniel Lezcano wrote: >> On 16/04/2018 11:50, Viresh Kumar wrote: >>> On 16-04-18, 11:45, Daniel Lezcano wrote: Can you elaborate a bit ? I'm not sure to get the point. >>> >>> Sure. With your current code on Hikey960

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-16 Thread Viresh Kumar
On 16-04-18, 12:03, Daniel Lezcano wrote: > On 16/04/2018 11:50, Viresh Kumar wrote: > > On 16-04-18, 11:45, Daniel Lezcano wrote: > >> Can you elaborate a bit ? I'm not sure to get the point. > > > > Sure. With your current code on Hikey960 (big/LITTLE), you end up > > creating two cooling

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-16 Thread Daniel Lezcano
On 16/04/2018 11:50, Viresh Kumar wrote: > On 16-04-18, 11:45, Daniel Lezcano wrote: >> Can you elaborate a bit ? I'm not sure to get the point. > > Sure. With your current code on Hikey960 (big/LITTLE), you end up > creating two cooling devices, one for the big cluster and one for > small

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-16 Thread Viresh Kumar
On 16-04-18, 11:45, Daniel Lezcano wrote: > Can you elaborate a bit ? I'm not sure to get the point. Sure. With your current code on Hikey960 (big/LITTLE), you end up creating two cooling devices, one for the big cluster and one for small cluster. Which is the right thing to do, as we also have

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-16 Thread Daniel Lezcano
On 16/04/2018 11:37, Viresh Kumar wrote: > On 16-04-18, 09:44, Daniel Lezcano wrote: >> Because we rely on the number to identify the cluster and flag it >> 'processed'. The number itself is not important. > > It is, because you are creating multiple groups (like cpufreq > policies) right now

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-16 Thread Viresh Kumar
On 16-04-18, 09:44, Daniel Lezcano wrote: > Because we rely on the number to identify the cluster and flag it > 'processed'. The number itself is not important. It is, because you are creating multiple groups (like cpufreq policies) right now based on cluster id. Which will be zero for all the

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-16 Thread Sudeep Holla
On Mon, Apr 16, 2018 at 09:44:51AM +0200, Daniel Lezcano wrote: > On 16/04/2018 09:37, Viresh Kumar wrote: > > On 13-04-18, 13:47, Daniel Lezcano wrote: > >> Ok, noted. At the first glance, it should not be a problem. > > > > Why do you think it wouldn't be a problem ? > > Because we rely on the

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-16 Thread Daniel Lezcano
On 16/04/2018 09:37, Viresh Kumar wrote: > On 13-04-18, 13:47, Daniel Lezcano wrote: >> Ok, noted. At the first glance, it should not be a problem. > > Why do you think it wouldn't be a problem ? Because we rely on the number to identify the cluster and flag it 'processed'. The number itself is

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-16 Thread Viresh Kumar
On 13-04-18, 13:47, Daniel Lezcano wrote: > Ok, noted. At the first glance, it should not be a problem. Why do you think it wouldn't be a problem ? -- viresh

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-13 Thread Daniel Lezcano
On 13/04/2018 13:23, Sudeep Holla wrote: > Hi Daniel, > > On 05/04/18 17:16, Daniel Lezcano wrote: > > [...] > >> +/** >> + * cpuidle_cooling_register - Idle cooling device initialization function >> + * >> + * This function is in charge of creating a cooling device per cluster >> + * and

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-13 Thread Daniel Lezcano
On 13/04/2018 13:38, Daniel Thompson wrote: [ ... ] >> +/* >> + * Allocate the cpuidle cooling device with the list >> + * of the cpus belonging to the cluster. >> + */ >> +idle_cdev = cpuidle_cooling_alloc(topology_core_cpumask(cpu));

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-13 Thread Daniel Thompson
On Thu, Apr 05, 2018 at 06:16:43PM +0200, Daniel Lezcano wrote: > +/** > + * cpuidle_cooling_register - Idle cooling device initialization function > + * > + * This function is in charge of creating a cooling device per cluster > + * and register it to thermal framework. For this we rely on the >

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-13 Thread Sudeep Holla
Hi Daniel, On 05/04/18 17:16, Daniel Lezcano wrote: [...] > +/** > + * cpuidle_cooling_register - Idle cooling device initialization function > + * > + * This function is in charge of creating a cooling device per cluster > + * and register it to thermal framework. For this we rely on the > + *

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-11 Thread Daniel Lezcano
Hi Viresh, thanks for the review. On 11/04/2018 10:51, Viresh Kumar wrote: [ ... ] >> +void __init cpuidle_cooling_register(void) >> +{ >> +struct cpuidle_cooling_device *idle_cdev = NULL; >> +struct thermal_cooling_device *cdev; >> +struct device_node *np; >> +cpumask_var_t

Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-11 Thread Viresh Kumar
On 05-04-18, 18:16, Daniel Lezcano wrote: > The cpu idle cooling driver performs synchronized idle injection across all > cpus belonging to the same cluster and offers a new method to cool down a SoC. > > Each cluster has its own idle cooling device, each core has its own idle > injection thread,

[PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-05 Thread Daniel Lezcano
The cpu idle cooling driver performs synchronized idle injection across all cpus belonging to the same cluster and offers a new method to cool down a SoC. Each cluster has its own idle cooling device, each core has its own idle injection thread, each idle injection thread uses play_idle to enter