Re: [PATCH v3 7/8] KVM:X86: Add XSS bit 11 and 12 support for CET xsaves/xrstors.

2019-03-13 Thread Yang Weijiang
On Mon, Mar 11, 2019 at 04:32:32PM +0100, Paolo Bonzini wrote: > On 10/03/19 14:35, Yang Weijiang wrote: > -if (data != 0) > +if (data & ~kvm_supported_xss()) > return 1; > >>> You should instead check this against CPUID[0xD,

Re: [PATCH v3 7/8] KVM:X86: Add XSS bit 11 and 12 support for CET xsaves/xrstors.

2019-03-11 Thread Paolo Bonzini
On 10/03/19 14:35, Yang Weijiang wrote: - if (data != 0) + if (data & ~kvm_supported_xss()) return 1; >>> You should instead check this against CPUID[0xD, 1].EDX:ECX. If CET is >>> disabled in CPUID, the guest should not be able to set it in

Re: [PATCH v3 7/8] KVM:X86: Add XSS bit 11 and 12 support for CET xsaves/xrstors.

2019-03-11 Thread Yang Weijiang
On Sun, Mar 10, 2019 at 08:20:30PM +0800, Yang Weijiang wrote: > On Fri, Mar 08, 2019 at 12:32:04PM +0100, Paolo Bonzini wrote: > > On 28/02/19 09:44, Yang Weijiang wrote: > > >>> if (!vmx_xsaves_supported()) > > >>> return 1; > > >>> + > > >>>

Re: [PATCH v3 7/8] KVM:X86: Add XSS bit 11 and 12 support for CET xsaves/xrstors.

2019-03-10 Thread Yang Weijiang
On Fri, Mar 08, 2019 at 12:32:04PM +0100, Paolo Bonzini wrote: > On 28/02/19 09:44, Yang Weijiang wrote: > >>> if (!vmx_xsaves_supported()) > >>> return 1; > >>> + > >>> /* > >>> - * The only supported bit as of Skylake is bit 8, but > >>> -

RE: [PATCH v3 7/8] KVM:X86: Add XSS bit 11 and 12 support for CET xsaves/xrstors.

2019-03-10 Thread Kang, Luwei
> > For Guest XSS, right now, only bit 11(user states) and bit 12 > > (supervisor states) are supported, if other bits are being set, need > > to modify KVM_SUPPORTED_XSS macro to have support. > > > > Signed-off-by: Zhang Yi Z > > Signed-off-by: Yang Weijiang > > --- > > arch/x86/kvm/vmx.c | 8

Re: [PATCH v3 7/8] KVM:X86: Add XSS bit 11 and 12 support for CET xsaves/xrstors.

2019-03-08 Thread Paolo Bonzini
On 28/02/19 09:44, Yang Weijiang wrote: >>> if (!vmx_xsaves_supported()) >>> return 1; >>> + >>> /* >>> -* The only supported bit as of Skylake is bit 8, but >>> -* it is not supported on KVM. >>> +* Check bits being

Re: [PATCH v3 7/8] KVM:X86: Add XSS bit 11 and 12 support for CET xsaves/xrstors.

2019-03-08 Thread Paolo Bonzini
On 25/02/19 14:27, Yang Weijiang wrote: > For Guest XSS, right now, only bit 11(user states) and bit 12 > (supervisor states) are supported, if other bits are being set, > need to modify KVM_SUPPORTED_XSS macro to have support. > > Signed-off-by: Zhang Yi Z > Signed-off-by: Yang Weijiang > ---

Re: [PATCH v3 7/8] KVM:X86: Add XSS bit 11 and 12 support for CET xsaves/xrstors.

2019-02-28 Thread Yang Weijiang
On Thu, Feb 28, 2019 at 08:25:12AM -0800, Sean Christopherson wrote: > On Mon, Feb 25, 2019 at 09:27:15PM +0800, Yang Weijiang wrote: > > For Guest XSS, right now, only bit 11(user states) and bit 12 > > (supervisor states) are supported, if other bits are being set, > > need to modify

Re: [PATCH v3 7/8] KVM:X86: Add XSS bit 11 and 12 support for CET xsaves/xrstors.

2019-02-28 Thread Sean Christopherson
On Mon, Feb 25, 2019 at 09:27:15PM +0800, Yang Weijiang wrote: > For Guest XSS, right now, only bit 11(user states) and bit 12 > (supervisor states) are supported, if other bits are being set, > need to modify KVM_SUPPORTED_XSS macro to have support. The changelog should describe what the change

[PATCH v3 7/8] KVM:X86: Add XSS bit 11 and 12 support for CET xsaves/xrstors.

2019-02-25 Thread Yang Weijiang
For Guest XSS, right now, only bit 11(user states) and bit 12 (supervisor states) are supported, if other bits are being set, need to modify KVM_SUPPORTED_XSS macro to have support. Signed-off-by: Zhang Yi Z Signed-off-by: Yang Weijiang --- arch/x86/kvm/vmx.c | 8 +--- 1 file changed, 5