Re: [PATCH v3 lora-next 5/5] net: lora: sx125x sx1301: allow radio to register as a clk provider

2019-01-03 Thread Mark Brown
On Wed, Jan 02, 2019 at 01:44:40AM +0100, Andreas Färber wrote: > So, the third invocation of sun6i_transfer_one() calling clk_get_rate() > hangs at the prepare_lock instead of reference-counting, because it runs > from a separate kthread, unlike the two previous calls? If there's any

Re: [PATCH v3 lora-next 5/5] net: lora: sx125x sx1301: allow radio to register as a clk provider

2019-01-01 Thread Andreas Färber
Am 31.12.18 um 23:56 schrieb Andreas Färber: > Am 31.12.18 um 18:50 schrieb Mark Brown: >> On Sun, Dec 30, 2018 at 11:55:46AM +0100, Andreas Färber wrote: >>> Given that observed symptoms were CPU stalls, workqueue hangs and RCU >>> problems, requiring a power-cycle to recover, I wonder whether we

Re: [PATCH v3 lora-next 5/5] net: lora: sx125x sx1301: allow radio to register as a clk provider

2018-12-31 Thread Andreas Färber
Am 31.12.18 um 18:50 schrieb Mark Brown: > On Sun, Dec 30, 2018 at 11:55:46AM +0100, Andreas Färber wrote: >> Given that observed symptoms were CPU stalls, workqueue hangs and RCU >> problems, requiring a power-cycle to recover, I wonder whether we are >> running into some atomic/locking issue

Re: [PATCH v3 lora-next 5/5] net: lora: sx125x sx1301: allow radio to register as a clk provider

2018-12-31 Thread Mark Brown
On Sun, Dec 30, 2018 at 11:55:46AM +0100, Andreas Färber wrote: > + linux-spi, LAKML > Given that observed symptoms were CPU stalls, workqueue hangs and RCU > problems, requiring a power-cycle to recover, I wonder whether we are > running into some atomic/locking issue with clk_enable()? Is it

Re: [PATCH v3 lora-next 5/5] net: lora: sx125x sx1301: allow radio to register as a clk provider

2018-12-31 Thread Andreas Färber
Am 30.12.18 um 11:55 schrieb Andreas Färber: > Am 29.12.18 um 21:16 schrieb Andreas Färber: >> `sudo ip link set lora2 up` froze my system, with both >> lora1 and lora2 being sx1301. [...] >> >> Investigating... > > I've bisected and confirmed that it was indeed this patch that regresses > for

Re: [PATCH v3 lora-next 5/5] net: lora: sx125x sx1301: allow radio to register as a clk provider

2018-12-30 Thread Andreas Färber
+ linux-spi, LAKML Am 29.12.18 um 21:16 schrieb Andreas Färber: > Am 29.12.18 um 20:25 schrieb Andreas Färber: >> Am 12.10.18 um 18:26 schrieb Ben Whitten: >>> +static int sx125x_register_clock_provider(struct sx125x_priv *priv) >>> +{ >>> + struct device *dev = priv->dev; >>> + struct

Re: [PATCH v3 lora-next 5/5] net: lora: sx125x sx1301: allow radio to register as a clk provider

2018-12-29 Thread Andreas Färber
Am 29.12.18 um 20:25 schrieb Andreas Färber: > Am 12.10.18 um 18:26 schrieb Ben Whitten: >> +static int sx125x_register_clock_provider(struct sx125x_priv *priv) >> +{ >> +struct device *dev = priv->dev; >> +struct clk_init_data init; >> +const char *parent; >> +int ret; >> + >> +

Re: [PATCH v3 lora-next 5/5] net: lora: sx125x sx1301: allow radio to register as a clk provider

2018-12-29 Thread Andreas Färber
Hi Ben, + linux-lpwan, linux-clk, devicetree Am 12.10.18 um 18:26 schrieb Ben Whitten: > From: Ben Whitten > > The 32M is run from the radio, before we just enabled it based on > the radio number but now we can use the clk framework to request the > clk is started when we need it. > > The 32M