Re: [PATCH v3.1 11/21] ARM: pxa: support ICP DAS LP-8x4x FPGA irq

2014-01-14 Thread Linus Walleij
This is looking much better! On Fri, Jan 10, 2014 at 12:07 AM, Sergei Ianovich wrote: > +++ b/drivers/irqchip/irq-lp8x4x.c (...) You could add some kerneldoc to this following struct (OK nitpick, but still nice, especially for the last two variables). > +struct lp8x4x_irq_data { > +

Re: [PATCH v3.1 11/21] ARM: pxa: support ICP DAS LP-8x4x FPGA irq

2014-01-14 Thread Linus Walleij
This is looking much better! On Fri, Jan 10, 2014 at 12:07 AM, Sergei Ianovich ynv...@gmail.com wrote: +++ b/drivers/irqchip/irq-lp8x4x.c (...) You could add some kerneldoc to this following struct (OK nitpick, but still nice, especially for the last two variables). +struct lp8x4x_irq_data {

[PATCH v3.1 11/21] ARM: pxa: support ICP DAS LP-8x4x FPGA irq

2014-01-09 Thread Sergei Ianovich
ICP DAS LP-8x4x contains FPGA chip. The chip functions as an interrupt source providing 16 additional interrupts among other things. The interrupt lines are muxed to a GPIO pin of a 2nd level PXA-GPIO interrupt controller. GPIO pins of the 2nd level controller are in turn muxed to a CPU interrupt

[PATCH v3.1 11/21] ARM: pxa: support ICP DAS LP-8x4x FPGA irq

2014-01-09 Thread Sergei Ianovich
ICP DAS LP-8x4x contains FPGA chip. The chip functions as an interrupt source providing 16 additional interrupts among other things. The interrupt lines are muxed to a GPIO pin of a 2nd level PXA-GPIO interrupt controller. GPIO pins of the 2nd level controller are in turn muxed to a CPU interrupt