Re: [PATCH v4] [media] pci: Add tw5864 driver - fixed few style nits, going to resubmit soon

2016-07-13 Thread Hans Verkuil
On 07/13/2016 04:05 AM, Andrey Utkin wrote: > Found and fixed few very minor coding style nits, will resubmit in few days, > now still waiting for comments to v4. Can you resubmit now? I plan to review it on Friday or Monday, and I'd rather review the latest version. Regards, Hans > >

Re: [PATCH v4] [media] pci: Add tw5864 driver - fixed few style nits, going to resubmit soon

2016-07-13 Thread Hans Verkuil
On 07/13/2016 04:05 AM, Andrey Utkin wrote: > Found and fixed few very minor coding style nits, will resubmit in few days, > now still waiting for comments to v4. Can you resubmit now? I plan to review it on Friday or Monday, and I'd rather review the latest version. Regards, Hans > >

Re: [PATCH v4] [media] pci: Add tw5864 driver - fixed few style nits, going to resubmit soon

2016-07-12 Thread Andrey Utkin
Found and fixed few very minor coding style nits, will resubmit in few days, now still waiting for comments to v4. https://github.com/bluecherrydvr/linux/commits/tw5864 commit 31f7c98a144cb3fb8a94662f002d9b6142d1f390 Author: Andrey Utkin Date: Wed Jul 13

Re: [PATCH v4] [media] pci: Add tw5864 driver - fixed few style nits, going to resubmit soon

2016-07-12 Thread Andrey Utkin
Found and fixed few very minor coding style nits, will resubmit in few days, now still waiting for comments to v4. https://github.com/bluecherrydvr/linux/commits/tw5864 commit 31f7c98a144cb3fb8a94662f002d9b6142d1f390 Author: Andrey Utkin Date: Wed Jul 13 05:00:28 2016 +0300 Fix

Re: [PATCH v4] [media] pci: Add tw5864 driver

2016-07-12 Thread Andrey Utkin
On Mon, Jul 11, 2016 at 09:40:53AM -0700, Joe Perches wrote: > Each of these blocks will start with the dev_ prefix > and the subsequent lines will not have the same prefix Yes. I have checked how it looks before submitting, but I didn't see this as a problem. I don't mind changing that (anyway I

Re: [PATCH v4] [media] pci: Add tw5864 driver

2016-07-12 Thread Andrey Utkin
On Mon, Jul 11, 2016 at 09:40:53AM -0700, Joe Perches wrote: > Each of these blocks will start with the dev_ prefix > and the subsequent lines will not have the same prefix Yes. I have checked how it looks before submitting, but I didn't see this as a problem. I don't mind changing that (anyway I

Re: [PATCH v4] [media] pci: Add tw5864 driver

2016-07-11 Thread Joe Perches
On Mon, 2016-07-11 at 18:17 +0300, Andrey Utkin wrote: [] > diff --git a/drivers/media/pci/tw5864/tw5864-core.c > b/drivers/media/pci/tw5864/tw5864-core.c [] > +static const char * const artifacts_warning = > +"BEWARE OF KNOWN ISSUES WITH VIDEO QUALITY\n" > +"\n" > +"This driver was developed by

Re: [PATCH v4] [media] pci: Add tw5864 driver

2016-07-11 Thread Joe Perches
On Mon, 2016-07-11 at 18:17 +0300, Andrey Utkin wrote: [] > diff --git a/drivers/media/pci/tw5864/tw5864-core.c > b/drivers/media/pci/tw5864/tw5864-core.c [] > +static const char * const artifacts_warning = > +"BEWARE OF KNOWN ISSUES WITH VIDEO QUALITY\n" > +"\n" > +"This driver was developed by