Re: [PATCH v4] ARM:dts:omap4-panda: Update the LED support for the panda DTS

2013-05-16 Thread Nishanth Menon
On Thu, May 16, 2013 at 3:22 PM, Dan Murphy wrote: > On 05/16/2013 01:18 PM, Nishanth Menon wrote: >> On Thu, May 16, 2013 at 10:35 AM, Dan Murphy wrote: >>> I am not sure you really want to do this. >>> If I make the pinctrl part of the led structure then the only way the >>> gpio_wk7 on a1-a3

Re: [PATCH v4] ARM:dts:omap4-panda: Update the LED support for the panda DTS

2013-05-16 Thread Dan Murphy
On 05/16/2013 01:18 PM, Nishanth Menon wrote: > On Thu, May 16, 2013 at 10:35 AM, Dan Murphy wrote: >> I am not sure you really want to do this. >> If I make the pinctrl part of the led structure then the only way the >> gpio_wk7 on a1-a3 to be configured is when >> the CONFIG_LEDS_GPIO flag is

Re: [PATCH v4] ARM:dts:omap4-panda: Update the LED support for the panda DTS

2013-05-16 Thread Nishanth Menon
On Thu, May 16, 2013 at 10:35 AM, Dan Murphy wrote: > I am not sure you really want to do this. > If I make the pinctrl part of the led structure then the only way the > gpio_wk7 on a1-a3 to be configured is when > the CONFIG_LEDS_GPIO flag is set. > > Do you really want that dependency? You

Re: [PATCH v4] ARM:dts:omap4-panda: Update the LED support for the panda DTS

2013-05-16 Thread Dan Murphy
On 05/15/2013 12:05 PM, Nishanth Menon wrote: > On 11:46-20130515, Dan Murphy wrote: >> The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es >> are different. >> >> A1-A3 = gpio_wk7 >> ES = gpio_110 >> >> There is no change to LED D2 >> >> Abstract away the pinmux and the LED

Re: [PATCH v4] ARM:dts:omap4-panda: Update the LED support for the panda DTS

2013-05-16 Thread Dan Murphy
On 05/15/2013 12:05 PM, Nishanth Menon wrote: On 11:46-20130515, Dan Murphy wrote: The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es are different. A1-A3 = gpio_wk7 ES = gpio_110 There is no change to LED D2 Abstract away the pinmux and the LED definitions for the

Re: [PATCH v4] ARM:dts:omap4-panda: Update the LED support for the panda DTS

2013-05-16 Thread Nishanth Menon
On Thu, May 16, 2013 at 10:35 AM, Dan Murphy dmur...@ti.com wrote: I am not sure you really want to do this. If I make the pinctrl part of the led structure then the only way the gpio_wk7 on a1-a3 to be configured is when the CONFIG_LEDS_GPIO flag is set. Do you really want that dependency?

Re: [PATCH v4] ARM:dts:omap4-panda: Update the LED support for the panda DTS

2013-05-16 Thread Dan Murphy
On 05/16/2013 01:18 PM, Nishanth Menon wrote: On Thu, May 16, 2013 at 10:35 AM, Dan Murphy dmur...@ti.com wrote: I am not sure you really want to do this. If I make the pinctrl part of the led structure then the only way the gpio_wk7 on a1-a3 to be configured is when the CONFIG_LEDS_GPIO

Re: [PATCH v4] ARM:dts:omap4-panda: Update the LED support for the panda DTS

2013-05-16 Thread Nishanth Menon
On Thu, May 16, 2013 at 3:22 PM, Dan Murphy dmur...@ti.com wrote: On 05/16/2013 01:18 PM, Nishanth Menon wrote: On Thu, May 16, 2013 at 10:35 AM, Dan Murphy dmur...@ti.com wrote: I am not sure you really want to do this. If I make the pinctrl part of the led structure then the only way the

Re: [PATCH v4] ARM:dts:omap4-panda: Update the LED support for the panda DTS

2013-05-15 Thread Nishanth Menon
On 11:46-20130515, Dan Murphy wrote: > The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es > are different. > > A1-A3 = gpio_wk7 > ES = gpio_110 > > There is no change to LED D2 > > Abstract away the pinmux and the LED definitions for the two boards into > the respective DTS

[PATCH v4] ARM:dts:omap4-panda: Update the LED support for the panda DTS

2013-05-15 Thread Dan Murphy
The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es are different. A1-A3 = gpio_wk7 ES = gpio_110 There is no change to LED D2 Abstract away the pinmux and the LED definitions for the two boards into the respective DTS files. Signed-off-by: Dan Murphy ---

[PATCH v4] ARM:dts:omap4-panda: Update the LED support for the panda DTS

2013-05-15 Thread Dan Murphy
The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es are different. A1-A3 = gpio_wk7 ES = gpio_110 There is no change to LED D2 Abstract away the pinmux and the LED definitions for the two boards into the respective DTS files. Signed-off-by: Dan Murphy dmur...@ti.com ---

Re: [PATCH v4] ARM:dts:omap4-panda: Update the LED support for the panda DTS

2013-05-15 Thread Nishanth Menon
On 11:46-20130515, Dan Murphy wrote: The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es are different. A1-A3 = gpio_wk7 ES = gpio_110 There is no change to LED D2 Abstract away the pinmux and the LED definitions for the two boards into the respective DTS files.