Re: [PATCH v4] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-12 Thread Jingoo Han
On Monday, December 10, 2012 5:18 PM, Jingoo Han wrote > On Thursday, December 06, 2012 4:22 AM, Russell King - ARM Linux wrote > > On Wed, Dec 05, 2012 at 07:20:00PM +0100, Marko Katić wrote: > > > On Wed, Dec 5, 2012 at 10:30 AM, Russell King - ARM Linux > > > wrote: > > > > On Wed, Dec 05,

Re: [PATCH v4] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-12 Thread Jingoo Han
On Monday, December 10, 2012 5:18 PM, Jingoo Han wrote On Thursday, December 06, 2012 4:22 AM, Russell King - ARM Linux wrote On Wed, Dec 05, 2012 at 07:20:00PM +0100, Marko Katić wrote: On Wed, Dec 5, 2012 at 10:30 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed,

Re: [PATCH v4] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-10 Thread Jingoo Han
On Thursday, December 06, 2012 4:22 AM, Russell King - ARM Linux wrote > On Wed, Dec 05, 2012 at 07:20:00PM +0100, Marko Katić wrote: > > On Wed, Dec 5, 2012 at 10:30 AM, Russell King - ARM Linux > > wrote: > > > On Wed, Dec 05, 2012 at 09:59:07AM +0900, Jingoo Han wrote: > > >> - if

Re: [PATCH v4] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-10 Thread Jingoo Han
On Thursday, December 06, 2012 4:22 AM, Russell King - ARM Linux wrote On Wed, Dec 05, 2012 at 07:20:00PM +0100, Marko Katić wrote: On Wed, Dec 5, 2012 at 10:30 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Dec 05, 2012 at 09:59:07AM +0900, Jingoo Han wrote: -

Re: [PATCH v4] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-05 Thread Grant Likely
On Wed, Dec 5, 2012 at 7:21 PM, Russell King - ARM Linux wrote: > As I say above, IMHO it would've been much better to rename these functions > to be the other way around but David was always very dismissive of any > comments I had against any code he'd written. FWIW, I'll gladly take a patch to

Re: [PATCH v4] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-05 Thread Russell King - ARM Linux
On Wed, Dec 05, 2012 at 07:20:00PM +0100, Marko Katić wrote: > On Wed, Dec 5, 2012 at 10:30 AM, Russell King - ARM Linux > wrote: > > On Wed, Dec 05, 2012 at 09:59:07AM +0900, Jingoo Han wrote: > >> - if (gpio_is_valid(lcd->gpio_backlight_cont)) > >> -

Re: [PATCH v4] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-05 Thread Marko Katić
On Wed, Dec 5, 2012 at 10:30 AM, Russell King - ARM Linux wrote: > On Wed, Dec 05, 2012 at 09:59:07AM +0900, Jingoo Han wrote: >> - if (gpio_is_valid(lcd->gpio_backlight_cont)) >> - gpio_set_value(lcd->gpio_backlight_cont, cont); >> + if

Re: [PATCH v4] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-05 Thread Russell King - ARM Linux
On Wed, Dec 05, 2012 at 09:59:07AM +0900, Jingoo Han wrote: > - if (gpio_is_valid(lcd->gpio_backlight_cont)) > - gpio_set_value(lcd->gpio_backlight_cont, cont); > + if (gpio_is_valid(lcd->gpio_backlight_cont)) { > + if (gpio_cansleep(lcd->gpio_backlight_cont)) > +

Re: [PATCH v4] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-05 Thread Russell King - ARM Linux
On Wed, Dec 05, 2012 at 09:59:07AM +0900, Jingoo Han wrote: - if (gpio_is_valid(lcd-gpio_backlight_cont)) - gpio_set_value(lcd-gpio_backlight_cont, cont); + if (gpio_is_valid(lcd-gpio_backlight_cont)) { + if (gpio_cansleep(lcd-gpio_backlight_cont)) +

Re: [PATCH v4] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-05 Thread Marko Katić
On Wed, Dec 5, 2012 at 10:30 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Dec 05, 2012 at 09:59:07AM +0900, Jingoo Han wrote: - if (gpio_is_valid(lcd-gpio_backlight_cont)) - gpio_set_value(lcd-gpio_backlight_cont, cont); + if

Re: [PATCH v4] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-05 Thread Russell King - ARM Linux
On Wed, Dec 05, 2012 at 07:20:00PM +0100, Marko Katić wrote: On Wed, Dec 5, 2012 at 10:30 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Dec 05, 2012 at 09:59:07AM +0900, Jingoo Han wrote: - if (gpio_is_valid(lcd-gpio_backlight_cont)) -

Re: [PATCH v4] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-05 Thread Grant Likely
On Wed, Dec 5, 2012 at 7:21 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: As I say above, IMHO it would've been much better to rename these functions to be the other way around but David was always very dismissive of any comments I had against any code he'd written. FWIW, I'll

[PATCH v4] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-04 Thread Jingoo Han
From: Marko Katic Changing backlight intensity on an Akita (Sharp Zaurus C-1000) triggers WARN_ON message: WARNING: at drivers/gpio/gpiolib.c:1672 __gpio_set_value+0x38/0xa4() Modules linked in: Backtrace: [] (dump_backtrace+0x0/0x110) from [] (dump_stack+0x18/0x1c) r6:c0158fc8 r5:0009

[PATCH v4] backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON

2012-12-04 Thread Jingoo Han
From: Marko Katic drom...@gmail.com Changing backlight intensity on an Akita (Sharp Zaurus C-1000) triggers WARN_ON message: WARNING: at drivers/gpio/gpiolib.c:1672 __gpio_set_value+0x38/0xa4() Modules linked in: Backtrace: [c000c0ac] (dump_backtrace+0x0/0x110) from [c02c8278]