Re: [PATCH v4] kcov, usb: only collect coverage from __usb_hcd_giveback_urb in softirq

2020-11-23 Thread Andrey Konovalov
On Fri, Nov 13, 2020 at 4:47 PM Marco Elver wrote: > > On Fri, 13 Nov 2020 at 14:42, Andrey Konovalov wrote: > > On Fri, Nov 13, 2020 at 2:28 PM Sebastian Andrzej Siewior > > wrote: > > > > > > On 2020-11-13 13:51:19 [+0100], Andrey Konovalov wrote: > > > > Hi Sebastian, > > > > > > Hi Andrey,

Re: [PATCH v4] kcov, usb: only collect coverage from __usb_hcd_giveback_urb in softirq

2020-11-13 Thread Marco Elver
On Fri, 13 Nov 2020 at 14:42, Andrey Konovalov wrote: > On Fri, Nov 13, 2020 at 2:28 PM Sebastian Andrzej Siewior > wrote: > > > > On 2020-11-13 13:51:19 [+0100], Andrey Konovalov wrote: > > > Hi Sebastian, > > > > Hi Andrey, > > > > > Replaced with what and why? > > > > Linus requested in > >

Re: [PATCH v4] kcov, usb: only collect coverage from __usb_hcd_giveback_urb in softirq

2020-11-13 Thread Greg Kroah-Hartman
On Fri, Nov 13, 2020 at 02:42:44PM +0100, Andrey Konovalov wrote: > On Fri, Nov 13, 2020 at 2:28 PM Sebastian Andrzej Siewior > wrote: > > > > On 2020-11-13 13:51:19 [+0100], Andrey Konovalov wrote: > > > Hi Sebastian, > > > > Hi Andrey, > > > > > Replaced with what and why? > > > > Linus

Re: [PATCH v4] kcov, usb: only collect coverage from __usb_hcd_giveback_urb in softirq

2020-11-13 Thread Andrey Konovalov
On Fri, Nov 13, 2020 at 2:28 PM Sebastian Andrzej Siewior wrote: > > On 2020-11-13 13:51:19 [+0100], Andrey Konovalov wrote: > > Hi Sebastian, > > Hi Andrey, > > > Replaced with what and why? > > Linus requested in > >

Re: [PATCH v4] kcov, usb: only collect coverage from __usb_hcd_giveback_urb in softirq

2020-11-13 Thread Sebastian Andrzej Siewior
On 2020-11-13 13:51:19 [+0100], Andrey Konovalov wrote: > Hi Sebastian, Hi Andrey, > Replaced with what and why? Linus requested in https://lkml.kernel.org/r/CAHk-=wht7kaeyr5xew2orj7m0hibvxz3t+2ie8vnhlqfdbn...@mail.gmail.com/ that drivers should not change their behaviour on context

Re: [PATCH v4] kcov, usb: only collect coverage from __usb_hcd_giveback_urb in softirq

2020-11-13 Thread Andrey Konovalov
On Fri, Nov 13, 2020 at 1:30 PM Sebastian Andrzej Siewior wrote: > > On 2020-10-16 15:57:45 [+0200], Andrey Konovalov wrote: > > --- a/drivers/usb/core/hcd.c > > +++ b/drivers/usb/core/hcd.c > > @@ -1646,9 +1646,16 @@ static void __usb_hcd_giveback_urb(struct urb *urb) > > > > /* pass

Re: [PATCH v4] kcov, usb: only collect coverage from __usb_hcd_giveback_urb in softirq

2020-11-13 Thread Sebastian Andrzej Siewior
On 2020-10-16 15:57:45 [+0200], Andrey Konovalov wrote: > --- a/drivers/usb/core/hcd.c > +++ b/drivers/usb/core/hcd.c > @@ -1646,9 +1646,16 @@ static void __usb_hcd_giveback_urb(struct urb *urb) > > /* pass ownership to the completion handler */ > urb->status = status; > -

Re: [PATCH v4] kcov, usb: only collect coverage from __usb_hcd_giveback_urb in softirq

2020-10-16 Thread Dmitry Vyukov
On Fri, Oct 16, 2020 at 3:57 PM Andrey Konovalov wrote: > > Currently there's a KCOV remote coverage collection section in > __usb_hcd_giveback_urb(). Initially that section was added based on the > assumption that usb_hcd_giveback_urb() can only be called in interrupt > context as indicated by a

[PATCH v4] kcov, usb: only collect coverage from __usb_hcd_giveback_urb in softirq

2020-10-16 Thread Andrey Konovalov
Currently there's a KCOV remote coverage collection section in __usb_hcd_giveback_urb(). Initially that section was added based on the assumption that usb_hcd_giveback_urb() can only be called in interrupt context as indicated by a comment before it. This is what happens when syzkaller is fuzzing