Re: [PATCH v4] mmc: sdhci-pci: add Support of Synopsys DWC_MSHC IP

2016-04-28 Thread Andy Shevchenko
On Thu, Apr 28, 2016 at 11:35 AM, Prabu Thangamuthu wrote: >> > + mul = 0x2; >> > + for (div = 1; div <= 32; div++) { >> > + if (((host->max_clk * mul) / div) >> > + <= clock) >> >> Too

Re: [PATCH v4] mmc: sdhci-pci: add Support of Synopsys DWC_MSHC IP

2016-04-28 Thread Andy Shevchenko
On Thu, Apr 28, 2016 at 11:35 AM, Prabu Thangamuthu wrote: >> > + mul = 0x2; >> > + for (div = 1; div <= 32; div++) { >> > + if (((host->max_clk * mul) / div) >> > + <= clock) >> >> Too many parens. >> >> > +

RE: [PATCH v4] mmc: sdhci-pci: add Support of Synopsys DWC_MSHC IP

2016-04-28 Thread Prabu Thangamuthu
Hi Andy Shevchenko, On 04/27/2016 7:09 PM, Andy Shevchenko wrote: > > On Wed, Apr 27, 2016 at 2:51 PM, Prabu Thangamuthu > wrote: > > Patch for Standard SD Host Controller Interface compliant Synopsys > > sdhci-dwc controller driver. This code supports PCI based interface.

RE: [PATCH v4] mmc: sdhci-pci: add Support of Synopsys DWC_MSHC IP

2016-04-28 Thread Prabu Thangamuthu
Hi Andy Shevchenko, On 04/27/2016 7:09 PM, Andy Shevchenko wrote: > > On Wed, Apr 27, 2016 at 2:51 PM, Prabu Thangamuthu > wrote: > > Patch for Standard SD Host Controller Interface compliant Synopsys > > sdhci-dwc controller driver. This code supports PCI based interface. > > > @@ -0,0 +1,244

Re: [PATCH v4] mmc: sdhci-pci: add Support of Synopsys DWC_MSHC IP

2016-04-27 Thread Andy Shevchenko
On Wed, Apr 27, 2016 at 2:51 PM, Prabu Thangamuthu wrote: > Patch for Standard SD Host Controller Interface compliant Synopsys > sdhci-dwc controller driver. This code supports PCI based interface. > @@ -0,0 +1,244 @@ > +/* > + * Copyright (C) 2016 Synopsys, Inc. > + * > +

Re: [PATCH v4] mmc: sdhci-pci: add Support of Synopsys DWC_MSHC IP

2016-04-27 Thread Andy Shevchenko
On Wed, Apr 27, 2016 at 2:51 PM, Prabu Thangamuthu wrote: > Patch for Standard SD Host Controller Interface compliant Synopsys > sdhci-dwc controller driver. This code supports PCI based interface. > @@ -0,0 +1,244 @@ > +/* > + * Copyright (C) 2016 Synopsys, Inc. > + * > + * Author: Manjunath M

[PATCH v4] mmc: sdhci-pci: add Support of Synopsys DWC_MSHC IP

2016-04-27 Thread Prabu Thangamuthu
Patch for Standard SD Host Controller Interface compliant Synopsys sdhci-dwc controller driver. This code supports PCI based interface. Signed-off-by: Prabu Thangamuthu --- Change log v4: -Updated review comments to optimize the code. Change log v3:

[PATCH v4] mmc: sdhci-pci: add Support of Synopsys DWC_MSHC IP

2016-04-27 Thread Prabu Thangamuthu
Patch for Standard SD Host Controller Interface compliant Synopsys sdhci-dwc controller driver. This code supports PCI based interface. Signed-off-by: Prabu Thangamuthu --- Change log v4: -Updated review comments to optimize the code. Change log v3: -Removed unused code.