Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf
Em Thu, Jan 07, 2016 at 12:28:15PM +0530, Naveen N. Rao escreveu: > On 2015/12/17 09:19AM, Arnaldo Carvalho de Melo wrote: > > Em Thu, Dec 17, 2015 at 10:37:14AM +0530, Naveen N. Rao escreveu: > > > On 2015/12/17 09:29AM, Wang Nan wrote: > > > > The whole thread is: > > > > > > > > [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf: > > > > http://lkml.kernel.org/g/1450150557-127942-1-git-send-email-wangn...@huawei.com > > > > > > > > [PATCH v3 1/3] perf tools: Fix PowerPC native building > > > > http://lkml.kernel.org/g/1450150557-127942-2-git-send-email-wangn...@huawei.com > > > > > > > > [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to > > > > tools/scripts > > > > http://lkml.kernel.org/g/1450150557-127942-3-git-send-email-wangn...@huawei.com > > > > > > > > [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf > > > > http://lkml.kernel.org/g/1450150557-127942-4-git-send-email-wangn...@huawei.com > > > > > > > > and [PATCH v3 3/3] breaks local building because the usage of > > > > "srctree", and > > ^^ > > > You mean v4 here. > > > > > Anyway, now that you've sent v4, it should be much clearer. > > > > Right, I should've read it more thoroughly, but anyway, I'll process it > > today. > > Bump. > > Arnaldo, > Can you please push at least the initial 3 patches of this for v4.4? Sure, I'll try to do that now. > Wang Nan has posted v6 here: > http://thread.gmane.org/gmane.linux.kernel/2110626 And process the other patches in this series, in perf/core. > > > Thanks, > Naveen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf
Em Thu, Jan 07, 2016 at 12:28:15PM +0530, Naveen N. Rao escreveu: > On 2015/12/17 09:19AM, Arnaldo Carvalho de Melo wrote: > > Em Thu, Dec 17, 2015 at 10:37:14AM +0530, Naveen N. Rao escreveu: > > > On 2015/12/17 09:29AM, Wang Nan wrote: > > > > The whole thread is: > > > > > > > > [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf: > > > > http://lkml.kernel.org/g/1450150557-127942-1-git-send-email-wangn...@huawei.com > > > > > > > > [PATCH v3 1/3] perf tools: Fix PowerPC native building > > > > http://lkml.kernel.org/g/1450150557-127942-2-git-send-email-wangn...@huawei.com > > > > > > > > [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to > > > > tools/scripts > > > > http://lkml.kernel.org/g/1450150557-127942-3-git-send-email-wangn...@huawei.com > > > > > > > > [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf > > > > http://lkml.kernel.org/g/1450150557-127942-4-git-send-email-wangn...@huawei.com > > > > > > > > and [PATCH v3 3/3] breaks local building because the usage of > > > > "srctree", and > > ^^ > > > You mean v4 here. > > > > > Anyway, now that you've sent v4, it should be much clearer. > > > > Right, I should've read it more thoroughly, but anyway, I'll process it > > today. > > Bump. > > Arnaldo, > Can you please push at least the initial 3 patches of this for v4.4? Sure, I'll try to do that now. > Wang Nan has posted v6 here: > http://thread.gmane.org/gmane.linux.kernel/2110626 And process the other patches in this series, in perf/core. > > > Thanks, > Naveen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf
Em Thu, Dec 17, 2015 at 10:37:14AM +0530, Naveen N. Rao escreveu: > On 2015/12/17 09:29AM, Wang Nan wrote: > > The whole thread is: > > > > [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf: > > http://lkml.kernel.org/g/1450150557-127942-1-git-send-email-wangn...@huawei.com > > > > [PATCH v3 1/3] perf tools: Fix PowerPC native building > > http://lkml.kernel.org/g/1450150557-127942-2-git-send-email-wangn...@huawei.com > > > > [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts > > http://lkml.kernel.org/g/1450150557-127942-3-git-send-email-wangn...@huawei.com > > > > [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf > > http://lkml.kernel.org/g/1450150557-127942-4-git-send-email-wangn...@huawei.com > > > > and [PATCH v3 3/3] breaks local building because the usage of "srctree", and ^^ > You mean v4 here. > Anyway, now that you've sent v4, it should be much clearer. Right, I should've read it more thoroughly, but anyway, I'll process it today. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf
Em Thu, Dec 17, 2015 at 10:37:14AM +0530, Naveen N. Rao escreveu: > On 2015/12/17 09:29AM, Wang Nan wrote: > > The whole thread is: > > > > [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf: > > http://lkml.kernel.org/g/1450150557-127942-1-git-send-email-wangn...@huawei.com > > > > [PATCH v3 1/3] perf tools: Fix PowerPC native building > > http://lkml.kernel.org/g/1450150557-127942-2-git-send-email-wangn...@huawei.com > > > > [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts > > http://lkml.kernel.org/g/1450150557-127942-3-git-send-email-wangn...@huawei.com > > > > [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf > > http://lkml.kernel.org/g/1450150557-127942-4-git-send-email-wangn...@huawei.com > > > > and [PATCH v3 3/3] breaks local building because the usage of "srctree", and ^^ > You mean v4 here. > Anyway, now that you've sent v4, it should be much clearer. Right, I should've read it more thoroughly, but anyway, I'll process it today. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf
On 2015/12/17 09:29AM, Wang Nan wrote: > > > On 2015/12/17 3:42, Arnaldo Carvalho de Melo wrote: > >Em Tue, Dec 15, 2015 at 05:10:46PM +0530, Naveen N. Rao escreveu: > >>On 2015/12/15 08:51AM, Wang Nan wrote: > >>>From: "Naveen N. Rao" > >>> > >>>perf build is currently (v4.4-rc5) broken on powerpc: > >>> > >>>bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support > >>>your arch. > >>> # error __NR_bpf not defined. libbpf does not support your arch. > >>> ^ > >>> > >>>Fix this by including tools/scripts/Makefile.arch for the proper > >>>$ARCH macro. While at it, remove redundant LP64 macro definition. > >>> > >>>Also, since libbpf require $(srctree) now, detect the path of > >>>srctree like perf. > >>> > >>>Signed-off-by: Naveen N. Rao > >>>Signed-off-by: Wang Nan > >>>Acked-by: Jiri Olsa > >>>Cc: Arnaldo Carvalho de Melo > >>>Cc: Sukadev Bhattiprolu > >>>--- > >>> > >>>v3 -> v4: Add srctree detector code so directly run 'make' in libbpf > >>> directory would not cause error. > >>Good catch! > >> > >>Tested-by: Naveen N. Rao > >Trying to apply the patchkit: > > > >[acme@zoo linux]$ make -C tools clean > /dev/null 2>&1 > >[acme@zoo linux]$ make -C tools/perf build-test > >make: Entering directory '/home/git/linux/tools/perf' > >Testing Makefile > >tests/make:15: /scripts/Makefile.arch: No such file or directory > >make[2]: *** No rule to make target '/scripts/Makefile.arch'. Stop. > >tests/make:5: recipe for target 'all' failed > >make[1]: *** [all] Error 2 > >Makefile:81: recipe for target 'build-test' failed > >make: *** [build-test] Error 2 > >make: Leaving directory '/home/git/linux/tools/perf' > >[acme@zoo linux]$ > > > >What am I doing wrong? > > You need all 3 patches. This v4 patch is a fix for previous v3 3/3 and I > send > this patch by replying that one. I thought your email client is sorted by > thread > so you can easily find it but it seems I was wrong... Arrgh! I see the confusion - your v4 didn't explicitly mention patch number 3, so that must have made Arnaldo think that this patch alone is enough. Perhaps [PATCH v4 3/3] would have been clearer. > > The whole thread is: > > [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf: > http://lkml.kernel.org/g/1450150557-127942-1-git-send-email-wangn...@huawei.com > > [PATCH v3 1/3] perf tools: Fix PowerPC native building > http://lkml.kernel.org/g/1450150557-127942-2-git-send-email-wangn...@huawei.com > > [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts > http://lkml.kernel.org/g/1450150557-127942-3-git-send-email-wangn...@huawei.com > > [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf > http://lkml.kernel.org/g/1450150557-127942-4-git-send-email-wangn...@huawei.com > > and [PATCH v3 3/3] breaks local building because the usage of "srctree", and ^^ You mean v4 here. Anyway, now that you've sent v4, it should be much clearer. Thanks, Naveen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf
On 2015/12/17 3:42, Arnaldo Carvalho de Melo wrote: Em Tue, Dec 15, 2015 at 05:10:46PM +0530, Naveen N. Rao escreveu: On 2015/12/15 08:51AM, Wang Nan wrote: From: "Naveen N. Rao" perf build is currently (v4.4-rc5) broken on powerpc: bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support your arch. # error __NR_bpf not defined. libbpf does not support your arch. ^ Fix this by including tools/scripts/Makefile.arch for the proper $ARCH macro. While at it, remove redundant LP64 macro definition. Also, since libbpf require $(srctree) now, detect the path of srctree like perf. Signed-off-by: Naveen N. Rao Signed-off-by: Wang Nan Acked-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Sukadev Bhattiprolu --- v3 -> v4: Add srctree detector code so directly run 'make' in libbpf directory would not cause error. Good catch! Tested-by: Naveen N. Rao Trying to apply the patchkit: [acme@zoo linux]$ make -C tools clean > /dev/null 2>&1 [acme@zoo linux]$ make -C tools/perf build-test make: Entering directory '/home/git/linux/tools/perf' Testing Makefile tests/make:15: /scripts/Makefile.arch: No such file or directory make[2]: *** No rule to make target '/scripts/Makefile.arch'. Stop. tests/make:5: recipe for target 'all' failed make[1]: *** [all] Error 2 Makefile:81: recipe for target 'build-test' failed make: *** [build-test] Error 2 make: Leaving directory '/home/git/linux/tools/perf' [acme@zoo linux]$ What am I doing wrong? You need all 3 patches. This v4 patch is a fix for previous v3 3/3 and I send this patch by replying that one. I thought your email client is sorted by thread so you can easily find it but it seems I was wrong... The whole thread is: [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf: http://lkml.kernel.org/g/1450150557-127942-1-git-send-email-wangn...@huawei.com [PATCH v3 1/3] perf tools: Fix PowerPC native building http://lkml.kernel.org/g/1450150557-127942-2-git-send-email-wangn...@huawei.com [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts http://lkml.kernel.org/g/1450150557-127942-3-git-send-email-wangn...@huawei.com [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf http://lkml.kernel.org/g/1450150557-127942-4-git-send-email-wangn...@huawei.com and [PATCH v3 3/3] breaks local building because the usage of "srctree", and I fix it in this one. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf
Em Tue, Dec 15, 2015 at 05:10:46PM +0530, Naveen N. Rao escreveu: > On 2015/12/15 08:51AM, Wang Nan wrote: > > From: "Naveen N. Rao" > > > > perf build is currently (v4.4-rc5) broken on powerpc: > > > > bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support > > your arch. > > # error __NR_bpf not defined. libbpf does not support your arch. > > ^ > > > > Fix this by including tools/scripts/Makefile.arch for the proper > > $ARCH macro. While at it, remove redundant LP64 macro definition. > > > > Also, since libbpf require $(srctree) now, detect the path of > > srctree like perf. > > > > Signed-off-by: Naveen N. Rao > > Signed-off-by: Wang Nan > > Acked-by: Jiri Olsa > > Cc: Arnaldo Carvalho de Melo > > Cc: Sukadev Bhattiprolu > > --- > > > > v3 -> v4: Add srctree detector code so directly run 'make' in libbpf > > directory would not cause error. > > Good catch! > > Tested-by: Naveen N. Rao Trying to apply the patchkit: [acme@zoo linux]$ make -C tools clean > /dev/null 2>&1 [acme@zoo linux]$ make -C tools/perf build-test make: Entering directory '/home/git/linux/tools/perf' Testing Makefile tests/make:15: /scripts/Makefile.arch: No such file or directory make[2]: *** No rule to make target '/scripts/Makefile.arch'. Stop. tests/make:5: recipe for target 'all' failed make[1]: *** [all] Error 2 Makefile:81: recipe for target 'build-test' failed make: *** [build-test] Error 2 make: Leaving directory '/home/git/linux/tools/perf' [acme@zoo linux]$ What am I doing wrong? - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf
Em Tue, Dec 15, 2015 at 05:10:46PM +0530, Naveen N. Rao escreveu: > On 2015/12/15 08:51AM, Wang Nan wrote: > > From: "Naveen N. Rao"> > > > perf build is currently (v4.4-rc5) broken on powerpc: > > > > bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support > > your arch. > > # error __NR_bpf not defined. libbpf does not support your arch. > > ^ > > > > Fix this by including tools/scripts/Makefile.arch for the proper > > $ARCH macro. While at it, remove redundant LP64 macro definition. > > > > Also, since libbpf require $(srctree) now, detect the path of > > srctree like perf. > > > > Signed-off-by: Naveen N. Rao > > Signed-off-by: Wang Nan > > Acked-by: Jiri Olsa > > Cc: Arnaldo Carvalho de Melo > > Cc: Sukadev Bhattiprolu > > --- > > > > v3 -> v4: Add srctree detector code so directly run 'make' in libbpf > > directory would not cause error. > > Good catch! > > Tested-by: Naveen N. Rao Trying to apply the patchkit: [acme@zoo linux]$ make -C tools clean > /dev/null 2>&1 [acme@zoo linux]$ make -C tools/perf build-test make: Entering directory '/home/git/linux/tools/perf' Testing Makefile tests/make:15: /scripts/Makefile.arch: No such file or directory make[2]: *** No rule to make target '/scripts/Makefile.arch'. Stop. tests/make:5: recipe for target 'all' failed make[1]: *** [all] Error 2 Makefile:81: recipe for target 'build-test' failed make: *** [build-test] Error 2 make: Leaving directory '/home/git/linux/tools/perf' [acme@zoo linux]$ What am I doing wrong? - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf
On 2015/12/17 09:29AM, Wang Nan wrote: > > > On 2015/12/17 3:42, Arnaldo Carvalho de Melo wrote: > >Em Tue, Dec 15, 2015 at 05:10:46PM +0530, Naveen N. Rao escreveu: > >>On 2015/12/15 08:51AM, Wang Nan wrote: > >>>From: "Naveen N. Rao"> >>> > >>>perf build is currently (v4.4-rc5) broken on powerpc: > >>> > >>>bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support > >>>your arch. > >>> # error __NR_bpf not defined. libbpf does not support your arch. > >>> ^ > >>> > >>>Fix this by including tools/scripts/Makefile.arch for the proper > >>>$ARCH macro. While at it, remove redundant LP64 macro definition. > >>> > >>>Also, since libbpf require $(srctree) now, detect the path of > >>>srctree like perf. > >>> > >>>Signed-off-by: Naveen N. Rao > >>>Signed-off-by: Wang Nan > >>>Acked-by: Jiri Olsa > >>>Cc: Arnaldo Carvalho de Melo > >>>Cc: Sukadev Bhattiprolu > >>>--- > >>> > >>>v3 -> v4: Add srctree detector code so directly run 'make' in libbpf > >>> directory would not cause error. > >>Good catch! > >> > >>Tested-by: Naveen N. Rao > >Trying to apply the patchkit: > > > >[acme@zoo linux]$ make -C tools clean > /dev/null 2>&1 > >[acme@zoo linux]$ make -C tools/perf build-test > >make: Entering directory '/home/git/linux/tools/perf' > >Testing Makefile > >tests/make:15: /scripts/Makefile.arch: No such file or directory > >make[2]: *** No rule to make target '/scripts/Makefile.arch'. Stop. > >tests/make:5: recipe for target 'all' failed > >make[1]: *** [all] Error 2 > >Makefile:81: recipe for target 'build-test' failed > >make: *** [build-test] Error 2 > >make: Leaving directory '/home/git/linux/tools/perf' > >[acme@zoo linux]$ > > > >What am I doing wrong? > > You need all 3 patches. This v4 patch is a fix for previous v3 3/3 and I > send > this patch by replying that one. I thought your email client is sorted by > thread > so you can easily find it but it seems I was wrong... Arrgh! I see the confusion - your v4 didn't explicitly mention patch number 3, so that must have made Arnaldo think that this patch alone is enough. Perhaps [PATCH v4 3/3] would have been clearer. > > The whole thread is: > > [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf: > http://lkml.kernel.org/g/1450150557-127942-1-git-send-email-wangn...@huawei.com > > [PATCH v3 1/3] perf tools: Fix PowerPC native building > http://lkml.kernel.org/g/1450150557-127942-2-git-send-email-wangn...@huawei.com > > [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts > http://lkml.kernel.org/g/1450150557-127942-3-git-send-email-wangn...@huawei.com > > [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf > http://lkml.kernel.org/g/1450150557-127942-4-git-send-email-wangn...@huawei.com > > and [PATCH v3 3/3] breaks local building because the usage of "srctree", and ^^ You mean v4 here. Anyway, now that you've sent v4, it should be much clearer. Thanks, Naveen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf
On 2015/12/17 3:42, Arnaldo Carvalho de Melo wrote: Em Tue, Dec 15, 2015 at 05:10:46PM +0530, Naveen N. Rao escreveu: On 2015/12/15 08:51AM, Wang Nan wrote: From: "Naveen N. Rao"perf build is currently (v4.4-rc5) broken on powerpc: bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support your arch. # error __NR_bpf not defined. libbpf does not support your arch. ^ Fix this by including tools/scripts/Makefile.arch for the proper $ARCH macro. While at it, remove redundant LP64 macro definition. Also, since libbpf require $(srctree) now, detect the path of srctree like perf. Signed-off-by: Naveen N. Rao Signed-off-by: Wang Nan Acked-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Sukadev Bhattiprolu --- v3 -> v4: Add srctree detector code so directly run 'make' in libbpf directory would not cause error. Good catch! Tested-by: Naveen N. Rao Trying to apply the patchkit: [acme@zoo linux]$ make -C tools clean > /dev/null 2>&1 [acme@zoo linux]$ make -C tools/perf build-test make: Entering directory '/home/git/linux/tools/perf' Testing Makefile tests/make:15: /scripts/Makefile.arch: No such file or directory make[2]: *** No rule to make target '/scripts/Makefile.arch'. Stop. tests/make:5: recipe for target 'all' failed make[1]: *** [all] Error 2 Makefile:81: recipe for target 'build-test' failed make: *** [build-test] Error 2 make: Leaving directory '/home/git/linux/tools/perf' [acme@zoo linux]$ What am I doing wrong? You need all 3 patches. This v4 patch is a fix for previous v3 3/3 and I send this patch by replying that one. I thought your email client is sorted by thread so you can easily find it but it seems I was wrong... The whole thread is: [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf: http://lkml.kernel.org/g/1450150557-127942-1-git-send-email-wangn...@huawei.com [PATCH v3 1/3] perf tools: Fix PowerPC native building http://lkml.kernel.org/g/1450150557-127942-2-git-send-email-wangn...@huawei.com [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts http://lkml.kernel.org/g/1450150557-127942-3-git-send-email-wangn...@huawei.com [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf http://lkml.kernel.org/g/1450150557-127942-4-git-send-email-wangn...@huawei.com and [PATCH v3 3/3] breaks local building because the usage of "srctree", and I fix it in this one. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf
On 2015/12/15 08:51AM, Wang Nan wrote: > From: "Naveen N. Rao" > > perf build is currently (v4.4-rc5) broken on powerpc: > > bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support > your arch. > # error __NR_bpf not defined. libbpf does not support your arch. > ^ > > Fix this by including tools/scripts/Makefile.arch for the proper > $ARCH macro. While at it, remove redundant LP64 macro definition. > > Also, since libbpf require $(srctree) now, detect the path of > srctree like perf. > > Signed-off-by: Naveen N. Rao > Signed-off-by: Wang Nan > Acked-by: Jiri Olsa > Cc: Arnaldo Carvalho de Melo > Cc: Sukadev Bhattiprolu > --- > > v3 -> v4: Add srctree detector code so directly run 'make' in libbpf > directory would not cause error. Good catch! Tested-by: Naveen N. Rao > > --- > tools/lib/bpf/Makefile | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile > index 636e3dd..0b6e013 100644 > --- a/tools/lib/bpf/Makefile > +++ b/tools/lib/bpf/Makefile > @@ -6,6 +6,12 @@ BPF_EXTRAVERSION = 1 > > MAKEFLAGS += --no-print-directory > > +ifeq ($(srctree),) > +srctree := $(patsubst %/,%,$(dir $(shell pwd))) > +srctree := $(patsubst %/,%,$(dir $(srctree))) > +srctree := $(patsubst %/,%,$(dir $(srctree))) > +#$(info Determined 'srctree' to be $(srctree)) > +endif > > # Makefiles suck: This macro sets a default value of $(2) for the > # variable named by $(1), unless the variable has been set by > @@ -31,7 +37,8 @@ INSTALL = install > DESTDIR ?= > DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))' > > -LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1) > +include $(srctree)/tools/scripts/Makefile.arch > + > ifeq ($(LP64), 1) >libdir_relative = lib64 > else > -- > 1.8.3.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v4] perf: bpf: Fix build breakage due to libbpf
From: "Naveen N. Rao" perf build is currently (v4.4-rc5) broken on powerpc: bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support your arch. # error __NR_bpf not defined. libbpf does not support your arch. ^ Fix this by including tools/scripts/Makefile.arch for the proper $ARCH macro. While at it, remove redundant LP64 macro definition. Also, since libbpf require $(srctree) now, detect the path of srctree like perf. Signed-off-by: Naveen N. Rao Signed-off-by: Wang Nan Acked-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Sukadev Bhattiprolu --- v3 -> v4: Add srctree detector code so directly run 'make' in libbpf directory would not cause error. --- tools/lib/bpf/Makefile | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile index 636e3dd..0b6e013 100644 --- a/tools/lib/bpf/Makefile +++ b/tools/lib/bpf/Makefile @@ -6,6 +6,12 @@ BPF_EXTRAVERSION = 1 MAKEFLAGS += --no-print-directory +ifeq ($(srctree),) +srctree := $(patsubst %/,%,$(dir $(shell pwd))) +srctree := $(patsubst %/,%,$(dir $(srctree))) +srctree := $(patsubst %/,%,$(dir $(srctree))) +#$(info Determined 'srctree' to be $(srctree)) +endif # Makefiles suck: This macro sets a default value of $(2) for the # variable named by $(1), unless the variable has been set by @@ -31,7 +37,8 @@ INSTALL = install DESTDIR ?= DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))' -LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1) +include $(srctree)/tools/scripts/Makefile.arch + ifeq ($(LP64), 1) libdir_relative = lib64 else -- 1.8.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v4] perf: bpf: Fix build breakage due to libbpf
From: "Naveen N. Rao"perf build is currently (v4.4-rc5) broken on powerpc: bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support your arch. # error __NR_bpf not defined. libbpf does not support your arch. ^ Fix this by including tools/scripts/Makefile.arch for the proper $ARCH macro. While at it, remove redundant LP64 macro definition. Also, since libbpf require $(srctree) now, detect the path of srctree like perf. Signed-off-by: Naveen N. Rao Signed-off-by: Wang Nan Acked-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Sukadev Bhattiprolu --- v3 -> v4: Add srctree detector code so directly run 'make' in libbpf directory would not cause error. --- tools/lib/bpf/Makefile | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile index 636e3dd..0b6e013 100644 --- a/tools/lib/bpf/Makefile +++ b/tools/lib/bpf/Makefile @@ -6,6 +6,12 @@ BPF_EXTRAVERSION = 1 MAKEFLAGS += --no-print-directory +ifeq ($(srctree),) +srctree := $(patsubst %/,%,$(dir $(shell pwd))) +srctree := $(patsubst %/,%,$(dir $(srctree))) +srctree := $(patsubst %/,%,$(dir $(srctree))) +#$(info Determined 'srctree' to be $(srctree)) +endif # Makefiles suck: This macro sets a default value of $(2) for the # variable named by $(1), unless the variable has been set by @@ -31,7 +37,8 @@ INSTALL = install DESTDIR ?= DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))' -LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1) +include $(srctree)/tools/scripts/Makefile.arch + ifeq ($(LP64), 1) libdir_relative = lib64 else -- 1.8.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf
On 2015/12/15 08:51AM, Wang Nan wrote: > From: "Naveen N. Rao"> > perf build is currently (v4.4-rc5) broken on powerpc: > > bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support > your arch. > # error __NR_bpf not defined. libbpf does not support your arch. > ^ > > Fix this by including tools/scripts/Makefile.arch for the proper > $ARCH macro. While at it, remove redundant LP64 macro definition. > > Also, since libbpf require $(srctree) now, detect the path of > srctree like perf. > > Signed-off-by: Naveen N. Rao > Signed-off-by: Wang Nan > Acked-by: Jiri Olsa > Cc: Arnaldo Carvalho de Melo > Cc: Sukadev Bhattiprolu > --- > > v3 -> v4: Add srctree detector code so directly run 'make' in libbpf > directory would not cause error. Good catch! Tested-by: Naveen N. Rao > > --- > tools/lib/bpf/Makefile | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile > index 636e3dd..0b6e013 100644 > --- a/tools/lib/bpf/Makefile > +++ b/tools/lib/bpf/Makefile > @@ -6,6 +6,12 @@ BPF_EXTRAVERSION = 1 > > MAKEFLAGS += --no-print-directory > > +ifeq ($(srctree),) > +srctree := $(patsubst %/,%,$(dir $(shell pwd))) > +srctree := $(patsubst %/,%,$(dir $(srctree))) > +srctree := $(patsubst %/,%,$(dir $(srctree))) > +#$(info Determined 'srctree' to be $(srctree)) > +endif > > # Makefiles suck: This macro sets a default value of $(2) for the > # variable named by $(1), unless the variable has been set by > @@ -31,7 +37,8 @@ INSTALL = install > DESTDIR ?= > DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))' > > -LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1) > +include $(srctree)/tools/scripts/Makefile.arch > + > ifeq ($(LP64), 1) >libdir_relative = lib64 > else > -- > 1.8.3.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/