Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Fri 2017-12-22 07:44:26, Steven Rostedt wrote: > On Fri, 22 Dec 2017 11:31:31 +0100 > Petr Mladek wrote: > > > > Index: linux-trace.git/kernel/printk/printk.c > > > === > > > ---

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Fri 2017-12-22 07:44:26, Steven Rostedt wrote: > On Fri, 22 Dec 2017 11:31:31 +0100 > Petr Mladek wrote: > > > > Index: linux-trace.git/kernel/printk/printk.c > > > === > > > --- linux-trace.git.orig/kernel/printk/printk.c > > >

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Fri, 22 Dec 2017 11:31:31 +0100 Petr Mladek wrote: > > Index: linux-trace.git/kernel/printk/printk.c > > === > > --- linux-trace.git.orig/kernel/printk/printk.c > > +++ linux-trace.git/kernel/printk/printk.c > >

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Fri, 22 Dec 2017 11:31:31 +0100 Petr Mladek wrote: > > Index: linux-trace.git/kernel/printk/printk.c > > === > > --- linux-trace.git.orig/kernel/printk/printk.c > > +++ linux-trace.git/kernel/printk/printk.c > > @@ -2141,6

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Wed 2017-11-08 10:27:23, Steven Rostedt wrote: > [ claws-mail is really pissing me off. It did it again, after I > manually fixed all the addresses. This time, I'm going to do things > slightly different. Sorry for all the spam :-( ] > > From: Steven Rostedt (VMware)

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Wed 2017-11-08 10:27:23, Steven Rostedt wrote: > [ claws-mail is really pissing me off. It did it again, after I > manually fixed all the addresses. This time, I'm going to do things > slightly different. Sorry for all the spam :-( ] > > From: Steven Rostedt (VMware) > > This patch

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Tue 2017-12-12 14:27:10, Steven Rostedt wrote: > On Tue, 12 Dec 2017 14:39:21 +0900 > Sergey Senozhatsky wrote: > > > p.s. > > frankly, I don't see any "locking issues" in Steven's patch. > > Should I push out another revision of mine? I am going to to

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Tue 2017-12-12 14:27:10, Steven Rostedt wrote: > On Tue, 12 Dec 2017 14:39:21 +0900 > Sergey Senozhatsky wrote: > > > p.s. > > frankly, I don't see any "locking issues" in Steven's patch. > > Should I push out another revision of mine? I am going to to give some more testing v4 within next

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Fri 2017-11-24 16:58:16, Petr Mladek wrote: > On Fri 2017-11-24 16:54:16, Petr Mladek wrote: > > On Wed 2017-11-08 10:27:23, Steven Rostedt wrote: > > > If there is a waiter, then it breaks out of the loop, clears the waiter > > > flag (because that will release the waiter from its spin), and

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Fri 2017-11-24 16:58:16, Petr Mladek wrote: > On Fri 2017-11-24 16:54:16, Petr Mladek wrote: > > On Wed 2017-11-08 10:27:23, Steven Rostedt wrote: > > > If there is a waiter, then it breaks out of the loop, clears the waiter > > > flag (because that will release the waiter from its spin), and

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On (12/12/17 14:27), Steven Rostedt wrote: > > p.s. > > frankly, I don't see any "locking issues" in Steven's patch. > > Should I push out another revision of mine? well, up to you :) I've picked up some bits of your console-owner patch and it's part of printk-kthread patch set [as of now]:

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On (12/12/17 14:27), Steven Rostedt wrote: > > p.s. > > frankly, I don't see any "locking issues" in Steven's patch. > > Should I push out another revision of mine? well, up to you :) I've picked up some bits of your console-owner patch and it's part of printk-kthread patch set [as of now]:

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Tue, 12 Dec 2017 14:39:21 +0900 Sergey Senozhatsky wrote: > p.s. > frankly, I don't see any "locking issues" in Steven's patch. Should I push out another revision of mine? -- Steve

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Tue, 12 Dec 2017 14:39:21 +0900 Sergey Senozhatsky wrote: > p.s. > frankly, I don't see any "locking issues" in Steven's patch. Should I push out another revision of mine? -- Steve

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

Hello, On (12/08/17 15:00), Petr Mladek wrote: [..] > > However, now that cross-release was introduces, lockdep can be applied > > to semaphore operations. Actually, I have a plan to do that. I think it > > would be better to make semaphore tracked with lockdep and remove all > > these manual

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

Hello, On (12/08/17 15:00), Petr Mladek wrote: [..] > > However, now that cross-release was introduces, lockdep can be applied > > to semaphore operations. Actually, I have a plan to do that. I think it > > would be better to make semaphore tracked with lockdep and remove all > > these manual

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

Hello, thanks a lot for help. I am sorry for the late response. I wanted to handle this mail with a clean head. On Tue 2017-11-28 10:42:29, Byungchul Park wrote: > On Fri, Nov 24, 2017 at 04:58:16PM +0100, Petr Mladek wrote: > > @@ -1797,13 +1797,6 @@ asmlinkage int vprintk_emit(int facility,

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

Hello, thanks a lot for help. I am sorry for the late response. I wanted to handle this mail with a clean head. On Tue 2017-11-28 10:42:29, Byungchul Park wrote: > On Fri, Nov 24, 2017 at 04:58:16PM +0100, Petr Mladek wrote: > > @@ -1797,13 +1797,6 @@ asmlinkage int vprintk_emit(int facility,

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

Hi, On (11/27/17 17:48), Byungchul Park wrote: [..] > > + /* Owner will clear console_waiter on hand off > > */ > > + while (READ_ONCE(console_waiter)) > > + cpu_relax(); > > + > > +

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

Hi, On (11/27/17 17:48), Byungchul Park wrote: [..] > > + /* Owner will clear console_waiter on hand off > > */ > > + while (READ_ONCE(console_waiter)) > > + cpu_relax(); > > + > > +

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Fri, Nov 24, 2017 at 04:58:16PM +0100, Petr Mladek wrote: > @@ -1797,13 +1797,6 @@ asmlinkage int vprintk_emit(int facility, int level, > spin_release(_owner_dep_map, 1, > _THIS_IP_); > printk_safe_exit_irqrestore(flags); > > -

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Fri, Nov 24, 2017 at 04:58:16PM +0100, Petr Mladek wrote: > @@ -1797,13 +1797,6 @@ asmlinkage int vprintk_emit(int facility, int level, > spin_release(_owner_dep_map, 1, > _THIS_IP_); > printk_safe_exit_irqrestore(flags); > > -

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Fri, Nov 24, 2017 at 04:58:16PM +0100, Petr Mladek wrote: > On Fri 2017-11-24 16:54:16, Petr Mladek wrote: > > On Wed 2017-11-08 10:27:23, Steven Rostedt wrote: > > > If there is a waiter, then it breaks out of the loop, clears the waiter > > > flag (because that will release the waiter from

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Fri, Nov 24, 2017 at 04:58:16PM +0100, Petr Mladek wrote: > On Fri 2017-11-24 16:54:16, Petr Mladek wrote: > > On Wed 2017-11-08 10:27:23, Steven Rostedt wrote: > > > If there is a waiter, then it breaks out of the loop, clears the waiter > > > flag (because that will release the waiter from

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Wed, Nov 08, 2017 at 10:27:23AM -0500, Steven Rostedt wrote: > --- linux-trace.git.orig/kernel/printk/printk.c > +++ linux-trace.git/kernel/printk/printk.c > @@ -86,8 +86,15 @@ EXPORT_SYMBOL_GPL(console_drivers); > static struct lockdep_map console_lock_dep_map = { > .name =

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Wed, Nov 08, 2017 at 10:27:23AM -0500, Steven Rostedt wrote: > --- linux-trace.git.orig/kernel/printk/printk.c > +++ linux-trace.git/kernel/printk/printk.c > @@ -86,8 +86,15 @@ EXPORT_SYMBOL_GPL(console_drivers); > static struct lockdep_map console_lock_dep_map = { > .name =

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Fri 2017-11-24 16:54:16, Petr Mladek wrote: > On Wed 2017-11-08 10:27:23, Steven Rostedt wrote: > > If there is a waiter, then it breaks out of the loop, clears the waiter > > flag (because that will release the waiter from its spin), and exits. > > Note, it does *not* release the console

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Fri 2017-11-24 16:54:16, Petr Mladek wrote: > On Wed 2017-11-08 10:27:23, Steven Rostedt wrote: > > If there is a waiter, then it breaks out of the loop, clears the waiter > > flag (because that will release the waiter from its spin), and exits. > > Note, it does *not* release the console

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Wed 2017-11-08 10:27:23, Steven Rostedt wrote: > Here's the design again: > > I added a "console_owner" which is set to a task that is actively > writing to the consoles. It is *not* the same an the owner of the > console_lock. It is only set when doing the calls to the console > functions. It

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

On Wed 2017-11-08 10:27:23, Steven Rostedt wrote: > Here's the design again: > > I added a "console_owner" which is set to a task that is actively > writing to the consoles. It is *not* the same an the owner of the > console_lock. It is only set when doing the calls to the console > functions. It

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

Hi, assuming that this passes warn stall torturing by Tetsuo, do you think we can drop http://lkml.kernel.org/r/1509017339-4802-1-git-send-email-penguin-ker...@i-love.sakura.ne.jp from the mmotm tree? On Wed 08-11-17 10:27:23, Steven Rostedt wrote: > [ claws-mail is really pissing me off. It did

Re: [PATCH v4] printk: Add console owner and waiter logic to load balance console writes

Hi, assuming that this passes warn stall torturing by Tetsuo, do you think we can drop http://lkml.kernel.org/r/1509017339-4802-1-git-send-email-penguin-ker...@i-love.sakura.ne.jp from the mmotm tree? On Wed 08-11-17 10:27:23, Steven Rostedt wrote: > [ claws-mail is really pissing me off. It did

[PATCH v4] printk: Add console owner and waiter logic to load balance console writes

[ claws-mail is really pissing me off. It did it again, after I manually fixed all the addresses. This time, I'm going to do things slightly different. Sorry for all the spam :-( ] From: Steven Rostedt (VMware) This patch implements what I discussed in Kernel Summit. I

[PATCH v4] printk: Add console owner and waiter logic to load balance console writes

[ claws-mail is really pissing me off. It did it again, after I manually fixed all the addresses. This time, I'm going to do things slightly different. Sorry for all the spam :-( ] From: Steven Rostedt (VMware) This patch implements what I discussed in Kernel Summit. I added lockdep