Re: [PATCH v4] x86/boot/KASLR: exclude EFI_BOOT_SERVICES_{CODE|DATA} from KASLR's choice

2017-08-28 Thread Baoquan He
Hi Naoya, Thanks for this fix. I saw NEC had reported a bug to rhel previously, and the bug truly will corrupt OS, it can be fixed by this patch. This patch looks good to me, just a small concern, please see below inline comment. On 08/24/17 at 07:33pm, Naoya Horiguchi wrote: > KASLR chooses

Re: [PATCH v4] x86/boot/KASLR: exclude EFI_BOOT_SERVICES_{CODE|DATA} from KASLR's choice

2017-08-28 Thread Baoquan He
Hi Naoya, Thanks for this fix. I saw NEC had reported a bug to rhel previously, and the bug truly will corrupt OS, it can be fixed by this patch. This patch looks good to me, just a small concern, please see below inline comment. On 08/24/17 at 07:33pm, Naoya Horiguchi wrote: > KASLR chooses

[PATCH v4] x86/boot/KASLR: exclude EFI_BOOT_SERVICES_{CODE|DATA} from KASLR's choice

2017-08-24 Thread Naoya Horiguchi
KASLR chooses kernel location from E820_TYPE_RAM regions by walking over e820 entries now. E820_TYPE_RAM includes EFI_BOOT_SERVICES_CODE and EFI_BOOT_SERVICES_DATA, so those regions can be the target. According to UEFI spec, all memory regions marked as EfiBootServicesCode and EfiBootServicesData

[PATCH v4] x86/boot/KASLR: exclude EFI_BOOT_SERVICES_{CODE|DATA} from KASLR's choice

2017-08-24 Thread Naoya Horiguchi
KASLR chooses kernel location from E820_TYPE_RAM regions by walking over e820 entries now. E820_TYPE_RAM includes EFI_BOOT_SERVICES_CODE and EFI_BOOT_SERVICES_DATA, so those regions can be the target. According to UEFI spec, all memory regions marked as EfiBootServicesCode and EfiBootServicesData