Re: [PATCH v4 0/3] nvme power saving

On Thu, Oct 27, 2016 at 05:06:16PM -0700, Andy Lutomirski wrote: > It looks like there is at least one NVMe disk in existence (a > different Samsung device) that sporadically dies when APST is on. > This device appears to also sporadically die when APST is off, but it > lasts considerably longer

Re: [PATCH v4 0/3] nvme power saving

On Thu, Oct 27, 2016 at 05:06:16PM -0700, Andy Lutomirski wrote: > It looks like there is at least one NVMe disk in existence (a > different Samsung device) that sporadically dies when APST is on. > This device appears to also sporadically die when APST is off, but it > lasts considerably longer

Re: [PATCH v4 0/3] nvme power saving

On Thu, Sep 22, 2016 at 3:15 PM, Andy Lutomirski wrote: > On Thu, Sep 22, 2016 at 2:33 PM, J Freyensee > wrote: >> On Thu, 2016-09-22 at 14:43 -0600, Jens Axboe wrote: >>> On 09/22/2016 02:11 PM, Andy Lutomirski wrote: >>> > >>> > On Thu,

Re: [PATCH v4 0/3] nvme power saving

On Thu, Sep 22, 2016 at 3:15 PM, Andy Lutomirski wrote: > On Thu, Sep 22, 2016 at 2:33 PM, J Freyensee > wrote: >> On Thu, 2016-09-22 at 14:43 -0600, Jens Axboe wrote: >>> On 09/22/2016 02:11 PM, Andy Lutomirski wrote: >>> > >>> > On Thu, Sep 22, 2016 at 7:23 AM, Jens Axboe wrote: >>> > > >>> >

Re: [PATCH v4 0/3] nvme power saving

On 09/23/2016 05:42 PM, Christoph Hellwig wrote: Jens, can we at least get patches 1 and 2 in while pondering the fate of the right interface for patch 3? Yes definitely, I have no beef with the first two patches. I'll add them for 4.9. -- Jens Axboe

Re: [PATCH v4 0/3] nvme power saving

On 09/23/2016 05:42 PM, Christoph Hellwig wrote: Jens, can we at least get patches 1 and 2 in while pondering the fate of the right interface for patch 3? Yes definitely, I have no beef with the first two patches. I'll add them for 4.9. -- Jens Axboe

Re: [PATCH v4 0/3] nvme power saving

Jens, can we at least get patches 1 and 2 in while pondering the fate of the right interface for patch 3?

Re: [PATCH v4 0/3] nvme power saving

Jens, can we at least get patches 1 and 2 in while pondering the fate of the right interface for patch 3?

Re: [PATCH v4 0/3] nvme power saving

On Thu, Sep 22, 2016 at 2:33 PM, J Freyensee wrote: > On Thu, 2016-09-22 at 14:43 -0600, Jens Axboe wrote: >> On 09/22/2016 02:11 PM, Andy Lutomirski wrote: >> > >> > On Thu, Sep 22, 2016 at 7:23 AM, Jens Axboe wrote: >> > > >> > > >> > > On

Re: [PATCH v4 0/3] nvme power saving

On Thu, Sep 22, 2016 at 2:33 PM, J Freyensee wrote: > On Thu, 2016-09-22 at 14:43 -0600, Jens Axboe wrote: >> On 09/22/2016 02:11 PM, Andy Lutomirski wrote: >> > >> > On Thu, Sep 22, 2016 at 7:23 AM, Jens Axboe wrote: >> > > >> > > >> > > On 09/16/2016 12:16 PM, Andy Lutomirski wrote: >> > > >

Re: [PATCH v4 0/3] nvme power saving

On 09/22/2016 04:16 PM, Keith Busch wrote: On Thu, Sep 22, 2016 at 02:33:36PM -0700, J Freyensee wrote: ...and some SSDs don't even support this feature yet, so the number of different NVMe devices available to test initially will most likely be small (like the Fultondales I have, all I could

Re: [PATCH v4 0/3] nvme power saving

On 09/22/2016 04:16 PM, Keith Busch wrote: On Thu, Sep 22, 2016 at 02:33:36PM -0700, J Freyensee wrote: ...and some SSDs don't even support this feature yet, so the number of different NVMe devices available to test initially will most likely be small (like the Fultondales I have, all I could

Re: [PATCH v4 0/3] nvme power saving

On Thu, Sep 22, 2016 at 02:33:36PM -0700, J Freyensee wrote: > ...and some SSDs don't even support this feature yet, so the number of > different NVMe devices available to test initially will most likely be > small (like the Fultondales I have, all I could check is to see if the > code broke

Re: [PATCH v4 0/3] nvme power saving

On Thu, Sep 22, 2016 at 02:33:36PM -0700, J Freyensee wrote: > ...and some SSDs don't even support this feature yet, so the number of > different NVMe devices available to test initially will most likely be > small (like the Fultondales I have, all I could check is to see if the > code broke

Re: [PATCH v4 0/3] nvme power saving

On Thu, 2016-09-22 at 14:43 -0600, Jens Axboe wrote: > On 09/22/2016 02:11 PM, Andy Lutomirski wrote: > > > > On Thu, Sep 22, 2016 at 7:23 AM, Jens Axboe wrote: > > > > > > > > > On 09/16/2016 12:16 PM, Andy Lutomirski wrote: > > > > > > > > > > > > Hi all- > > > > > > > >

Re: [PATCH v4 0/3] nvme power saving

On Thu, 2016-09-22 at 14:43 -0600, Jens Axboe wrote: > On 09/22/2016 02:11 PM, Andy Lutomirski wrote: > > > > On Thu, Sep 22, 2016 at 7:23 AM, Jens Axboe wrote: > > > > > > > > > On 09/16/2016 12:16 PM, Andy Lutomirski wrote: > > > > > > > > > > > > Hi all- > > > > > > > > Here's v4 of the

Re: [PATCH v4 0/3] nvme power saving

On 09/22/2016 02:11 PM, Andy Lutomirski wrote: On Thu, Sep 22, 2016 at 7:23 AM, Jens Axboe wrote: On 09/16/2016 12:16 PM, Andy Lutomirski wrote: Hi all- Here's v4 of the APST patch set. The biggest bikesheddable thing (I think) is the scaling factor. I currently have it

Re: [PATCH v4 0/3] nvme power saving

On 09/22/2016 02:11 PM, Andy Lutomirski wrote: On Thu, Sep 22, 2016 at 7:23 AM, Jens Axboe wrote: On 09/16/2016 12:16 PM, Andy Lutomirski wrote: Hi all- Here's v4 of the APST patch set. The biggest bikesheddable thing (I think) is the scaling factor. I currently have it hardcoded so that

Re: [PATCH v4 0/3] nvme power saving

On Thu, Sep 22, 2016 at 7:23 AM, Jens Axboe wrote: > > On 09/16/2016 12:16 PM, Andy Lutomirski wrote: >> >> Hi all- >> >> Here's v4 of the APST patch set. The biggest bikesheddable thing (I >> think) is the scaling factor. I currently have it hardcoded so that >> we wait 50x the

Re: [PATCH v4 0/3] nvme power saving

On Thu, Sep 22, 2016 at 7:23 AM, Jens Axboe wrote: > > On 09/16/2016 12:16 PM, Andy Lutomirski wrote: >> >> Hi all- >> >> Here's v4 of the APST patch set. The biggest bikesheddable thing (I >> think) is the scaling factor. I currently have it hardcoded so that >> we wait 50x the total latency

Re: [PATCH v4 0/3] nvme power saving

On 09/16/2016 12:16 PM, Andy Lutomirski wrote: Hi all- Here's v4 of the APST patch set. The biggest bikesheddable thing (I think) is the scaling factor. I currently have it hardcoded so that we wait 50x the total latency before entering a power saving state. On my Samsung 950, this means we

Re: [PATCH v4 0/3] nvme power saving

On 09/16/2016 12:16 PM, Andy Lutomirski wrote: Hi all- Here's v4 of the APST patch set. The biggest bikesheddable thing (I think) is the scaling factor. I currently have it hardcoded so that we wait 50x the total latency before entering a power saving state. On my Samsung 950, this means we

Re: [PATCH v4 0/3] nvme power saving

On Wed, Sep 21, 2016 at 05:11:03PM -0700, Andy Lutomirski wrote: > Anything I can/should do to help this make it for 4.9? :) Maybe you should have added the Reviewed-by: tags you already got to this repost? :) Here we go again: Reviewed-by: Christoph Hellwig

Re: [PATCH v4 0/3] nvme power saving

On Wed, Sep 21, 2016 at 05:11:03PM -0700, Andy Lutomirski wrote: > Anything I can/should do to help this make it for 4.9? :) Maybe you should have added the Reviewed-by: tags you already got to this repost? :) Here we go again: Reviewed-by: Christoph Hellwig

Re: [PATCH v4 0/3] nvme power saving

On Fri, Sep 16, 2016 at 11:16 AM, Andy Lutomirski wrote: > Hi all- > > Here's v4 of the APST patch set. The biggest bikesheddable thing (I > think) is the scaling factor. I currently have it hardcoded so that > we wait 50x the total latency before entering a power saving state.

Re: [PATCH v4 0/3] nvme power saving

On Fri, Sep 16, 2016 at 11:16 AM, Andy Lutomirski wrote: > Hi all- > > Here's v4 of the APST patch set. The biggest bikesheddable thing (I > think) is the scaling factor. I currently have it hardcoded so that > we wait 50x the total latency before entering a power saving state. > On my Samsung

Re: [PATCH v4 0/3] nvme power saving

On Fri, 2016-09-16 at 11:16 -0700, Andy Lutomirski wrote: > Hi all- > > Here's v4 of the APST patch set.  The biggest bikesheddable thing (I > think) is the scaling factor.  I currently have it hardcoded so that > we wait 50x the total latency before entering a power saving state. > On my Samsung

Re: [PATCH v4 0/3] nvme power saving

On Fri, 2016-09-16 at 11:16 -0700, Andy Lutomirski wrote: > Hi all- > > Here's v4 of the APST patch set.  The biggest bikesheddable thing (I > think) is the scaling factor.  I currently have it hardcoded so that > we wait 50x the total latency before entering a power saving state. > On my Samsung

[PATCH v4 0/3] nvme power saving

Hi all- Here's v4 of the APST patch set. The biggest bikesheddable thing (I think) is the scaling factor. I currently have it hardcoded so that we wait 50x the total latency before entering a power saving state. On my Samsung 950, this means we enter state 3 (70mW, 0.5ms entry latency, 5ms exit

[PATCH v4 0/3] nvme power saving

Hi all- Here's v4 of the APST patch set. The biggest bikesheddable thing (I think) is the scaling factor. I currently have it hardcoded so that we wait 50x the total latency before entering a power saving state. On my Samsung 950, this means we enter state 3 (70mW, 0.5ms entry latency, 5ms exit