Re: [PATCH v4 0/9] Update to zstd-1.4.6

2020-10-02 Thread Chris Mason
On 2 Oct 2020, at 2:54, Christoph Hellwig wrote: On Wed, Sep 30, 2020 at 08:05:45PM +, Nick Terrell wrote: On Sep 29, 2020, at 11:53 PM, Christoph Hellwig wrote: As you keep resend this I keep retelling you that should not do it. Please provide a proper Linux API, and switch to that.

Re: [GIT PULL][PATCH v4 0/9] Update to zstd-1.4.6

2020-10-02 Thread Christoph Hellwig
On Thu, Oct 01, 2020 at 06:35:34PM +, Nick Terrell wrote: > I???m open to suggestions on how to get a zstd update done better. I don???t > know of any way to break this patch up into smaller patches that all compile. > The code is all generated directly from upstream and modified to work in

Re: [PATCH v4 0/9] Update to zstd-1.4.6

2020-10-02 Thread Christoph Hellwig
On Wed, Sep 30, 2020 at 08:05:45PM +, Nick Terrell wrote: > > > > On Sep 29, 2020, at 11:53 PM, Christoph Hellwig wrote: > > > > As you keep resend this I keep retelling you that should not do it. > > Please provide a proper Linux API, and switch to that. Versioned APIs > > have

Re: [GIT PULL][PATCH v4 0/9] Update to zstd-1.4.6

2020-10-01 Thread Nick Terrell
> On Oct 1, 2020, at 3:18 AM, David Sterba wrote: > > On Wed, Sep 30, 2020 at 08:49:49PM +, Nick Terrell wrote: >>> On Sep 29, 2020, at 11:53 PM, Nick Terrell wrote: >>> >>> From: Nick Terrell >> >> It has been brought to my attention that patch 3 hasn’t made it to patchwork, >> likely

Re: [GIT PULL][PATCH v4 0/9] Update to zstd-1.4.6

2020-10-01 Thread David Sterba
On Wed, Sep 30, 2020 at 08:49:49PM +, Nick Terrell wrote: > > On Sep 29, 2020, at 11:53 PM, Nick Terrell wrote: > > > > From: Nick Terrell > > It has been brought to my attention that patch 3 hasn’t made it to patchwork, > likely because it is too large. I’ll include a pull request in the

Re: [GIT PULL][PATCH v4 0/9] Update to zstd-1.4.6

2020-09-30 Thread Nick Terrell
> On Sep 29, 2020, at 11:53 PM, Nick Terrell wrote: > > From: Nick Terrell It has been brought to my attention that patch 3 hasn’t made it to patchwork, likely because it is too large. I’ll include a pull request in the next cover letter, together with the patches (if needed). Please pull

Re: [PATCH v4 0/9] Update to zstd-1.4.6

2020-09-30 Thread Nick Terrell
> On Sep 29, 2020, at 11:53 PM, Christoph Hellwig wrote: > > As you keep resend this I keep retelling you that should not do it. > Please provide a proper Linux API, and switch to that. Versioned APIs > have absolutely no business in the Linux kernel. The API is not versioned. We provide a

Re: [PATCH v4 0/9] Update to zstd-1.4.6

2020-09-30 Thread Christoph Hellwig
As you keep resend this I keep retelling you that should not do it. Please provide a proper Linux API, and switch to that. Versioned APIs have absolutely no business in the Linux kernel. On Tue, Sep 29, 2020 at 11:53:09PM -0700, Nick Terrell wrote: > From: Nick Terrell > > This patchset

[PATCH v4 0/9] Update to zstd-1.4.6

2020-09-30 Thread Nick Terrell
From: Nick Terrell This patchset upgrades the zstd library to the latest upstream release. The current zstd version in the kernel is a modified version of upstream zstd-1.3.1. At the time it was integrated, zstd wasn't ready to be used in the kernel as-is. But, it is now possible to use upstream