Re: [PATCH v4 00/10] selftests/resctrl: Add resctrl selftest
On 1/16/19 1:13 PM, Fenghua Yu wrote: > On Wed, Jan 16, 2019 at 03:54:07PM +, Moger, Babu wrote: >> Hi Fenghua/Sai/Arshiya, >> We were thinking of updating these selftests to work on both Intel and >> AMD. What do you guys think? >> >> If that is ok, I can update these patches and resubmit. If you have >> already updated, please post the latest series. I will use the latest >> version. Please let me know. >> Thanks > > Hi, Babu, > > Sure. Please go ahead to update the selftests to work on both Intel and AMD. > That's wonderful for resctrl overall. > > We do plan to update selftest and add resctrl fs interface testing. But > as of now we don't have updated selftest yet. Please work on the v4 patch > set. Sure. Thank you. > > Thanks. > > -Fenghua >
Re: [PATCH v4 00/10] selftests/resctrl: Add resctrl selftest
On Wed, Jan 16, 2019 at 03:54:07PM +, Moger, Babu wrote: > Hi Fenghua/Sai/Arshiya, > We were thinking of updating these selftests to work on both Intel and > AMD. What do you guys think? > > If that is ok, I can update these patches and resubmit. If you have > already updated, please post the latest series. I will use the latest > version. Please let me know. > Thanks Hi, Babu, Sure. Please go ahead to update the selftests to work on both Intel and AMD. That's wonderful for resctrl overall. We do plan to update selftest and add resctrl fs interface testing. But as of now we don't have updated selftest yet. Please work on the v4 patch set. Thanks. -Fenghua
Re: [PATCH v4 00/10] selftests/resctrl: Add resctrl selftest
Hi Fenghua/Sai/Arshiya, We were thinking of updating these selftests to work on both Intel and AMD. What do you guys think? If that is ok, I can update these patches and resubmit. If you have already updated, please post the latest series. I will use the latest version. Please let me know. Thanks On 12/21/18 6:20 PM, Fenghua Yu wrote: > With more and more resctrl features are being added by Intel, AMD > and ARM, a test tool is becoming more and more useful to validate > that both hardware and software functionalities work as expected. > > We introduce resctrl selftest to cover resctrl features on both > X86 and ARM architectures. It first implements MBM (Memory Bandwidth > Monitoring) and MBA (Memory Bandwidth Allocation) tests. We can enhance > the selftest tool to include more functionality tests in future. > > There is an existing resctrl test suite 'intel_cmt_cat'. But the major > purpose of the tool is to test Intel(R) RDT hardware via writing and > reading MSR registers. It does access resctrl file system; but the > functionalities are very limited. And it doesn't support automatic test > and a lot of manual verifications are involved. > > So the selftest tool we are introducing here provides a convenient > tool which does automatic resctrl testing, is easily available in kernel > tree, and will be extended to AMD QoS and ARM MPAM. > > The selftest tool is in tools/testing/selftests/resctrl in order to have > generic test code for all architectures. > > Changelog: > v4: > - address comments from Balu and Randy > - Add CAT and CQM tests > > v3: > - Change code based on comments from Babu Moger > - Remove some unnessary code and use pipe to communicate b/w processes > > v2: > - Change code based on comments from Babu Moger > - Clean up other places. > > Arshiya Hayatkhan Pathan (4): > selftests/resctrl: Add MBM test > selftests/resctrl: Add MBA test > selftests/resctrl Add Cache QoS Monitoring (CQM) selftest > selftests/resctrl: Add Cache Allocation Technology (CAT) selftest > > Fenghua Yu (2): > selftests/resctrl: Add README for resctrl tests > selftests/resctrl: Add the test in MAINTAINERS > > Sai Praneeth Prakhya (4): > selftests/resctrl: Add basic resctrl file system operations and data > selftests/resctrl: Read memory bandwidth from perf IMC counter and > from resctrl file system > selftests/resctrl: Add callback to start a benchmark > selftests/resctrl: Add built in benchmark > > MAINTAINERS | 1 + > tools/testing/selftests/resctrl/Makefile | 16 + > tools/testing/selftests/resctrl/README| 53 ++ > tools/testing/selftests/resctrl/cache.c | 275 +++ > tools/testing/selftests/resctrl/cat_test.c| 243 ++ > tools/testing/selftests/resctrl/cqm_test.c| 169 > tools/testing/selftests/resctrl/fill_buf.c| 198 + > tools/testing/selftests/resctrl/mba_test.c| 174 + > tools/testing/selftests/resctrl/mbm_test.c| 146 > tools/testing/selftests/resctrl/resctrl.h | 104 +++ > .../testing/selftests/resctrl/resctrl_tests.c | 175 + > tools/testing/selftests/resctrl/resctrl_val.c | 727 ++ > tools/testing/selftests/resctrl/resctrlfs.c | 643 > 13 files changed, 2924 insertions(+) > create mode 100644 tools/testing/selftests/resctrl/Makefile > create mode 100644 tools/testing/selftests/resctrl/README > create mode 100644 tools/testing/selftests/resctrl/cache.c > create mode 100644 tools/testing/selftests/resctrl/cat_test.c > create mode 100644 tools/testing/selftests/resctrl/cqm_test.c > create mode 100644 tools/testing/selftests/resctrl/fill_buf.c > create mode 100644 tools/testing/selftests/resctrl/mba_test.c > create mode 100644 tools/testing/selftests/resctrl/mbm_test.c > create mode 100644 tools/testing/selftests/resctrl/resctrl.h > create mode 100644 tools/testing/selftests/resctrl/resctrl_tests.c > create mode 100644 tools/testing/selftests/resctrl/resctrl_val.c > create mode 100644 tools/testing/selftests/resctrl/resctrlfs.c >
[PATCH v4 00/10] selftests/resctrl: Add resctrl selftest
With more and more resctrl features are being added by Intel, AMD and ARM, a test tool is becoming more and more useful to validate that both hardware and software functionalities work as expected. We introduce resctrl selftest to cover resctrl features on both X86 and ARM architectures. It first implements MBM (Memory Bandwidth Monitoring) and MBA (Memory Bandwidth Allocation) tests. We can enhance the selftest tool to include more functionality tests in future. There is an existing resctrl test suite 'intel_cmt_cat'. But the major purpose of the tool is to test Intel(R) RDT hardware via writing and reading MSR registers. It does access resctrl file system; but the functionalities are very limited. And it doesn't support automatic test and a lot of manual verifications are involved. So the selftest tool we are introducing here provides a convenient tool which does automatic resctrl testing, is easily available in kernel tree, and will be extended to AMD QoS and ARM MPAM. The selftest tool is in tools/testing/selftests/resctrl in order to have generic test code for all architectures. Changelog: v4: - address comments from Balu and Randy - Add CAT and CQM tests v3: - Change code based on comments from Babu Moger - Remove some unnessary code and use pipe to communicate b/w processes v2: - Change code based on comments from Babu Moger - Clean up other places. Arshiya Hayatkhan Pathan (4): selftests/resctrl: Add MBM test selftests/resctrl: Add MBA test selftests/resctrl Add Cache QoS Monitoring (CQM) selftest selftests/resctrl: Add Cache Allocation Technology (CAT) selftest Fenghua Yu (2): selftests/resctrl: Add README for resctrl tests selftests/resctrl: Add the test in MAINTAINERS Sai Praneeth Prakhya (4): selftests/resctrl: Add basic resctrl file system operations and data selftests/resctrl: Read memory bandwidth from perf IMC counter and from resctrl file system selftests/resctrl: Add callback to start a benchmark selftests/resctrl: Add built in benchmark MAINTAINERS | 1 + tools/testing/selftests/resctrl/Makefile | 16 + tools/testing/selftests/resctrl/README| 53 ++ tools/testing/selftests/resctrl/cache.c | 275 +++ tools/testing/selftests/resctrl/cat_test.c| 243 ++ tools/testing/selftests/resctrl/cqm_test.c| 169 tools/testing/selftests/resctrl/fill_buf.c| 198 + tools/testing/selftests/resctrl/mba_test.c| 174 + tools/testing/selftests/resctrl/mbm_test.c| 146 tools/testing/selftests/resctrl/resctrl.h | 104 +++ .../testing/selftests/resctrl/resctrl_tests.c | 175 + tools/testing/selftests/resctrl/resctrl_val.c | 727 ++ tools/testing/selftests/resctrl/resctrlfs.c | 643 13 files changed, 2924 insertions(+) create mode 100644 tools/testing/selftests/resctrl/Makefile create mode 100644 tools/testing/selftests/resctrl/README create mode 100644 tools/testing/selftests/resctrl/cache.c create mode 100644 tools/testing/selftests/resctrl/cat_test.c create mode 100644 tools/testing/selftests/resctrl/cqm_test.c create mode 100644 tools/testing/selftests/resctrl/fill_buf.c create mode 100644 tools/testing/selftests/resctrl/mba_test.c create mode 100644 tools/testing/selftests/resctrl/mbm_test.c create mode 100644 tools/testing/selftests/resctrl/resctrl.h create mode 100644 tools/testing/selftests/resctrl/resctrl_tests.c create mode 100644 tools/testing/selftests/resctrl/resctrl_val.c create mode 100644 tools/testing/selftests/resctrl/resctrlfs.c -- 2.19.1
