Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-11-02 Thread Dan Williams
On Mon, Nov 2, 2020 at 10:52 AM Jason Gunthorpe wrote: > > On Mon, Nov 02, 2020 at 10:38:28AM -0800, Dan Williams wrote: > > > > I think you will be the first to use the namespace stuff for this, it > > > seems like a good idea and others should probably do so as well. > > > > I was thinking

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-11-02 Thread Jason Gunthorpe
On Mon, Nov 02, 2020 at 10:38:28AM -0800, Dan Williams wrote: > > I think you will be the first to use the namespace stuff for this, it > > seems like a good idea and others should probably do so as well. > > I was thinking either EXPORT_SYMBOL_NS, or auxiliary bus, because you > should be able

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-11-02 Thread Dan Williams
On Mon, Nov 2, 2020 at 10:26 AM Jason Gunthorpe wrote: > > On Mon, Nov 02, 2020 at 11:18:33AM -0700, Dave Jiang wrote: > > > > > > On 11/2/2020 10:19 AM, Jason Gunthorpe wrote: > > > On Mon, Nov 02, 2020 at 08:20:43AM -0800, Raj, Ashok wrote: > > > > Creating these private interfaces for

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-11-02 Thread Jason Gunthorpe
On Mon, Nov 02, 2020 at 11:18:33AM -0700, Dave Jiang wrote: > > > On 11/2/2020 10:19 AM, Jason Gunthorpe wrote: > > On Mon, Nov 02, 2020 at 08:20:43AM -0800, Raj, Ashok wrote: > > > Creating these private interfaces for intra-module are just 1-1 and not > > > general purpose and every

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-11-02 Thread Dave Jiang
On 11/2/2020 10:19 AM, Jason Gunthorpe wrote: On Mon, Nov 02, 2020 at 08:20:43AM -0800, Raj, Ashok wrote: Creating these private interfaces for intra-module are just 1-1 and not general purpose and every accelerator needs to create these instances. This is where we are going, auxillary bus

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-11-02 Thread Jason Gunthorpe
On Mon, Nov 02, 2020 at 08:20:43AM -0800, Raj, Ashok wrote: > Creating these private interfaces for intra-module are just 1-1 and not > general purpose and every accelerator needs to create these instances. This is where we are going, auxillary bus should be merged soon which is specifically to

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-11-02 Thread Raj, Ashok
Hi Jason On Mon, Nov 02, 2020 at 09:20:36AM -0400, Jason Gunthorpe wrote: > > of IDXD for guest drivers. These look and feel like IDXD, not another > > device > > interface. In that sense if we move PF/VF mailboxes as > > separate drivers i thought it feels a bit odd. > > You need this split

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-11-02 Thread Jason Gunthorpe
On Sat, Oct 31, 2020 at 04:53:59PM -0700, Raj, Ashok wrote: > If we are doing this just to improve review effectiveness, Now we would need > some parent driver, and these sub-drivers registering seemed like a bit of > over-engineering when these sub-drivers actually are an extension of the > base

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-10-31 Thread Raj, Ashok
Hi Thomas, On Sat, Oct 31, 2020 at 03:50:43AM +0100, Thomas Gleixner wrote: > Ashok, > > < skip a lot of non-sensical arguments> Ouch!.. Didn't mean to awaken you like this :-).. apologies.. profusely! > > Just because there is historical precendence which does not care about > the

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-10-30 Thread Thomas Gleixner
Ashok, On Fri, Oct 30 2020 at 13:43, Ashok Raj wrote: > On Fri, Oct 30, 2020 at 04:30:45PM -0300, Jason Gunthorpe wrote: >> On Fri, Oct 30, 2020 at 12:23:25PM -0700, Raj, Ashok wrote: >> It is a different subsystem, different maintainer, and different >> reviewers. >> >> It is a development

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-10-30 Thread Jason Gunthorpe
On Fri, Oct 30, 2020 at 01:43:07PM -0700, Raj, Ashok wrote: > So drawing that parallel, do you expect all drivers that call > pci_register_driver() to be located in drivers/pci? Aren't they scattered > all over the place ata,scsi, platform drivers and such? The subsystem is the thing that calls

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-10-30 Thread Thomas Gleixner
On Fri, Oct 30 2020 at 13:59, Dave Jiang wrote: > On 10/30/2020 1:48 PM, Thomas Gleixner wrote: >> On Fri, Oct 30 2020 at 11:50, Dave Jiang wrote: >>> The code has dependency on Thomas’s MSI restructuring patch series: >>> https://lore.kernel.org/lkml/20200826111628.794979...@linutronix.de/ >> >>

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-10-30 Thread Dave Jiang
On 10/30/2020 1:48 PM, Thomas Gleixner wrote: On Fri, Oct 30 2020 at 11:50, Dave Jiang wrote: The code has dependency on Thomas’s MSI restructuring patch series: https://lore.kernel.org/lkml/20200826111628.794979...@linutronix.de/ which is outdated and not longer applicable. Yes I

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-10-30 Thread Thomas Gleixner
On Fri, Oct 30 2020 at 11:50, Dave Jiang wrote: > The code has dependency on Thomas’s MSI restructuring patch series: > https://lore.kernel.org/lkml/20200826111628.794979...@linutronix.de/ which is outdated and not longer applicable. Thanks, tglx

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-10-30 Thread Raj, Ashok
On Fri, Oct 30, 2020 at 04:30:45PM -0300, Jason Gunthorpe wrote: > On Fri, Oct 30, 2020 at 12:23:25PM -0700, Raj, Ashok wrote: > > On Fri, Oct 30, 2020 at 04:17:06PM -0300, Jason Gunthorpe wrote: > > > On Fri, Oct 30, 2020 at 12:13:48PM -0700, Dave Jiang wrote: > > > > > > > > > > > > On

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-10-30 Thread Jason Gunthorpe
On Fri, Oct 30, 2020 at 12:23:25PM -0700, Raj, Ashok wrote: > On Fri, Oct 30, 2020 at 04:17:06PM -0300, Jason Gunthorpe wrote: > > On Fri, Oct 30, 2020 at 12:13:48PM -0700, Dave Jiang wrote: > > > > > > > > > On 10/30/2020 11:58 AM, Jason Gunthorpe wrote: > > > > On Fri, Oct 30, 2020 at

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-10-30 Thread Raj, Ashok
On Fri, Oct 30, 2020 at 04:17:06PM -0300, Jason Gunthorpe wrote: > On Fri, Oct 30, 2020 at 12:13:48PM -0700, Dave Jiang wrote: > > > > > > On 10/30/2020 11:58 AM, Jason Gunthorpe wrote: > > > On Fri, Oct 30, 2020 at 11:50:47AM -0700, Dave Jiang wrote: > > > >

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-10-30 Thread Jason Gunthorpe
On Fri, Oct 30, 2020 at 12:13:48PM -0700, Dave Jiang wrote: > > > On 10/30/2020 11:58 AM, Jason Gunthorpe wrote: > > On Fri, Oct 30, 2020 at 11:50:47AM -0700, Dave Jiang wrote: > > > .../ABI/stable/sysfs-driver-dma-idxd |6 + > > > Documentation/driver-api/vfio/mdev-idxd.rst |

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-10-30 Thread Dave Jiang
On 10/30/2020 11:58 AM, Jason Gunthorpe wrote: On Fri, Oct 30, 2020 at 11:50:47AM -0700, Dave Jiang wrote: .../ABI/stable/sysfs-driver-dma-idxd |6 + Documentation/driver-api/vfio/mdev-idxd.rst | 404 ++ MAINTAINERS |1 +

Re: [PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-10-30 Thread Jason Gunthorpe
On Fri, Oct 30, 2020 at 11:50:47AM -0700, Dave Jiang wrote: > .../ABI/stable/sysfs-driver-dma-idxd |6 + > Documentation/driver-api/vfio/mdev-idxd.rst | 404 ++ > MAINTAINERS |1 + > drivers/dma/Kconfig |9 + >

[PATCH v4 00/17] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-10-30 Thread Dave Jiang
- Would like to acquire Reviewed-by tags from Thomas for MSI and IMS related bits. - Would like to acquire for Reviewed-by tags from Alex and/or Kirti for the VFIO mdev driver bits. - Would like to acquire for Reviewed-by tag from Bjorn for PCI common bits - Would like to acquire 5.11 kernel