Re: [PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env='

2018-05-26 Thread Ulf Magnusson
On Thu, May 24, 2018 at 6:45 AM, Masahiro Yamada wrote: > 2018-05-21 20:06 GMT+09:00 Ulf Magnusson : > >>> >>> static char *__expand_string(const char **str, bool (*is_end)(const char *)) >>> { >>> const char *in, *prev_in, *p; >>>

Re: [PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env='

2018-05-26 Thread Ulf Magnusson
On Thu, May 24, 2018 at 6:45 AM, Masahiro Yamada wrote: > 2018-05-21 20:06 GMT+09:00 Ulf Magnusson : > >>> >>> static char *__expand_string(const char **str, bool (*is_end)(const char *)) >>> { >>> const char *in, *prev_in, *p; >>> char *new, *out; >>> size_t outlen; >>>

Re: [PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env='

2018-05-23 Thread Masahiro Yamada
2018-05-21 20:06 GMT+09:00 Ulf Magnusson : >> >> static char *__expand_string(const char **str, bool (*is_end)(const char *)) >> { >> const char *in, *prev_in, *p; >> char *new, *out; >> size_t outlen; >> >> out = xmalloc(1); >> *out =

Re: [PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env='

2018-05-23 Thread Masahiro Yamada
2018-05-21 20:06 GMT+09:00 Ulf Magnusson : >> >> static char *__expand_string(const char **str, bool (*is_end)(const char *)) >> { >> const char *in, *prev_in, *p; >> char *new, *out; >> size_t outlen; >> >> out = xmalloc(1); >> *out = 0; >> >> p =

Re: [PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env='

2018-05-21 Thread Ulf Magnusson
On Mon, May 21, 2018 at 1:06 PM, Ulf Magnusson wrote: > On Mon, May 21, 2018 at 6:43 AM, Masahiro Yamada > wrote: >> Hi. >> >> >> >> 2018-05-21 0:46 GMT+09:00 Ulf Magnusson : >> >>> s/environments/environment variables/ >>

Re: [PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env='

2018-05-21 Thread Ulf Magnusson
On Mon, May 21, 2018 at 1:06 PM, Ulf Magnusson wrote: > On Mon, May 21, 2018 at 6:43 AM, Masahiro Yamada > wrote: >> Hi. >> >> >> >> 2018-05-21 0:46 GMT+09:00 Ulf Magnusson : >> >>> s/environments/environment variables/ >> >> Will fix. >> >> >>> +* They will be written out to

Re: [PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env='

2018-05-21 Thread Ulf Magnusson
On Mon, May 21, 2018 at 6:43 AM, Masahiro Yamada wrote: > Hi. > > > > 2018-05-21 0:46 GMT+09:00 Ulf Magnusson : > >> s/environments/environment variables/ > > Will fix. > > >> >>> +* They will be written out to

Re: [PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env='

2018-05-21 Thread Ulf Magnusson
On Mon, May 21, 2018 at 6:43 AM, Masahiro Yamada wrote: > Hi. > > > > 2018-05-21 0:46 GMT+09:00 Ulf Magnusson : > >> s/environments/environment variables/ > > Will fix. > > >> >>> +* They will be written out to include/config/auto.conf.cmd >>> +*/ >>> + env_add(name, value);

Re: [PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env='

2018-05-20 Thread Masahiro Yamada
Hi. 2018-05-21 0:46 GMT+09:00 Ulf Magnusson : > s/environments/environment variables/ Will fix. > >> +* They will be written out to include/config/auto.conf.cmd >> +*/ >> + env_add(name, value); >> + >> + return xstrdup(value); >> +} >> + >>

Re: [PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env='

2018-05-20 Thread Masahiro Yamada
Hi. 2018-05-21 0:46 GMT+09:00 Ulf Magnusson : > s/environments/environment variables/ Will fix. > >> +* They will be written out to include/config/auto.conf.cmd >> +*/ >> + env_add(name, value); >> + >> + return xstrdup(value); >> +} >> + >> +void

Re: [PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env='

2018-05-20 Thread Ulf Magnusson
On Thu, May 17, 2018 at 8:16 AM, Masahiro Yamada wrote: > To get access to environment variables, Kconfig needs to define a > symbol using "option env=" syntax. It is tedious to add a symbol entry > for each environment variable given that we need to define much

Re: [PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env='

2018-05-20 Thread Ulf Magnusson
On Thu, May 17, 2018 at 8:16 AM, Masahiro Yamada wrote: > To get access to environment variables, Kconfig needs to define a > symbol using "option env=" syntax. It is tedious to add a symbol entry > for each environment variable given that we need to define much more > such as 'CC', 'AS',

[PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env='

2018-05-17 Thread Masahiro Yamada
To get access to environment variables, Kconfig needs to define a symbol using "option env=" syntax. It is tedious to add a symbol entry for each environment variable given that we need to define much more such as 'CC', 'AS', 'srctree' etc. to evaluate the compiler capability in Kconfig. Adding

[PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env='

2018-05-17 Thread Masahiro Yamada
To get access to environment variables, Kconfig needs to define a symbol using "option env=" syntax. It is tedious to add a symbol entry for each environment variable given that we need to define much more such as 'CC', 'AS', 'srctree' etc. to evaluate the compiler capability in Kconfig. Adding