Re: [PATCH v4 09/16] drm: rockchip: add bpc and color mode setting

2015-09-05 Thread Yakir Yang
Hi Thierry, 在 09/03/2015 04:38 PM, Thierry Reding 写道: On Wed, Sep 02, 2015 at 06:02:25PM +0800, Yakir Yang wrote: 在 2015/9/2 16:34, Thierry Reding 写道: [...] At the very least your code must compile when applied against a recent upstream tree. I would also expect you to make sure the code

Re: [PATCH v4 09/16] drm: rockchip: add bpc and color mode setting

2015-09-03 Thread Thierry Reding
On Wed, Sep 02, 2015 at 06:02:25PM +0800, Yakir Yang wrote: > 在 2015/9/2 16:34, Thierry Reding 写道: [...] > >At the very least your code must compile when applied against a recent > >upstream tree. I would also expect you to make sure the code works at > >runtime, though, contrary to build testing,

Re: [PATCH v4 09/16] drm: rockchip: add bpc and color mode setting

2015-09-02 Thread Thierry Reding
On Wed, Sep 02, 2015 at 10:06:36AM +0800, Yakir Yang wrote: > 在 09/02/2015 05:00 AM, Heiko Stuebner 写道: > >Am Dienstag, 1. September 2015, 14:01:48 schrieb Yakir Yang: [...] > >>diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > >>b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index

Re: [PATCH v4 09/16] drm: rockchip: add bpc and color mode setting

2015-09-02 Thread Yakir Yang
Thierry, 在 2015/9/2 16:34, Thierry Reding 写道: On Wed, Sep 02, 2015 at 10:06:36AM +0800, Yakir Yang wrote: 在 09/02/2015 05:00 AM, Heiko Stuebner 写道: Am Dienstag, 1. September 2015, 14:01:48 schrieb Yakir Yang: [...] diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c

[PATCH v4 09/16] drm: rockchip: add bpc and color mode setting

2015-09-01 Thread Yakir Yang
From: Mark Yao Add bpc and color mode setting in rockchip_drm_vop driver, so connector could try to use the edid drm_display_info to config vop output mode. Signed-off-by: Mark Yao Signed-off-by: Yakir Yang --- Changes in v4: None

Re: [PATCH v4 09/16] drm: rockchip: add bpc and color mode setting

2015-09-01 Thread Yakir Yang
Hi Heiko, 在 09/02/2015 05:00 AM, Heiko Stuebner 写道: Hi Yakir, Am Dienstag, 1. September 2015, 14:01:48 schrieb Yakir Yang: From: Mark Yao Add bpc and color mode setting in rockchip_drm_vop driver, so connector could try to use the edid drm_display_info to config vop

Re: [PATCH v4 09/16] drm: rockchip: add bpc and color mode setting

2015-09-01 Thread Heiko Stuebner
Hi Yakir, Am Dienstag, 1. September 2015, 14:01:48 schrieb Yakir Yang: > From: Mark Yao > > Add bpc and color mode setting in rockchip_drm_vop driver, so > connector could try to use the edid drm_display_info to config > vop output mode. > > Signed-off-by: Mark Yao