Re: [PATCH v4 1/2] backlight: pwm_bl: Move the checks for initial power state to a separate function

2017-03-22 Thread Geert Uytterhoeven
Hi Philip, On Wed, Mar 22, 2017 at 11:46 AM, Philipp Zabel wrote: > On Tue, 2017-03-21 at 19:48 +0100, Geert Uytterhoeven wrote: >> On Tue, Nov 22, 2016 at 2:41 PM, Peter Ujfalusi >> wrote: >> > Move the checks to select the initial state for the

Re: [PATCH v4 1/2] backlight: pwm_bl: Move the checks for initial power state to a separate function

2017-03-22 Thread Geert Uytterhoeven
Hi Philip, On Wed, Mar 22, 2017 at 11:46 AM, Philipp Zabel wrote: > On Tue, 2017-03-21 at 19:48 +0100, Geert Uytterhoeven wrote: >> On Tue, Nov 22, 2016 at 2:41 PM, Peter Ujfalusi >> wrote: >> > Move the checks to select the initial state for the backlight to a new >> > function and document

Re: [PATCH v4 1/2] backlight: pwm_bl: Move the checks for initial power state to a separate function

2017-03-22 Thread Philipp Zabel
On Tue, 2017-03-21 at 19:48 +0100, Geert Uytterhoeven wrote: > Hi Peter, > > On Tue, Nov 22, 2016 at 2:41 PM, Peter Ujfalusi wrote: > > Move the checks to select the initial state for the backlight to a new > > function and document the checks we are doing. > > This is

Re: [PATCH v4 1/2] backlight: pwm_bl: Move the checks for initial power state to a separate function

2017-03-22 Thread Philipp Zabel
On Tue, 2017-03-21 at 19:48 +0100, Geert Uytterhoeven wrote: > Hi Peter, > > On Tue, Nov 22, 2016 at 2:41 PM, Peter Ujfalusi wrote: > > Move the checks to select the initial state for the backlight to a new > > function and document the checks we are doing. > > This is far from a simple

Re: [PATCH v4 1/2] backlight: pwm_bl: Move the checks for initial power state to a separate function

2017-03-21 Thread Geert Uytterhoeven
Hi Peter, On Tue, Nov 22, 2016 at 2:41 PM, Peter Ujfalusi wrote: > Move the checks to select the initial state for the backlight to a new > function and document the checks we are doing. This is far from a simple "move"... > With the separate function it is going to be

Re: [PATCH v4 1/2] backlight: pwm_bl: Move the checks for initial power state to a separate function

2017-03-21 Thread Geert Uytterhoeven
Hi Peter, On Tue, Nov 22, 2016 at 2:41 PM, Peter Ujfalusi wrote: > Move the checks to select the initial state for the backlight to a new > function and document the checks we are doing. This is far from a simple "move"... > With the separate function it is going to be easier to fix or improve

Re: [PATCH v4 1/2] backlight: pwm_bl: Move the checks for initial power state to a separate function

2016-12-09 Thread Lee Jones
On Tue, 22 Nov 2016, Peter Ujfalusi wrote: > Move the checks to select the initial state for the backlight to a new > function and document the checks we are doing. > > With the separate function it is going to be easier to fix or improve the > initial power state configuration later and it is

Re: [PATCH v4 1/2] backlight: pwm_bl: Move the checks for initial power state to a separate function

2016-12-09 Thread Lee Jones
On Tue, 22 Nov 2016, Peter Ujfalusi wrote: > Move the checks to select the initial state for the backlight to a new > function and document the checks we are doing. > > With the separate function it is going to be easier to fix or improve the > initial power state configuration later and it is

[PATCH v4 1/2] backlight: pwm_bl: Move the checks for initial power state to a separate function

2016-11-22 Thread Peter Ujfalusi
Move the checks to select the initial state for the backlight to a new function and document the checks we are doing. With the separate function it is going to be easier to fix or improve the initial power state configuration later and it is easier to read the code. Signed-off-by: Peter Ujfalusi

[PATCH v4 1/2] backlight: pwm_bl: Move the checks for initial power state to a separate function

2016-11-22 Thread Peter Ujfalusi
Move the checks to select the initial state for the backlight to a new function and document the checks we are doing. With the separate function it is going to be easier to fix or improve the initial power state configuration later and it is easier to read the code. Signed-off-by: Peter Ujfalusi