Re: [PATCH v4 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-04-08 Thread Wolfram Sang
On Wed, Mar 13, 2013 at 09:36:21AM -0700, Doug Anderson wrote: > The i2c-arbitrator-cros-ec driver implements the arbitration scheme > that the Embedded Controller (EC) on the ARM Chromebook expects to use > for bus multimastering. This i2c-arbitrator-cros-ec driver could also > be used in other p

Re: [PATCH v4 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-04-08 Thread Wolfram Sang
Guenter, > I think there is a difference between a bad driver or underlying hardware. To > me, "shipped" applies to hardware or firmware which can not be upgraded, not > to > the software running on it. OK. Valuable distinction. > "board support hosted in the I2C directory". But that is exactly

Re: [PATCH v4 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-04-07 Thread Guenter Roeck
On Sat, Apr 06, 2013 at 10:11:32PM +0200, Wolfram Sang wrote: > Hi, > > > Very interesting discussion, especially the argument that "we already > > shipped" > > would not be a convincing argument. > > > > I had senior kernel maintainers tell me and the company I work for that we > > should > >

Re: [PATCH v4 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-04-06 Thread Wolfram Sang
Hi, > Very interesting discussion, especially the argument that "we already shipped" > would not be a convincing argument. > > I had senior kernel maintainers tell me and the company I work for that we > should > submit _all_ our platform specific kernel code and drivers for inclusion into > the

Re: [PATCH v4 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-04-06 Thread Guenter Roeck
On Fri, Apr 05, 2013 at 02:03:52PM -0600, Stephen Warren wrote: > On 04/05/2013 01:37 PM, Simon Glass wrote: > > HI Wolfram, > > > > On Wed, Apr 3, 2013 at 12:19 PM, Wolfram Sang wrote: > >> Doug, > >> > >>> Separately from a discussion of the technical merits, I'd say that > >>> this patch is ne

Re: [PATCH v4 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-04-05 Thread Stephen Warren
On 04/05/2013 01:37 PM, Simon Glass wrote: > HI Wolfram, > > On Wed, Apr 3, 2013 at 12:19 PM, Wolfram Sang wrote: >> Doug, >> >>> Separately from a discussion of the technical merits, I'd say that >>> this patch is needed because the Embedded Controller (EC) on the ARM >>> Chromebook shipped expe

Re: [PATCH v4 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-03-13 Thread Stephen Warren
On 03/13/2013 10:59 AM, Doug Anderson wrote: > Stephen, > > On Wed, Mar 13, 2013 at 9:53 AM, Stephen Warren wrote: >>> Changes in v4: None >> >> Isn't this 'PATCH V3 REPOST' then? > > In this case part 2 in the patch series changes but not parts 1 and 3. > I could have just reposted part 2 with

Re: [PATCH v4 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-03-13 Thread Doug Anderson
Stephen, On Wed, Mar 13, 2013 at 9:53 AM, Stephen Warren wrote: >> Changes in v4: None > > Isn't this 'PATCH V3 REPOST' then? In this case part 2 in the patch series changes but not parts 1 and 3. I could have just reposted part 2 with a higher version, but that makes it a little harder to piec

Re: [PATCH v4 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-03-13 Thread Stephen Warren
On 03/13/2013 10:36 AM, Doug Anderson wrote: > The i2c-arbitrator-cros-ec driver implements the arbitration scheme > that the Embedded Controller (EC) on the ARM Chromebook expects to use > for bus multimastering. This i2c-arbitrator-cros-ec driver could also > be used in other places where standa

[PATCH v4 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-03-13 Thread Doug Anderson
The i2c-arbitrator-cros-ec driver implements the arbitration scheme that the Embedded Controller (EC) on the ARM Chromebook expects to use for bus multimastering. This i2c-arbitrator-cros-ec driver could also be used in other places where standard I2C bus arbitration can't be used and two extra GP