Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-11-09 Thread Jacek Anaszewski
Hi, On 11/09/2016 08:05 AM, Pavel Machek wrote: Hi! +struct uleds_device { + struct uleds_user_dev user_dev; + struct led_classdev led_cdev; + struct mutexmutex; + enum uleds_statestate; + wait_queue_head_t waitq; + unsigned

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-11-09 Thread Jacek Anaszewski
Hi, On 11/09/2016 08:05 AM, Pavel Machek wrote: Hi! +struct uleds_device { + struct uleds_user_dev user_dev; + struct led_classdev led_cdev; + struct mutexmutex; + enum uleds_statestate; + wait_queue_head_t waitq; + unsigned

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-11-08 Thread Pavel Machek
Hi! > >+struct uleds_device { > >+struct uleds_user_dev user_dev; > >+struct led_classdev led_cdev; > >+struct mutexmutex; > >+enum uleds_statestate; > >+wait_queue_head_t waitq; > >+unsigned char brightness; > > I've just noticed

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-11-08 Thread Pavel Machek
Hi! > >+struct uleds_device { > >+struct uleds_user_dev user_dev; > >+struct led_classdev led_cdev; > >+struct mutexmutex; > >+enum uleds_statestate; > >+wait_queue_head_t waitq; > >+unsigned char brightness; > > I've just noticed

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-11-08 Thread Jacek Anaszewski
On 11/08/2016 08:08 PM, David Lechner wrote: On 11/8/16 5:26 AM, Jacek Anaszewski wrote: Hi David, +struct uleds_device { +struct uleds_user_devuser_dev; +struct led_classdevled_cdev; +struct mutexmutex; +enum uleds_statestate; +wait_queue_head_t

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-11-08 Thread Jacek Anaszewski
On 11/08/2016 08:08 PM, David Lechner wrote: On 11/8/16 5:26 AM, Jacek Anaszewski wrote: Hi David, +struct uleds_device { +struct uleds_user_devuser_dev; +struct led_classdevled_cdev; +struct mutexmutex; +enum uleds_statestate; +wait_queue_head_t

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-11-08 Thread David Lechner
On 11/8/16 5:26 AM, Jacek Anaszewski wrote: Hi David, +struct uleds_device { +struct uleds_user_devuser_dev; +struct led_classdevled_cdev; +struct mutexmutex; +enum uleds_statestate; +wait_queue_head_twaitq; +unsigned charbrightness;

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-11-08 Thread David Lechner
On 11/8/16 5:26 AM, Jacek Anaszewski wrote: Hi David, +struct uleds_device { +struct uleds_user_devuser_dev; +struct led_classdevled_cdev; +struct mutexmutex; +enum uleds_statestate; +wait_queue_head_twaitq; +unsigned charbrightness;

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-11-08 Thread Jacek Anaszewski
Hi David, On 09/16/2016 09:16 PM, David Lechner wrote: This driver creates a userspace leds driver similar to uinput. New leds are created by opening /dev/uleds and writing a uleds_user_dev struct. A new leds class device is registered with the name given in the struct. Reading will return a

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-11-08 Thread Jacek Anaszewski
Hi David, On 09/16/2016 09:16 PM, David Lechner wrote: This driver creates a userspace leds driver similar to uinput. New leds are created by opening /dev/uleds and writing a uleds_user_dev struct. A new leds class device is registered with the name given in the struct. Reading will return a

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-09-24 Thread Pavel Machek
On Thu 2016-09-22 15:43:35, Linus Walleij wrote: > On Fri, Sep 16, 2016 at 9:16 PM, David Lechner wrote: > > > This driver creates a userspace leds driver similar to uinput. > > Just out of curiosity: what is this used for? > The typical usecase evades me, so I'd really

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-09-24 Thread Pavel Machek
On Thu 2016-09-22 15:43:35, Linus Walleij wrote: > On Fri, Sep 16, 2016 at 9:16 PM, David Lechner wrote: > > > This driver creates a userspace leds driver similar to uinput. > > Just out of curiosity: what is this used for? > The typical usecase evades me, so I'd really want to know. I have

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-09-22 Thread David Lechner
On 09/22/2016 08:43 AM, Linus Walleij wrote: On Fri, Sep 16, 2016 at 9:16 PM, David Lechner wrote: This driver creates a userspace leds driver similar to uinput. Just out of curiosity: what is this used for? The typical usecase evades me, so I'd really want to know.

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-09-22 Thread David Lechner
On 09/22/2016 08:43 AM, Linus Walleij wrote: On Fri, Sep 16, 2016 at 9:16 PM, David Lechner wrote: This driver creates a userspace leds driver similar to uinput. Just out of curiosity: what is this used for? The typical usecase evades me, so I'd really want to know. Several use cases are

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-09-22 Thread Linus Walleij
On Thu, Sep 22, 2016 at 3:43 PM, Linus Walleij wrote: > On Fri, Sep 16, 2016 at 9:16 PM, David Lechner wrote: >> +See tools/leds/uledmon.c for an example userspace program. > > Where is this program? Not in this patch for sure. Ah I found it by

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-09-22 Thread Linus Walleij
On Thu, Sep 22, 2016 at 3:43 PM, Linus Walleij wrote: > On Fri, Sep 16, 2016 at 9:16 PM, David Lechner wrote: >> +See tools/leds/uledmon.c for an example userspace program. > > Where is this program? Not in this patch for sure. Ah I found it by looking a bit closer at my mail archive, sorry

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-09-22 Thread Linus Walleij
On Fri, Sep 16, 2016 at 9:16 PM, David Lechner wrote: > This driver creates a userspace leds driver similar to uinput. Just out of curiosity: what is this used for? The typical usecase evades me, so I'd really want to know. > +See tools/leds/uledmon.c for an example

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-09-22 Thread Linus Walleij
On Fri, Sep 16, 2016 at 9:16 PM, David Lechner wrote: > This driver creates a userspace leds driver similar to uinput. Just out of curiosity: what is this used for? The typical usecase evades me, so I'd really want to know. > +See tools/leds/uledmon.c for an example userspace program. Where

[PATCH v4 1/3] leds: Introduce userspace leds driver

2016-09-16 Thread David Lechner
This driver creates a userspace leds driver similar to uinput. New leds are created by opening /dev/uleds and writing a uleds_user_dev struct. A new leds class device is registered with the name given in the struct. Reading will return a single byte that is the current brightness. The poll()

[PATCH v4 1/3] leds: Introduce userspace leds driver

2016-09-16 Thread David Lechner
This driver creates a userspace leds driver similar to uinput. New leds are created by opening /dev/uleds and writing a uleds_user_dev struct. A new leds class device is registered with the name given in the struct. Reading will return a single byte that is the current brightness. The poll()